[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-12 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-531042083 @stone-wlg The twitter belongs to you, https://twitter.com/ASFSkyWalking/status/1172288313559928832 ---

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-12 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-531036319 /run e2e This is an automated message from the Apache Git Service. To respo

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-12 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530986178 /run ci This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-12 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530986077 /run e2e This is an automated message from the Apache Git Service. To respo

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-12 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530848748 @stone-wlg Welcome to be 156th contributor. Look forward to more contributions from you. --

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530683030 I think the plugins supporting more versions, right? Just in test case, we plan to merge one version. @zhaoyuguang run tests again.

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530681042 You need to update this PR and test cases. This is an automated message fro

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530670216 @stone-wlg Your comment format is not clear. Could you reformat it? This is

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530656802 > if i intercept both sync and async as EXIT SPAN what is going on in skywalking? Depend on what kind of codes you are written, basic

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530421042 I guess, otherwise, it will break as last time we tried(right?) This is an

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530415244 /run ci This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530411626 /run ci This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530399935 @kezhenxu94 @zhaoyuguang Please recheck. This is an automated message from

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530399802 /run ci This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-11 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530379633 @stone-wlg I will keep only one test case, maybe our server has the same memory issue too. @dmsolr Are you OK with this PR now?

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-10 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-530236913 Any update about empty expected file? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529772269 @dmsolr Have you run in parallel_run_size>1? This is an automated message f

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529333012 @dmsolr Could you run tests locally? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529161849 > Currently, i am working monitor whatever log, metric and trace. i am thinking that is it necessary to add MQ(kafka) between skywalking age

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529161420 > Currently, i intercept getUninterruptibly method by LOCAL METHOD in skywalking. So we can get accurate execution time whatever sync or asy

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529161372 Let's wait for test case and 6.4.0 shipped. We are only fixing bugs before 6.4.0 release. -

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529161261 > No, the key is the getUninterruptibly method. it likes lazy mode or cursor of database. OK. That is another story. I am thinking ab

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529160991 > yes, we have. But I could not find `span#prepareForAsync`. Is there unnecessary now? --

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529131739 @stone-wlg Do you update this PR to support `async` execution? Do you have the accurate execution time now? ---

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529131403 @dmsolr I was really pinging you, to make sure you don't have a further review to do. Why are you still awake at this moment? -

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-07 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529127589 @dmsolr Any update? @zhaoyuguang Please run this codes test case again. I want to see any good luck this time.