[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-22 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533860104 You should intercept the constructor. Then you could get it at the initialization stage.

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-22 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533859719 Have you enhanced `InterceptorCallback`? I think the snapshot could propagate through the constructor.

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-21 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533848183 I mean, you need to intercept buildCallback method, and create a manual class implementing Callable and EnhancedClass. Make

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-21 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533847789 Isn't it a callback implementor? I am little confused. How could you enhance all callback implementors? It is possible, but

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-21 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533846733 What do you mean can't enhance? It looks like just intercepting return value, and change it to our own callback.

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-19 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533180262 OK. Take your time, if you could find the codebase, we could talk about it.

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-19 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-533160076 @stalary Could you find the codes of `KafkaTemplate$$Lambda$522/515652386`? What is the lamda in the source code?

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-19 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532987351 @stalary Any update? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532227110 Such as from this error log, we are intercepting `KafkaProducer` constructor, right? >

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532224926 I am not asking there must be a Spring-kafka plugin, but the kafka plugin should work as expected. In some cases,

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532224590 > However, an error is reported when it passes through the kafka-plugin Why? If we intercept the right place, then

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-53862 > When spring-kafka exists, how can I enable spring-kafka-plugin by not launching the kafka plugin,I need a little help.

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532210148 @stalary do you have interest to enhance this part? This

[GitHub] [skywalking] wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka

2019-09-17 Thread GitBox
wu-sheng commented on issue #3478: Kafka plugin not work on Spring Boot and Spring Kafka URL: https://github.com/apache/skywalking/issues/3478#issuecomment-532209203 Need new support for Spring Kafka. This is an automated