[GitHub] [skywalking] wu-sheng commented on issue #3752: Add gRPCHook to alarm-settings.yml

2019-10-30 Thread GitBox
wu-sheng commented on issue #3752: Add gRPCHook to alarm-settings.yml URL: https://github.com/apache/skywalking/issues/3752#issuecomment-548051293 I am thinking about `webhooks` should keep one only, but for compatible, we could keep it unchanged. @kezhenxu94 Only idea about this?

[GitHub] [skywalking] wu-sheng commented on issue #3752: Add gRPCHook to alarm-settings.yml

2019-10-30 Thread GitBox
wu-sheng commented on issue #3752: Add gRPCHook to alarm-settings.yml URL: https://github.com/apache/skywalking/issues/3752#issuecomment-548043660 Be aware, this `gRPCHook` could be updated through dynamic configuration feature. And, I am assuming only one gRPC endpoint should be enough,

[GitHub] [skywalking] wu-sheng commented on issue #3752: Add gRPCHook to alarm-settings.yml

2019-10-30 Thread GitBox
wu-sheng commented on issue #3752: Add gRPCHook to alarm-settings.yml URL: https://github.com/apache/skywalking/issues/3752#issuecomment-548041893 @JaredTan95 Do you have time to add this in these two days? As @x22x22 should submit UI update in this weekend, we should have 4-5 days to land