[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

2019-12-13 Thread GitBox
wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565672767 We include exit span in the plugin test cases, I have to remove them one by one, sadly ---

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

2019-12-13 Thread GitBox
wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565687095 @dmsolr @wayilau @arugal I already updated the plugin test document and existing plugin test cases. Please revi

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

2019-12-13 Thread GitBox
wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565687108 FYI @cyejing This is an automated message fro

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

2019-12-13 Thread GitBox
wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565693137 @kezhenxu94 @ascrutae All tests passed, but I think you should run a local test to re-verify.

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

2019-12-14 Thread GitBox
wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565703313 > Hi, go2sky needs to be modified? You could recheck. In my mind, all other agents and SDK are not using