wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-580172776
@kezhenxu94 Could you recheck this recently?
This is an automated message from the Apache Git Se
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-579136931
You could use another issue or mail list to discuss this. But to be honest,
I can't see much difference. Many discussions have been done about this.
---
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575198294
Got it. Waiting for you update.
This is an automated message from the Apache Git Service.
To res
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573539623
I will do the review after you remove the configurations and make the
tracing working at client/server sides with callback. Thanks for your
contributions.
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573529288
> I can simplify client-side tracing for this, like no onMessage event, only
Complete/Close event for internal client-side tracing.
I think in most cases,
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573522600
If no client-side span, there is no client-side metrics of topology. Then
you would detect the error of unreachable or network perf unstable issues from
trace a
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-573482503
> Internal and external gRPC server tracing
It is still unclear for me about this section. Client/server side tracing
are both required in nearly every RP
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-571876290
> Provide the internal or external gRPC server tracing mode.
What is this? Could you explain a little more?
--
wu-sheng commented on issue #4177: Enhance gRPC plugin
URL: https://github.com/apache/skywalking/pull/4177#issuecomment-571581668
> This is a very good pull request template for the plugin contribution.
Anyone want to discuss about new issue and pull request templates?
-
