wu-sheng edited a comment on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885662803


   You haven't gotten my point. If spans could be duplicate, then both plugins 
work, then the only possibility a trace breaks, because the context doesn't 
propagate(across threads mostly), you just need a snapshot to propagate a 
context. Right now, you are creating another span, which makes you facing the 
duplicate span issue. We have plugins for Spring scope and out of Spring scope, 
they should not influence each other.
   
   The plugin system is complex, we should never make users to determine how to 
choose in or out Spring use case, they will be confused about the difference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to