[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-18 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1141024027 ## test/cases/measure/data/testdata/service_instance_cpm_minute_data.json: ## @@ -155,7 +155,7 @@ }, { "str": { -

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-16 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1139597264 ## test/cases/measure/data/testdata/service_instance_cpm_minute_data.json: ## @@ -155,7 +155,7 @@ }, { "str": { -

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-16 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1139597264 ## test/cases/measure/data/testdata/service_instance_cpm_minute_data.json: ## @@ -155,7 +155,7 @@ }, { "str": { -

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-15 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1138047169 ## test/cases/measure/data/testdata/service_instance_cpm_minute_data.json: ## @@ -0,0 +1,212 @@ +[ + { +"tag_families": [ + { +"tags"

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-15 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1138042139 ## banyand/measure/measure_topn.go: ## @@ -469,18 +498,20 @@ func (manager *topNProcessorManager) buildMapper(fieldName string, groupByNames

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-14 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1136506714 ## banyand/measure/measure_write.go: ## @@ -131,9 +131,12 @@ func (s *measure) write(shardID common.ShardID, entity []byte, entityValues tsdb