[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: change some grammar to resolve "CI"

2022-09-01 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r960489936 ## tools/check-license-header.py: ## @@ -45,7 +45,7 @@ comment_leading_chars = ('#', '::', '/*', '*', ' ') exclude_dirs = ('.git', 'lib', 'node_modules', '

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: change some grammar to resolve "CI"

2022-09-01 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r960477141 ## tools/check-license-header.py: ## @@ -45,7 +45,7 @@ comment_leading_chars = ('#', '::', '/*', '*', ' ') exclude_dirs = ('.git', 'lib', 'node_modules', '

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: change some grammar to resolve "CI"

2022-09-01 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r960477141 ## tools/check-license-header.py: ## @@ -45,7 +45,7 @@ comment_leading_chars = ('#', '::', '/*', '*', ' ') exclude_dirs = ('.git', 'lib', 'node_modules', '

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: change some grammar to resolve "CI"

2022-09-01 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r960474943 ## index.d.ts: ## @@ -0,0 +1,21 @@ +export as namespace ClientMonitor; Review Comment: so,I have completed the license。 -- This is an automated message

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: change some grammar to resolve "CI"

2022-09-01 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r960470358 ## index.d.ts: ## @@ -0,0 +1,21 @@ +export as namespace ClientMonitor; Review Comment: sorry,i dont know how to do right, i try it -- This is an autom

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: change some grammar to resolve "CI"

2022-09-01 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r960463806 ## index.d.ts: ## @@ -0,0 +1,21 @@ +export as namespace ClientMonitor; Review Comment: its rabbit write,i will delete it -- This is an automated messag