mohammedtabish0 commented on PR #132:
URL: https://github.com/apache/skywalking-eyes/pull/132#issuecomment-1233005446
@kezhenxu94
Haven't added `> /dev/null 2>&1` and `|| true` so that command is runnable
in other platforms like windows(do we really need it?). But will cause issue if
b
mohammedtabish0 commented on PR #132:
URL: https://github.com/apache/skywalking-eyes/pull/132#issuecomment-1234018322
@kezhenxu94 Agreed, added these commands.
Also, I have made it different from [skywalking's makefile
](https://github.com/apache/skywalking) as IMO the `|| true` should on
mohammedtabish0 commented on PR #132:
URL: https://github.com/apache/skywalking-eyes/pull/132#issuecomment-1234997151
@kezhenxu94 This was really fun, although I changed only three lines but got
to learn a lot. Thank you so much for the patience and guidance. Hope to
contribute more to the
