liubao68 commented on PR #127:
URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141575759
@wu-sheng I guess @jaryzou thinks when both 1.x and 2.x plugins are load by
skywalking, the plugin used maybe 1.x or 2.x. And It is useless to write a new
plugin for 2.x.
I
liubao68 commented on PR #127:
URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141581147
I checked ClassInstanceMethodsEnhancePluginDefine
```
@Override
protected ClassMatch enhanceClass() {
return NameMatch.byName(ENHANCE_CLASS);
liubao68 commented on PR #127:
URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141583791
Thanks, we'll further to check how skywalking checks the target plugin to
use.
BTW, do you think this scenario can be improved ? e.g. when two versions
have same signature
liubao68 commented on PR #127:
URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141591692
Thanks, we'll check how to use witness class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
