[GitHub] [skywalking-nginx-lua] spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383666410 ## File path: README.md ## @@ -48,7 +48,9 @@ http { pr

[GitHub] [skywalking-nginx-lua] spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383629135 ## File path: README.md ## @@ -48,7 +48,9 @@ http { pr

[GitHub] [skywalking-nginx-lua] spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383628455 ## File path: README.md ## @@ -48,7 +48,9 @@ http { pr