[GitHub] [skywalking-rust] wu-sheng commented on pull request #55: Add sub components licenses in dist material.

2023-03-01 Thread via GitHub
wu-sheng commented on PR #55: URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1449572890 > There is a problem here. The dependent version specified by `Cargo.toml` is not necessarily the version actually used by the user, but the minimum compatible version, while the sum

[GitHub] [skywalking-rust] wu-sheng commented on pull request #55: Add sub components licenses in dist material.

2023-02-24 Thread via GitHub
wu-sheng commented on PR #55: URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1443351542 > The `license-eye` has a bug when generating the LICNESE file for rust project, so skip the CI checking of `dist-meterial/LICNESE` in this PR? Please report the bug. You could

[GitHub] [skywalking-rust] wu-sheng commented on pull request #55: Add sub components licenses in dist material.

2023-02-22 Thread via GitHub
wu-sheng commented on PR #55: URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1441275814 > But I don't found NOTICE file in sub component repositories. If you can't, you don't need to copy anything. Just keep the repository name, version, license in the dist/licens