[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-17 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1140223868 ## plugins/forwarder/kafka/nativetracing/forwarder.go: ## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-17 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1140020793 ## plugins/forwarder/kafka/nativetracing/forwarder.go: ## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-17 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139839932 ## test/e2e/case/native-protocols-kafka/satellite_config_kafka.yaml: ## @@ -0,0 +1,597 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-17 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139837096 ## test/e2e/case/native-protocols-kafka/satellite_config_kafka.yaml: ## @@ -0,0 +1,597 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-17 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139837096 ## test/e2e/case/native-protocols-kafka/satellite_config_kafka.yaml: ## @@ -0,0 +1,597 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-17 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139833539 ## plugins/forwarder/kafka/nativetracing/forwarder.go: ## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-16 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139645943 ## plugins/forwarder/kafka/nativetracing/forwarder.go: ## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-16 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139510233 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-16 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1139507954 ## plugins/forwarder/kafka/nativetracing/forwarder.go: ## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137952035 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137913791 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137913791 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137153597 ## plugins/forwarder/kafka/nativetracing/forwarder.go: ## @@ -0,0 +1,121 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137140222 ## plugins/forwarder/kafka/nativemeter/forwarder.go: ## @@ -0,0 +1,125 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137122400 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137122400 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137122400 ## plugins/forwarder/kafka/nativelog/forwarder.go: ## @@ -80,10 +82,16 @@ func (f *Forwarder) Forward(batch event.BatchEvents) error { if

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137107997 ## docs/en/setup/plugins/forwarder_native-meter-kafka-forwarder.md: ## @@ -0,0 +1,15 @@ +# Forwarder/native-meter-kafka-forwarder +## Description +This is

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137105786 ## .github/workflows/publish-docker.yaml: ## @@ -20,6 +20,7 @@ on: push: branches: - main + - kafka-forwards Review Comment:

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137105296 ## .github/workflows/e2e-istio.yaml: ## @@ -21,6 +21,7 @@ on: push: branches: - main + - kafka-forwards Review Comment: Should be

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137104527 ## .github/workflows/build-and-test.yaml: ## @@ -21,6 +21,7 @@ on: push: branches: - main + - kafka-forwards Review Comment: This

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-15 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1137103242 ## configs/satellite_config_kafka.yaml: ## @@ -0,0 +1,605 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1135259663 ## .github/workflows/e2e-native-kafka.yaml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor