Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1232788241
Thanks for the helping, and gald to see the PR had been accepted, it's
pleasure for me to implement the feature for SWCK.
--
This is an automated message from the Apache Gi
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1230196020
Hi @dashanji , changes are done, please have a review and run the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1229651297
@dashanji you are right, the problem had been solved, thanks.
And one more thing. I would like to remove
"strategy.skywalking.apache.org/agent.Overlay" annotation. i
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1229451607
Hi @dashanji
I got a problem adding verifying on optional plugin.
i can use the following scripts to generate a yaml
``` bash
kubectl logs -l app=demo
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1227100426
> Hi @Duncan-tree-zhou, is there any progress on optional plugin e2e testing?
Ok. I get your point. but it looks like that it's difficult to know whether
the optional p
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1227090287
> Hi @Duncan-tree-zhou, is there any progress on optional plugin e2e testing?
Actually, there are no changes for optional plugin, i didn't find a good way
to change it.
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1217485197
three more changes:
1. the configmap would not be mounted if it's not set in annotation or
swagent.
2. if configmap not set, the servicename and backend url in javaagent
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1208324937
For the `optionalPlugins` part, I want to take my words back. In fact the
sharedVolumn is an empty volumn. It means that there are nothing in the
sharedVolumn until initconta
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1208312481
> Good idea. BTW, could we remove the `agent.config` mount? As we only need
to read the default configmap (used for global configuration) and set the value
through environmen
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1208037028
Ok, I think I get your idea. But do you think it's a little bit comlicated
way to config optional plugins? How about remove and hard code `sharedVolume.
mountPath` , and gene
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1207958699
> 2\. In addition to environment variables, the agent configuration has some
file configurations, such as optional plugins, as we
[discussed](https://github.com/a
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1207372804
> Is there a progress recently?
will apply the changes in the next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1203435988
the e2e test case passed after i re-run the failed job.
https://github.com/Duncan-tree-zhou/skywalking-swck/actions/runs/2783221000
It looks like it's a resource
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1201201234
Hi @hanahmily @dashanji, the github action passed in my repo, please have a
review and make an approval.
--
This is an automated message from the Apache Git Service.
To res
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1186445395
> Licenses are generated by skywalking-eyes tool. You could refer its docs.
I am sure i had generate licenses files by skywalking-sys. But it looks like
that the skywal
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1186411313
Hi, do you know how to re-generate the following files? i run "make check"
locally，it looks like the files are not re-generated.
``` bash
git diff >/tmp/artifacts/ch
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1175222342
I get some problem to run golangci-lint locally.
``` sh
╰$ cd ./operater
╰$ make lint
/Users/duncan/gitRepo/skywalking-swck/hack/build/../../bin/golangci-li
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1173996077
Hi there, the "oap-ui-agent-crd" step is added, and all validations and
tests pass in my repo. You can have a review and run the github action.
--
This is an automated mess
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1171474825
Sorry that it's my fault, the shared volume didn't mount to the target
containers when no swagent created. Now the bug had been fixed and the test
passed locally.
And
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1170126089
Hi @dashanji , how to run the test case in github?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1160596111
> experience, it should not be caused by request limitations. But this
version of e2e may have some bugs, which I have fixed in this
[PR](https://github.com/apache/skywalking
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1160049805
Hi @dashanji , it's not the final version, docs and some minor fix is on the
way. But it look like the test error was not cause by SwAgent logic, do you
think it would cause
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1158594630
@wu-sheng @hanahmily It's forward forward compatible, the main change is add
a global config layer between annotation user config and annotation default
config.
--
This is
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1158414730
> Could you please add the e2e test of `SwAgent` and the documentation on
how to use it？BTW, how about deleting the `webhook_suit_test.go` and
`suite_test.go` as we have the
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1158407117
dd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1158401408
@dashanji any guide or doc for how to add e2e test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1157868340
Hi @dashanji , vendor had been removed.
here are the changes:
1. add SwAgent CRD
- inlcuding label selector and container matcher.
- the sidecar con
Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1157834645
#66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
28 matches
Mail list logo
