[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

2018-04-11 Thread GitBox
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104 @nikitap492 Thanks. That is better to understand your pr. Then I will focus on codes only for this pr. At lea

[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

2018-04-11 Thread GitBox
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104 @nikitap492 Thanks. That is better to understand your pr. Then I will focus on codes only for this pr. At lea

[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

2018-04-11 Thread GitBox
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380493664 @nikitap492 For better and easier review and further merge, I recommend you close this pr, and open several separated

[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

2018-04-17 Thread GitBox
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-382216599 @nikitap492 Are you still going to send this in two separated PRs? We are waiting for those. ---