[GitHub] wu-sheng commented on issue #2035: Support canal plugin

2018-12-14 Thread GitBox
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447529078 @ascrutae Please do code review. This is an automated message from the Apache Git Se

[GitHub] wu-sheng commented on issue #2035: Support canal plugin

2018-12-13 Thread GitBox
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447206701 @ascrutae From discussion, this related to #1805 somehow. This is an automated messa

[GitHub] wu-sheng commented on issue #2035: Support canal plugin

2018-12-13 Thread GitBox
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447188161 From your description, if client runs in pull mode, it should use entry span, with peer tag in it. And then we need a server side adjustment to suppo

[GitHub] wu-sheng commented on issue #2035: Support canal plugin

2018-12-13 Thread GitBox
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447061993 For my understanding of canal, I assume, we at least need source and destination of canal data sync. Am I right? Where is the entry span? And the tr

[GitHub] wu-sheng commented on issue #2035: Support canal plugin

2018-12-13 Thread GitBox
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447061196 Also, you need to add lib and versions into the supported list after we could be sure about the purpose of this plugin.