[GitHub] wu-sheng commented on issue #2090: Support Gson Plugin

wu-sheng commented on issue #2090: Support Gson Plugin URL: https://github.com/apache/incubator-skywalking/pull/2090#issuecomment-450619852 @WithLin look like tests fail. Please verify and fix. This is an automated message fr

[GitHub] wu-sheng commented on issue #2090: Support Gson Plugin

wu-sheng commented on issue #2090: Support Gson Plugin URL: https://github.com/apache/incubator-skywalking/pull/2090#issuecomment-450500987 Look like we have 2 for default and 2 for optional. Then for safety, let's move it to optional now. @WithLin Also, this movement means, you need to ad

[GitHub] wu-sheng commented on issue #2090: Support Gson Plugin

wu-sheng commented on issue #2090: Support Gson Plugin URL: https://github.com/apache/incubator-skywalking/pull/2090#issuecomment-450379480 What do you mean, generate those tracer? Guarantee? Or ? This is an automated

[GitHub] wu-sheng commented on issue #2090: Support Gson Plugin

wu-sheng commented on issue #2090: Support Gson Plugin URL: https://github.com/apache/incubator-skywalking/pull/2090#issuecomment-450335269 @ascrutae but, even in optional, your scenario still exists. For auto instrument, you can't choose which parts are going to generate span, right? The