[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-14 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-454273137 The `ref==0` is what I expected when you said the trace is broken. As I said, the context propagation doesn't work right. So, if you could

[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-08 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-452593621 When this NPE happens, it mean there is agent register data deleted, but the agent doesn't reboot.

[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-08 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-452522413 I am not sure why, but shouldn't. But creating span is a lightweight op, shouldn't be effected by header/ref.

[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-08 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-452338007 Then you need to find out whether the segment including this span(service B) finish or not, and the segment is in the same trace id.

[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-08 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-452269661 What do you mean no entry span? This is an automated message from the

[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-08 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-452238434 When thread changed, creating new context is expected and right. This is

[GitHub] wu-sheng commented on issue #2134: Hystrix Or agent core bug

2019-01-08 Thread GitBox
wu-sheng commented on issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134#issuecomment-45932 The topology is not related to `sw6` header and entry/exit spans. So you need to check 1. Exit span of service A still generated. 1.