songzhendong closed pull request #12072: Add Apache Airflow Monitoring
URL: https://github.com/apache/skywalking/pull/12072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2063956604
No update for a week. @songzhendong If you want to continue to make this
ready to merge, please let me know.
--
This is an automated message from the Apache Git Service.
To
songzhendong commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2047995724
> FYI @songzhendong We will update the MAL implementation for #11992. Then
UI side will update to support multiple-label tags as well.
>
> You will need to update this PR
songzhendong commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2047994604
> FYI @songzhendong We will update the MAL implementation for #11992. Then
UI side will update to support multiple-label tags as well.
>
> You will need to update this PR
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2044327249
FYI @songzhendong We will update the MAL implementation for
https://github.com/apache/skywalking/issues/11992. Then UI side will update to
support multiple-label tags as well.
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1555122490
##
test/e2e-v2/cases/airflow/airflow-exporter/otel-collector-config.yaml:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one or
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1555121756
##
test/e2e-v2/cases/airflow/airflow-main/e2e.yaml:
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1555120308
##
test/e2e-v2/cases/airflow/airflow-exporter/otel-collector-config.yaml:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one or
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554996072
##
test/e2e-v2/cases/airflow/airflow-exporter/otel-collector-config.yaml:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one or
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554974594
##
test/e2e-v2/cases/airflow/airflow-main/docker-compose.yaml:
##
@@ -0,0 +1,139 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2041486644
Please recheck UI submodule, you are changing that unexpectedly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554985214
##
docs/en/changes/changes.md:
##
@@ -103,7 +106,9 @@
* Enhance VNode logic and support multiple Trace IDs in span's ref.
* Add the layers filed and associate
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2041409947
Don't close a PR, as you only update things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
songzhendong closed pull request #12072: Add Apache Airflow Monitoring
URL: https://github.com/apache/skywalking/pull/12072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554831337
##
docs/en/swip/readme.md:
##
@@ -71,7 +71,7 @@ All accepted and proposed SWIPs can be found in
[here](https://github.com/apache
Next SWIP Number: 6
Review
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554797512
##
test/e2e-v2/cases/airflow/airflow-main/docker-compose.yaml:
##
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554796948
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/airflow/airflow-instance.json:
##
@@ -0,0 +1,395 @@
+[
+ {
+"id":
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554796948
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/airflow/airflow-instance.json:
##
@@ -0,0 +1,395 @@
+[
+ {
+"id":
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554794056
##
docs/en/setup/backend/backend-ariflow-monitoring.md:
##
@@ -0,0 +1,56 @@
+# Apache Airflow monitoring
+## Airflow server performance from 'OpenTelemetry'
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554793813
##
test/e2e-v2/cases/airflow/airflow-main/docker-compose.yaml:
##
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554792979
##
test/e2e-v2/cases/airflow/airflow-main/docker-compose.yaml:
##
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
wankai123 commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554763079
##
test/e2e-v2/cases/airflow/airflow-main/airflow2.cfg:
##
@@ -0,0 +1,2224 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2041134149
And, you still don't resolve conflicts. Learn git more please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554637150
##
docs/en/changes/changes.md:
##
@@ -104,7 +106,10 @@
* Add the layers filed and associate layers dashboards for the service
topology nodes.
* Fix
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554630917
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml:
##
@@ -47,6 +47,16 @@ menus:
description: Observe the virtual
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2041122182
https://github.com/apache/skywalking/assets/5441976/4d0f875e-9b81-4d03-896e-84f900808baa;>
You still don't fix the conflicts, CI would not run until you fix it.
--
This is
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554630859
##
docs/menu.yml:
##
@@ -188,6 +188,10 @@ catalog:
path: "/en/setup/service-agent/virtual-cache"
- name: "Virtual MQ"
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2041083959
SWIP and relative updates are missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wu-sheng commented on code in PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#discussion_r1554587580
##
docs/menu.yml:
##
@@ -188,6 +188,8 @@ catalog:
path: "/en/setup/service-agent/virtual-cache"
- name: "Virtual MQ"
wu-sheng commented on PR #12072:
URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2041076127
With https://github.com/apache/skywalking/pull/12076 gets merged, you should
have the expected menu.
Then, you should fix all CI tasks. UI submodule should be reverted.
--
songzhendong opened a new pull request, #12072:
URL: https://github.com/apache/skywalking/pull/12072
### Add Apache Airflow Monitoring
- [x] Update the documentation to include this new feature.
- Documentation has been updated in the `docs` directory.
- [x]
31 matches
Mail list logo
