wu-sheng merged PR #323:
URL: https://github.com/apache/skywalking-python/pull/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Superskyyy commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1791512135
Since tid is injected into the logging record, user could also utilize this
to print out the tid in whatever channel they want other than only the reported
logs to oap, this
Superskyyy commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1380723372
##
docs/en/setup/advanced/LogReporter.md:
##
@@ -103,4 +103,7 @@ Will result in:
}
]
}
-```
\ No newline at end of file
+```
+
+## Print trace ID
kezhenxu94 commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1378431103
##
skywalking/log/sw_logging.py:
##
@@ -75,6 +77,9 @@ def build_log_tags() -> LogTags:
context = get_context()
+if
Superskyyy commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1378115929
##
skywalking/log/sw_logging.py:
##
@@ -75,6 +77,9 @@ def build_log_tags() -> LogTags:
context = get_context()
+if
CodePrometheus commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1378075327
##
skywalking/log/sw_logging.py:
##
@@ -75,6 +77,9 @@ def build_log_tags() -> LogTags:
context = get_context()
+if
CodePrometheus commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1378075327
##
skywalking/log/sw_logging.py:
##
@@ -75,6 +77,9 @@ def build_log_tags() -> LogTags:
context = get_context()
+if
kezhenxu94 commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1377013220
##
skywalking/log/sw_logging.py:
##
@@ -75,6 +77,9 @@ def build_log_tags() -> LogTags:
context = get_context()
+if
Superskyyy commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1784484385
Code LGTM, please regenerate the configuration documentation by running the
checklist command below. I will test it locally tmr.
- [ ] I have rebuilt the
Superskyyy commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1784482501
Yes, I have a fix coming, it is due to a upstream dependency bug in flask, I
will hold the merge of this pr untill that one is fixed first.
--
This is an automated message
wu-sheng commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1784118314
@Superskyyy Please recheck, and fix the main branch if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
CodePrometheus commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1784094497
The latest CI exception does not seem to be caused by this PR change.
wu-sheng commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1783977958
@CodePrometheus Please fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wu-sheng commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1783943163
@Superskyyy As this is a terminal output, we don't have CI to verify this.
Could you review and test locally?
--
This is an automated message from the Apache Git Service.
To
Superskyyy commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1774206795
> Copy that, thanks for the reply, this is my negligence, please give me
some time, I will improve this PR as soon as possible.
No problem! I will be waiting patiently,
CodePrometheus commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1774153836
Copy that, thanks for the reply, this is my negligence, please give me some
time, I will improve this PR as soon as possible.
--
This is an automated message from the
Superskyyy commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1765261102
Oh I just realized your understanding of this feature from conversation in
[#323](https://github.com/apache/skywalking/issues/10734#issuecomment-1752038813)
was not entirely
Superskyyy commented on code in PR #323:
URL: https://github.com/apache/skywalking-python/pull/323#discussion_r1361242292
##
skywalking/loggings.py:
##
@@ -22,12 +22,21 @@
logger_debug_enabled = False
+class SWFilter(logging.Filter):
+def filter(self, record):
+
Superskyyy commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1765235761
> @Superskyyy Is there any doc about introducing how to use the logger?
Not about this particular feature, @CodePrometheus would you mind adding a
small doc to this
wu-sheng commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1757953843
@Superskyyy Is there any doc about introducing how to use the logger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
CodePrometheus commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1757858640
> Please update the docs accordingly.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
wu-sheng commented on PR #323:
URL:
https://github.com/apache/skywalking-python/pull/323#issuecomment-1757836928
Please update the docs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
CodePrometheus opened a new pull request, #323:
URL: https://github.com/apache/skywalking-python/pull/323
- [x] If this pull request closes/resolves/fixes an existing issue, replace
the issue url. Closes:
23 matches
Mail list logo
