Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
wu-sheng commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011078975 Close for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
wu-sheng closed pull request #676: Bump up lombok version to 1.18.30 to support JDK21 URL: https://github.com/apache/skywalking-java/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
lujiajing1126 commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011051263 > I follow the advice of [Java Agent Compiling porject](https://skywalking.apache.org/docs/skywalking-java/next/en/contribution/compiling/) and use JDK 21. There is a little p

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
OrezzerO commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011040754 I follow the advice of [Java Agent Compiling porject](https://skywalking.apache.org/docs/skywalking-java/next/en/contribution/compiling/) and use JDK 21. I checked Github Action co

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
wu-sheng commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011007700 > Eh, but how did the agent pass GitHub action testing though..? or java agent hasn't been tested on jdk21 yet The agent is ready, but the target libs may or may not, dependi

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
wu-sheng commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011006633 Agree, I have the same question, is this bump up necessary for all tests. Because basically, different tests are not expected to run on locked JDK versions. Some of the lib, especi

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
lujiajing1126 commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011000801 > Fix compile problem when run scenario test. I suppose you have to use JDK8 or 17 for those scenarios based on the workflows defined in the repo. For other cases

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
lujiajing1126 commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2010996984 > Eh, but how did the agent pass GitHub action testing though..? or java agent hasn't been tested on jdk21 yet JDK21 is only tested for Spring 6.x scenario... --

Re: [PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
Superskyyy commented on PR #676: URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2010524334 Eh, but how did the agent pass GitHub action testing though..? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] Bump up lombok version to 1.18.30 to support JDK21 [skywalking-java]

2024-03-20 Thread via GitHub
OrezzerO opened a new pull request, #676: URL: https://github.com/apache/skywalking-java/pull/676 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://githu