ZhengBing520 commented on PR #11788:
URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1991046398
> > > So I change topN group key to entityId + timeBucket, then stash map
can only reserve topN of every entity(db, cache) in the minute level.
> >
> >
> > The timeBuc
wu-sheng commented on PR #11788:
URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1991039971
> > So I change topN group key to entityId + timeBucket, then stash map can
only reserve topN of every entity(db, cache) in the minute level.
>
>
>
> The timeBucket at
ZhengBing520 commented on PR #11788:
URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1991036936
> So I change topN group key to entityId + timeBucket, then stash map can
only reserve topN of every entity(db, cache) in the minute level.
The timeBucket attribute in top
wu-sheng merged PR #11788:
URL: https://github.com/apache/skywalking/pull/11788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng commented on code in PR #11788:
URL: https://github.com/apache/skywalking/pull/11788#discussion_r1454813710
##
docs/en/changes/changes.md:
##
@@ -23,6 +23,7 @@
* Fix SumPerMinFunctionTest error function.
* Remove unnecessary annotations and functions from Meter Functi
wu-sheng commented on PR #11788:
URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1894798635
I will check this later today. Thanks for addressing the kernel level issue.
fyi @apache/skywalking-committers This should exist from the beginning.
--
This is an automated
weixiang1862 opened a new pull request, #11788:
URL: https://github.com/apache/skywalking/pull/11788
### Fix topN record calculation
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
- [ ] If th
