hanahmily merged PR #528:
URL: https://github.com/apache/skywalking-banyandb/pull/528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsu
StLeoX commented on PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#issuecomment-2364956536
# Benchmark loop-unrolling
The benchmark code is
[here](https://github.com/StLeoX/skywalking-banyandb/commit/86c6db0a4501688ce09887f38c588ad7317efe86#diff-dc8eb834dc7b7327
StLeoX commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1755947996
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the result
hanahmily commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1754840091
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the res
hanahmily commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1754835427
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the res
wu-sheng commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1754809796
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the resu
wu-sheng commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1754808980
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the resu
hanahmily commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1754776484
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the res
hanahmily commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1754770885
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the res
StLeoX commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1753007600
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the result
wu-sheng commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1753018589
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the resu
wu-sheng commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1752091837
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -54,6 +54,12 @@ type Function[A, B Input, R Output] interface {
// Result gives the resu
hanahmily commented on code in PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#discussion_r1751133276
##
banyand/measure/aggregate/aggregate_function.go:
##
@@ -26,20 +26,20 @@ import (
)
// Void type contains nothing. It works as a placeholder for type
wu-sheng commented on PR #528:
URL:
https://github.com/apache/skywalking-banyandb/pull/528#issuecomment-2330867332
Please rebases the commits to avoid so long commit logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
StLeoX opened a new pull request, #528:
URL: https://github.com/apache/skywalking-banyandb/pull/528
# Add several functions
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [x] Tests(including
15 matches
Mail list logo
