wu-sheng merged PR #11339:
URL: https://github.com/apache/skywalking/pull/11339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377283102
##
test/e2e-v2/cases/pulsar/expected/metrics-has-value-instance-label.yml:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under on
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377249206
##
test/e2e-v2/cases/pulsar/expected/metrics-has-value-instance-label.yml:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under on
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377248602
##
test/e2e-v2/cases/pulsar/expected/metrics-has-value-instance-label.yml:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under on
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377220146
##
test/e2e-v2/cases/pulsar/expected/metrics-has-value-instance-label.yml:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or m
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1786689224
@liangyepianzhou You can't change things blindly. It would only make you
much slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377166964
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -32,12 +32,12 @@ the OAP. In each cluster, the nodes are represented as
`Instance`.
| Bookie L
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377166964
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -32,12 +32,12 @@ the OAP. In each cluster, the nodes are represented as
`Instance`.
| Bookie L
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1377166964
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -32,12 +32,12 @@ the OAP. In each cluster, the nodes are represented as
`Instance`.
| Bookie L
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376959432
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages OpenTelemetry Collector to collec
wankai123 commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1786322163
In the root dashboards, the description text should be on the top, please
check and fix both of 2.
https://github.com/apache/skywalking/assets/16773043/9c73af22-3e87-4dbd-bed9-a4
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376442488
##
docs/menu.yml:
##
@@ -259,12 +259,16 @@ catalog:
path: "/en/setup/backend/backend-elasticsearch-monitoring"
- name: "Mon
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376441574
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/pulsar/pulsar-root.json:
##
@@ -0,0 +1,37 @@
+[
Review Comment:
Fixed.
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376380355
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/bookkeeper/bookkeeper-root.json:
##
@@ -0,0 +1,37 @@
+[
Review Comment:
This root das
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376378240
##
docs/en/setup/backend/backend-pulsar-monitoring.md:
##
@@ -0,0 +1,67 @@
+# Pulsar monitoring
+
+SkyWalking leverages OpenTelemetry Collector to collect metrics
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376378621
##
docs/menu.yml:
##
@@ -259,12 +259,16 @@ catalog:
path: "/en/setup/backend/backend-elasticsearch-monitoring"
- name: "MongoDB"
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376377916
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages OpenTelemetry Collector to collect
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1376377296
##
docs/en/changes/changes.md:
##
@@ -13,6 +13,7 @@
* ElasticSearchClient: Add `deleteById` API.
* Fix Custom alarm rules are overwritten by 'resource/alarm-set
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1785190294
We could try, the deadline is 23:59:59 Oct. 31st, UTC+8. So, there are more
than 24 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message,
liangyepianzhou commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1785129713
@wu-sheng @wankai123 @liuhaoyang All the comments are addressed. Could you
please take a look? We are asked to merge this PR tonight.
--
This is an automated message from t
wankai123 commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784561228
> > @liangyepianzhou Besides discussion around e2e, are all other comments
resolved?
>
> There is still one
[comment](https://github.com/apache/skywalking/pull/11339#discuss
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784560711
> > @liangyepianzhou Besides discussion around e2e, are all other comments
resolved?
>
> There is still one
[comment](https://github.com/apache/skywalking/pull/11339#discussi
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375722762
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/pulsar/pulsar-cluster.json:
##
@@ -0,0 +1,447 @@
+[
+ {
+"id": "Pulsar-Cluster",
+
liangyepianzhou commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784558682
> @liangyepianzhou Besides discussion around e2e, are all other comments
resolved?
There is still one
[comment](https://github.com/apache/skywalking/pull/11339#discuss
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375720453
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages Prometheus to collect metri
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375720321
##
docs/menu.yml:
##
@@ -265,6 +265,10 @@ catalog:
path: "/en/setup/backend/backend-rabbitmq-monitoring"
- name: "Kafka"
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784436846
@liangyepianzhou Besides discussion around e2e, are all other comments
resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
liangyepianzhou commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784317151
> > @wu-sheng @liuhaoyang I think we should give a warning to latecomers:
> >
> > 1. The current tool `compose` in
`[skywalking-infra-e2e](https://github.com/apache/sky
kezhenxu94 commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784308342
> @wu-sheng @liuhaoyang I think we should give a warning to latecomers:
>
> 1. The current tool `compose` in
`[skywalking-infra-e2e](https://github.com/apache/skywalking-i
liuhaoyang commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375556010
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/pulsar/pulsar-cluster.json:
##
@@ -0,0 +1,447 @@
+[
+ {
+"id": "Pulsar-Cluster",
+
liuhaoyang commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375551441
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/bookkeeper/bookkeeper-root.json:
##
@@ -0,0 +1,37 @@
+[
+ {
+"id": "Bookkeeper-Roo
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784264403
> @wu-sheng @liuhaoyang I think we should give a warning to latecomers:
>
> 1. The current tool `compose` in
`[skywalking-infra-e2e](https://github.com/apache/skywalking-inf
liangyepianzhou commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784174844
@wu-sheng @liuhaoyang I think we should give a warning to latecomers:
1. The current tool `compose` in
`[skywalking-infra-e2e](https://github.com/apache/skywalking-infra-
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375474268
##
oap-server/server-starter/src/main/resources/otel-rules/bookkeeper/bookkeeper-cluster.yaml:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Found
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375472291
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/pulsar/pulsar-cluster.json:
##
@@ -0,0 +1,447 @@
+[
+ {
+"id": "Pulsar-Cluste
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375458086
##
oap-server/server-starter/src/main/resources/otel-rules/bookkeeper/bookkeeper-node.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (AS
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375458086
##
oap-server/server-starter/src/main/resources/otel-rules/bookkeeper/bookkeeper-node.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (AS
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375456509
##
oap-server/server-starter/src/main/resources/otel-rules/bookkeeper/bookkeeper-cluster.yaml:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375456161
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages Prometheus to collect metrics dat
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375455276
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages Prometheus to collect metrics dat
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375452372
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages Prometheus to collect metrics data
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375451610
##
docs/en/setup/backend/backend-bookkeeper-monitoring.md:
##
@@ -0,0 +1,61 @@
+# BookKeeper monitoring
+
+SkyWalking leverages Prometheus to collect metrics dat
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375450312
##
test/e2e-v2/cases/pulsar/otel-collector-config.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
wankai123 commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375449772
##
test/e2e-v2/cases/pulsar/docker-compose.yml:
##
@@ -0,0 +1,137 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375445927
##
docs/menu.yml:
##
@@ -265,6 +265,10 @@ catalog:
path: "/en/setup/backend/backend-rabbitmq-monitoring"
- name: "Kafka"
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784127860
@wankai123 Could you another round of review in case of missing anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1375446344
##
docs/en/setup/backend/backend-pulsar-monitoring.md:
##
@@ -0,0 +1,67 @@
+# Pulsar monitoring
+
+SkyWalking leverages Prometheus to collect metrics data from th
liangyepianzhou commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784103903
> Notice, that the OSPP is reaching the deadline. SkyWalking community would
not accept the PR until it is qualified. Only two days left, and I can't be
sure your PR can be m
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1784022927
Notice, that the OSPP is reaching the deadline. SkyWalking community would
not accept the PR until it is qualified.
Only two days left, and I can't be sure your PR can be merged
liangyepianzhou closed pull request #11339: Feature pulsar monitoring
URL: https://github.com/apache/skywalking/pull/11339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
liangyepianzhou closed pull request #11339: Feature pulsar monitoring
URL: https://github.com/apache/skywalking/pull/11339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
liangyepianzhou closed pull request #11339: Feature pulsar monitoring
URL: https://github.com/apache/skywalking/pull/11339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1373185243
##
.github/workflows/skywalking.yaml:
##
@@ -641,6 +641,8 @@ jobs:
config: test/e2e-v2/cases/kafka/kafka-monitoring/e2e.yaml
- name: MQE S
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1373183222
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/bookkeeper/bookkeeper-cluster.json:
##
@@ -0,0 +1,393 @@
+[
+ {
+"id": "Bookkeeper-C
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1373176622
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/template/UITemplateInitializer.java:
##
@@ -42,43 +44,45 @@
*/
@Slf
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1373175823
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/management/ui/template/UITemplateInitializer.java:
##
@@ -42,43 +44,45 @@
*/
@Slf
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1373171854
##
docs/menu.yml:
##
@@ -265,6 +265,10 @@ catalog:
path: "/en/setup/backend/backend-rabbitmq-monitoring"
- name: "Kafka"
liuhaoyang commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1372921057
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rule
liuhaoyang commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1372916452
##
docs/menu.yml:
##
@@ -265,6 +265,9 @@ catalog:
path: "/en/setup/backend/backend-rabbitmq-monitoring"
- name: "Kafka"
wu-sheng commented on PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1778919170
https://github.com/apache/skywalking/assets/5441976/dc2a53d4-44ef-4e56-84e5-bd803f73190d";>
Recommend using `MB` at least to show the size. I think, from today's infra
resourc
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1368677539
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##
@@ -193,7 +193,16 @@ public enum Layer {
/**
* Ka
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1368674556
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##
@@ -193,7 +193,16 @@ public enum Layer {
/**
* Ka
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367828163
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rules
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367827685
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367827685
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367748629
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rules
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367747599
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367746835
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rules
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1350430118
##
test/e2e-v2/cases/pulsar/docker-compose.yml:
##
@@ -122,7 +130,7 @@ services:
command: bash -c "bin/apply-config-from-env.py conf/broker.conf && ex
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1350429095
##
test/e2e-v2/cases/pulsar/docker-compose.yml:
##
@@ -22,8 +22,16 @@ services:
service: oap
ports:
- "12800:12800"
+environment:
+
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1350265053
##
test/e2e-v2/cases/pulsar/docker-compose.yml:
##
@@ -22,8 +22,16 @@ services:
service: oap
ports:
- "12800:12800"
+environment:
+
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1350264145
##
test/e2e-v2/cases/pulsar/docker-compose.yml:
##
@@ -122,7 +130,7 @@ services:
command: bash -c "bin/apply-config-from-env.py conf/broker.conf && exec
bin
72 matches
Mail list logo
