Re: [PR] Fix ServiceInstance `in` query. [skywalking]

2024-02-19 Thread via GitHub
wu-sheng merged PR #11888: URL: https://github.com/apache/skywalking/pull/11888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix ServiceInstance `in` query. [skywalking]

2024-02-18 Thread via GitHub
lujiajing1126 commented on code in PR #11888: URL: https://github.com/apache/skywalking/pull/11888#discussion_r1494109951 ##

Re: [PR] Fix ServiceInstance `in` query. [skywalking]

2024-02-18 Thread via GitHub
wu-sheng commented on code in PR #11888: URL: https://github.com/apache/skywalking/pull/11888#discussion_r1493977078 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java:

Re: [PR] Fix ServiceInstance `in` query. [skywalking]

2024-02-18 Thread via GitHub
weixiang1862 commented on code in PR #11888: URL: https://github.com/apache/skywalking/pull/11888#discussion_r1493976440 ##

Re: [PR] Fix ServiceInstance `in` query. [skywalking]

2024-02-18 Thread via GitHub
wu-sheng commented on code in PR #11888: URL: https://github.com/apache/skywalking/pull/11888#discussion_r1493975107 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java:

[PR] Fix ServiceInstance `in` query. [skywalking]

2024-02-18 Thread via GitHub
weixiang1862 opened a new pull request, #11888: URL: https://github.com/apache/skywalking/pull/11888 ### Fix IMetadataQueryDAO ServiceInstance in query - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it.