Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-08 Thread via GitHub
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1555618861 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-08 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r122505 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-08 Thread via GitHub
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r113183 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-08 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1555418807 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-08 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1555418336 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-07 Thread via GitHub
wu-sheng merged PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554812011 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
kezhenxu94 commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554809846 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554808423 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554808012 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554805833 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554805626 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554801708 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554801593 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554800652 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
kezhenxu94 commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554761804 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
kezhenxu94 commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1554761804 ## deploy/platform/docker/Makefile.in: ## @@ -17,4 +17,4 @@ # .EXPORT_ALL_VARIABLES: -FEATURE_FLAGS ?=

[PR] Fix docker configurations and bump up images [skywalking-showcase]

2024-04-06 Thread via GitHub
CodePrometheus opened a new pull request, #167: URL: https://github.com/apache/skywalking-showcase/pull/167 ### Summary - Fix previous docker configuration mistakes - Update [oap](https://github.com/apache/skywalking/tree/48c96a233103ba869143062923d4033678b91f73) and