Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-23 Thread via GitHub
lujiajing1126 commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1905581882 > @lujiajing1126 You are right, it can't resolve that problem and don't have much to do with each other 😂, but I hope this optimeize can help us to find the cause of the probl

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-23 Thread via GitHub
wongtp commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1905562891 > > > I am confused why this is related to the [apache/skywalking#10991](https://github.com/apache/skywalking/issues/10991)? > > > The linked issue may be caused by version compati

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-21 Thread via GitHub
lujiajing1126 closed pull request #666: Optimize service conflict error message URL: https://github.com/apache/skywalking-java/pull/666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-21 Thread via GitHub
lujiajing1126 commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902872991 > > I am confused why this is related to the [apache/skywalking#10991](https://github.com/apache/skywalking/issues/10991)? > > The linked issue may be caused by version comp

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-20 Thread via GitHub
wu-sheng commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902097231 @lujiajing1126 Could you recheck the new linked issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-20 Thread via GitHub
wongtp commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902095133 > I am confused why this is related to the [apache/skywalking#10991](https://github.com/apache/skywalking/issues/10991)? > > The linked issue may be caused by version compatibi

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-20 Thread via GitHub
wu-sheng commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1902090139 @wongtp The argument is, that the reason of the changes is not clear. If you just want to enhance logs to make the conflicts more readable, I think it is OK to accept. But the i

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-19 Thread via GitHub
wongtp commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1900049498 > I am confused why this is related to the [apache/skywalking#10991](https://github.com/apache/skywalking/issues/10991)? > > The linked issue may be caused by version compatibi

Re: [PR] Optimize service conflict error message [skywalking-java]

2024-01-19 Thread via GitHub
lujiajing1126 commented on PR #666: URL: https://github.com/apache/skywalking-java/pull/666#issuecomment-1900026668 I am confused why this is related to the https://github.com/apache/skywalking/issues/10991? The linked issue may be caused by version compatibility of the Netty plugin.