Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-20 Thread via GitHub
wu-sheng merged PR #11432: URL: https://github.com/apache/skywalking/pull/11432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772093729 The one I was showing above. It wasn't synced, but you are syncing sub module now, so, you need to add this to change log as well. -- This is an automated message from the Apache

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
Z-Beatles commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772088474 > Still missing one. > > https://user-images.githubusercontent.com/5441976/276816603-bfeae130-24d9-4fac-a5e0-8e948e822e96.png;> > Please check from git history

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-19 Thread via GitHub
wu-sheng merged PR #622: URL: https://github.com/apache/skywalking-java/pull/622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772041590 Still missing one. https://github.com/apache/skywalking/assets/5441976/bfeae130-24d9-4fac-a5e0-8e948e822e96;> Please check from git history

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-19 Thread via GitHub
wu-sheng commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1366424517 ## CHANGES.md: ## @@ -15,6 +15,8 @@ Release Notes. * Support report MongoDB instance info in Mongodb 4.x plugin. * To compatible upper and lower case Oracle

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772034152 As you have updated UI, I think there is UI side commit gap too. Please update the UI part change logs accordingly. -- This is an automated message from the Apache Git Service.

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1771910923 Please make the submodule correctly, pointing to the master branch commit ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]

2023-10-19 Thread via GitHub
wu-sheng merged PR #86: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
wu-sheng commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1771910865 Please make the submodule correctly, pointing to the master branch commit ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]

2023-10-19 Thread via GitHub
wu-sheng closed pull request #86: Support collect ZGC memory pool metrics URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
Z-Beatles commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1770699247 ### changes: 1. Add a new widget `JVM Memory Detail (MB)` to show memory pool detail. 2. Support collect and show ZGC memory pool metrics. ### before:

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
wu-sheng commented on code in PR #11432: URL: https://github.com/apache/skywalking/pull/11432#discussion_r1365299551 ## oap-server/server-starter/src/main/resources/oal/java-agent.oal: ## @@ -22,6 +22,17 @@ instance_jvm_memory_heap =

Re: [PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
Z-Beatles commented on PR #11432: URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1770507682 ![image](https://github.com/apache/skywalking/assets/20594866/49911d38-ab37-41d9-aeb9-3176994815a2) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-19 Thread via GitHub
Z-Beatles commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1365260577 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed

Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]

2023-10-19 Thread via GitHub
Z-Beatles commented on PR #86: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86#issuecomment-1770491572 > Provide the JVM doc about these pool types,please. `ZHEAP_USAGE = 6;` ZGC was initially introduced as an experimental feature in JDK 11, and was

[PR] Support collect ZGC memory pool metrics [skywalking]

2023-10-19 Thread via GitHub
Z-Beatles opened a new pull request, #11432: URL: https://github.com/apache/skywalking/pull/11432 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-15 Thread via GitHub
wu-sheng commented on PR #622: URL: https://github.com/apache/skywalking-java/pull/622#issuecomment-1763704381 Thread pool data is meter oriented. https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/meter-analyzer-config/threadpool.yaml

Re: [PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]

2023-10-15 Thread via GitHub
wu-sheng commented on PR #86: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86#issuecomment-1763701571 Provide the JVM doc about these pool types,please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-15 Thread via GitHub
Z-Beatles commented on PR #622: URL: https://github.com/apache/skywalking-java/pull/622#issuecomment-1763685303 > So, this relies on the protocol update. Java 9.1 can't release before OAP 9.7, right? > > And do we expect UI setting change? > So, this relies on the

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-13 Thread via GitHub
wu-sheng commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1357862831 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-13 Thread via GitHub
wu-sheng commented on PR #622: URL: https://github.com/apache/skywalking-java/pull/622#issuecomment-1761028716 So, this relies on the protocol update. Java 9.1 can't release before OAP 9.7, right? And do we expect UI setting change? -- This is an automated message from the

[PR] Support collect ZGC memory pool metrics [skywalking-data-collect-protocol]

2023-10-13 Thread via GitHub
Z-Beatles opened a new pull request, #86: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/86 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-13 Thread via GitHub
Z-Beatles opened a new pull request, #622: URL: https://github.com/apache/skywalking-java/pull/622 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`