Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-19 Thread via GitHub
wu-sheng merged PR #622: URL: https://github.com/apache/skywalking-java/pull/622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-19 Thread via GitHub
wu-sheng commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1366424517 ## CHANGES.md: ## @@ -15,6 +15,8 @@ Release Notes. * Support report MongoDB instance info in Mongodb 4.x plugin. * To compatible upper and lower case Oracle

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-19 Thread via GitHub
Z-Beatles commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1365260577 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-15 Thread via GitHub
wu-sheng commented on PR #622: URL: https://github.com/apache/skywalking-java/pull/622#issuecomment-1763704381 Thread pool data is meter oriented. https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/meter-analyzer-config/threadpool.yaml

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-15 Thread via GitHub
Z-Beatles commented on PR #622: URL: https://github.com/apache/skywalking-java/pull/622#issuecomment-1763685303 > So, this relies on the protocol update. Java 9.1 can't release before OAP 9.7, right? > > And do we expect UI setting change? > So, this relies on the

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-13 Thread via GitHub
wu-sheng commented on code in PR #622: URL: https://github.com/apache/skywalking-java/pull/622#discussion_r1357862831 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/memorypool/ZGCCollectorModule.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-13 Thread via GitHub
wu-sheng commented on PR #622: URL: https://github.com/apache/skywalking-java/pull/622#issuecomment-1761028716 So, this relies on the protocol update. Java 9.1 can't release before OAP 9.7, right? And do we expect UI setting change? -- This is an automated message from the

[PR] Support collect ZGC memory pool metrics [skywalking-java]

2023-10-13 Thread via GitHub
Z-Beatles opened a new pull request, #622: URL: https://github.com/apache/skywalking-java/pull/622 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`