hanahmily merged PR #331:
URL: https://github.com/apache/skywalking-banyandb/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsu
hailin0 commented on PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#issuecomment-1771972416
@hanahmily PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
hailin0 commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365725043
##
docs/installation/cluster.md:
##
@@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the
`banyand-server` automatically
- `node-host-provid
hailin0 commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365724065
##
docs/installation/cluster.md:
##
@@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the
`banyand-server` automatically
- `node-host-provid
hailin0 commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365725432
##
test/integration/etcd/client_test.go:
##
@@ -0,0 +1,304 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agre
hailin0 commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365724556
##
docs/installation/cluster.md:
##
@@ -28,3 +28,45 @@ The host is registered to the etcd cluster by the
`banyand-server` automatically
- `node-host-provid
hanahmily commented on code in PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1365102335
##
.licenserc.yaml:
##
@@ -85,6 +85,7 @@ header: # `header` section is configurations for source codes
license header.
- 'ui'
- '.github/PULL_RE
hailin0 commented on PR #331:
URL:
https://github.com/apache/skywalking-banyandb/pull/331#issuecomment-1768623495
> You should create test cases to ensure the added items are verified. You
can utilize "test/integration/distributed/setup/node_test.go" as a reference
for writing the test
