Re: [PR] Support rocketmq monitoring [skywalking]

2024-03-06 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1982239983 > @peachisai This PR seems missing doc update about `opentelemetry-receiver.md`. Could you open another PR to update the table in the bottom? Ok, I will update it later --

Re: [PR] Support rocketmq monitoring [skywalking]

2024-03-06 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1982208904 @peachisai This PR seems missing doc update about `opentelemetry-receiver.md`. Could you open another PR to update the table in the bottom? -- This is an automated message from

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954159953 > @peachisai Are you working on the showcase or the blog? @wankai123 Should we consider this as a part of showcase? Or the showcase is already too complex? Yes, I have tried

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954131649 OK. But I think we should be careful about whether activate this on the demo.skywalking.a.o. We have a heavy resource requirement of CPU and Memory already. -- This is an

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
wankai123 commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954129406 > Should we consider this as a part of showcase? Or the showcase is already too complex? The rocketMQ monitoring could be added to the `ShowCase` first, this part is not

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-20 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1954072644 @peachisai Are you working on the showcase or the blog? @wankai123 Should we consider this as a part of showcase? Or the showcase is already too complex? -- This is an automated

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-13 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1488825470 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX Review Comment: @peachisai

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482992741 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ server

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482938845 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482802177 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ server

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482800591 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ server

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482573713 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482569335 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482560026 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-08 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r148243 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-07 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482510908 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ server

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-07 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482504168 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-07 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482504168 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-07 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1482491256 ## docs/en/changes/changes.md: ## @@ -45,6 +45,7 @@ - NGINX -> K8S_SERVICE - APISIX -> K8S_SERVICE - GENERAL -> APISIX +* Support Apache RocketMQ server

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-06 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1931030648 > > @wankai123 Hi, I found MQE seems work > > yes, in your case it works, because these expressions are added suffix in

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-06 Thread via GitHub
wankai123 commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1931029395 > @wankai123 Hi, I found MQE seems work yes, in your case it works, because these expressions are added suffix in

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-06 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1930079156 @wankai123 Hi, I found MQE seems work ![A1SAVRILV~ 8L@JNY{ES 4Q](https://github.com/apache/skywalking/assets/96932958/152a703c-9522-49c2-9ed1-f320fe708847) ![FDKE}O

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-06 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1928983967 > What happened? I'm organizing my branches ,just a slip of the thumb... -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-06 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1928975333 What happened? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-05 Thread via GitHub
peachisai closed pull request #11758: Support rocketmq monitoring URL: https://github.com/apache/skywalking/pull/11758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-03 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1925314384 OK, thanks for the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-03 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1925311580 > Is RocketMQ community ready for image? They will release in Feb ,But it would be after the Spring Festival -- This is an automated message from the Apache Git Service.

Re: [PR] Support rocketmq monitoring [skywalking]

2024-02-03 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1925251442 Is RocketMQ community ready for image? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-29 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1916051140 OK, I will be on vacation from tomorrow, so I will be off line for most of time. @wankai123 will review this later when you are ready. -- This is an automated message from the

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-29 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1916049145 > @duhenglucky Is there an estimated release date? I got the reply from the ```rocketmq``` community they will release it after addressing a little problem -- This is an

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-29 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1915871508 @duhenglucky Is there an estimated release date? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-27 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1913401990 OK. We are still waiting for RocketMQ exporter released. It seems not that quick. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-27 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1468698482 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1464293445 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/rocketmq/rocketmq-topic.json: ## @@ -0,0 +1,299 @@ +[ + { +"id": "RocketMQ-Topic",

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1464293445 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/rocketmq/rocketmq-topic.json: ## @@ -0,0 +1,299 @@ +[ + { +"id": "RocketMQ-Topic",

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1907355234 > > Should I restore to `Time series` ? > > Oops, sorry. you are right, then should restore both expression and typesOfMQE for this Widget. > > Should I

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
wankai123 commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1907309182 > Should I restore to `Time series` ? Oops, sorry. you are right, then should restore both expression and type. -- This is an automated message from the Apache Git

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1907305115 > > > The Card Widget requires SINGLE_VALUE. Please check others UI templates. > > > > > > May I ask a question? Why should meter_rocketmq_topic_consumer_latency be as

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1907299245 > > The Card Widget requires SINGLE_VALUE. Please check others UI templates. > > May I ask a question? Why should meter_rocketmq_topic_consumer_latency be as a single value

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-23 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1907297905 > The Card Widget requires SINGLE_VALUE. Please check others UI templates. May I ask a question? Why should meter_rocketmq_topic_consumer_latency be as a single value even

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462830222 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462794539 ## docs/en/setup/backend/backend-rocketmq-monitoring.md: ## @@ -0,0 +1,73 @@ +# RocketMQ monitoring + +SkyWalking leverages rocketmq-exporter for collecting

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905387750 > The Card Widget requires SINGLE_VALUE. Please check others UI templates. Done -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462720475 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462696699 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462696138 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462694049 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462691943 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462691424 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462690607 ## docs/en/setup/backend/backend-rocketmq-monitoring.md: ## @@ -0,0 +1,73 @@ +# RocketMQ monitoring + +SkyWalking leverages rocketmq-exporter for collecting

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1462676347 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/rocketmq/rocketmq-topic.json: ## @@ -0,0 +1,299 @@ +[ + { +"id": "RocketMQ-Topic",

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905223095 > Do we need a doc update to refer to new RocketMQ release? No, the personal repo was only used in the e2e. The docs do not mention the repo. -- This is an automated

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905214458 Do we need a doc update to refer to new RocketMQ release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-22 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1905205135 > FYI, RocketMQ upstream is working on the release. > > Thread, https://lists.apache.org/thread/wp8nl4tmd3t15dlc8jb7kq07z1cv4qh0 The official image has been pulished,

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-17 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1896141234 FYI, RocketMQ upstream is working on the release. Thread, https://lists.apache.org/thread/wp8nl4tmd3t15dlc8jb7kq07z1cv4qh0 -- This is an automated message from the Apache

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-14 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1452013152 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-14 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1452009450 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-14 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1451972321 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-14 Thread via GitHub
duhenglucky commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1451966416 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1450001472 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449995284 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449989174 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449988638 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449980266 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449978564 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449971179 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449967349 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449967349 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449950598 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449949020 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449925494 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r144992 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r144992 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wankai123 commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1449888084 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1888499932 > According to the latest requirement of the community about feature change, you should submit another pull request to finish the [SWIP

Re: [PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1888447012 According to the latest requirement of the community about feature change, you should submit another pull request to finish the [SWIP

[PR] Support rocketmq monitoring [skywalking]

2024-01-11 Thread via GitHub
peachisai opened a new pull request, #11758: URL: https://github.com/apache/skywalking/pull/11758 - [x] Update the documentation to include this new feature. - [x] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] If it's UI related,