cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2275406032
should be , not only activemq needs to do this, other mq queues need create
context snapshot ， looking forward to your code changes
--
This is an automated message from the Apach
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2275394388
> the final effect is as follows:
activemq-consumer entry was stop when over dequeue met
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2273850508
I don't think that, the demo projcet will create a new entry span link
through ActiveMQ producer span, this repeats with ActiveMQ consumer.
The process of use spring JMS & third
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-227557
> > i write demo project
>
> >
>
> > https://github.com/cloudgc/apm-spring-jms
>
> >
>
> > already applied to actual company projects
>
> >
>
cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2273328710
There is indeed a problem
This is the call graph. I will think of a friendly way to fi
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2273134042
> i write demo project
>
> https://github.com/cloudgc/apm-spring-jms
>
> already applied to actual company projects
>
> If you need it urgently, you can fork from i
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2273120763
> Close for now. Discussion could continue. If either of you wants to add
the new one, send a new pull request.
Agree, thank you for your guidance. @wu-sheng
--
This is an a
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2272671190
Close for now. Discussion could continue.
If either of you wants to add the new one, send a new pull request.
--
This is an automated message from the Apache Git Service.
To re
wu-sheng closed pull request #706: Support tracking the message listener of
spring jms
URL: https://github.com/apache/skywalking-java/pull/706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2272439728
i write demo project
https://github.com/cloudgc/apm-spring-jms
already applied to actual company projects
If you need it urgently, you can fork from it, I will c
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2271734231
> No, Java agent nowadays is totally relying on volunteers. I don't touch on
codes, especially plugins, for years.
Yes, i know :)
I asked @cloudgc
--
This is an autom
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2271717429
No, Java agent nowadays is totally relying on volunteers.
I don't touch on codes, especially plugins, for years.
--
This is an automated message from the Apache Git Service.
To
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2271624532
> should create plugin project spring-jms-activemq-5.x-plugin
spring-jms-rabbitmq-5.x-plugin like this
Thank you for your recommend.
But i have no idea about this, d
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2271183033
Agree for that. Feel free to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2270974890
should create plugin project spring-jms-activemq-5.x-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2270870970
I have studied the support of several major mqs for jms and how to integrate
them. I
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2270419100
I think active MQ should be updated to put correct tag value in JMS case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2270319092
Can only be used by hard coding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
cloudgc commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2270318700
The jms connectionFactory is very troublesome to obtain the MQ_BROKER Tag
--
This is a
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269419110
If that could make the trace continues as your expectations, then yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269278976
> But it is pointless when you have another header extracring from entry
span from the actual entry span.
>
> Local span doesn't need reference of the producer.
Yes, afte
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269261958
But it is pointless when you have another header extracring from entry span
from the actual entry span.
Local span doesn't need reference of the producer.
--
This is an au
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269257417
> I am waiting for your reply about why do header extra when you only create
local span. This is rare from my understanding.
I hope to trace specific execute of the active MQ co
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269229713
I am waiting for your reply about why do header extra when you only create
local span. This is rare from my understanding.
--
This is an automated message from the Apache Git Ser
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269229164
> What happened here?
I removed the context carrier and replaced it with context snapshot. Is that
right?
--
This is an automated message from the Apache Git Service.
To resp
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269220528
> What happened here?
I thought you didn't need this plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2269186941
What happened here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
hyhyf closed pull request #706: Support tracking the message listener of spring
jms
URL: https://github.com/apache/skywalking-java/pull/706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697906083
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697891559
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
cloudgc commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697856531
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
@
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1697016810
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696921595
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or m
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696913705
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -71,20 +71,15 @@ segmentItems:
skipAnalysis: 'false'
- segme
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696667248
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# o
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696649521
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or m
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1696118405
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# o
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694225573
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or m
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694221556
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# o
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694218031
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215993
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215993
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215993
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
+/*
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694215765
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or m
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694211373
##
test/plugin/scenarios/spring-jms-5.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/spring/jms/controller/CaseController.java:
##
@@ -0,0 +1,61 @@
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694211083
##
test/plugin/scenarios/spring-jms-5.x-scenario/config/expectedData.yaml:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# o
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694210855
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694210780
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/MessageListenerInterceptor.java:
##
hyhyf commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694205125
##
apm-sniffer/apm-agent-core/pom.xml:
##
@@ -22,7 +22,7 @@
org.apache.skywalking
java-agent-sniffer
-9.4.0-SNAPSHOT
+9.3.0-
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1694200342
##
apm-sniffer/apm-agent-core/pom.xml:
##
@@ -22,7 +22,7 @@
org.apache.skywalking
java-agent-sniffer
-9.4.0-SNAPSHOT
+9.3
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2254401761
Please resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2249691304
Any update? I am planning to cut the 9.3.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2241468577
Take your time. We should cover all 5.x versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2241467495
> My question is about why. We should be clear about supported versions. 5.x
should cover 5.0.
>
> Could you check the codes and explain why?
The plugin can support 5.0,
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2241463509
My question is about why. We should be clear about supported versions.
5.x should cover 5.0.
Could you check the codes and explain why?
--
This is an automated message f
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2241462558
> Why did you remove 5.0?
5.0 spring version too low lead to test scenarios failed
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2241457044
Why did you removr 5.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wu-sheng commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2241057458
Your test scenarios failed. Please test them locally, make sure they are
passed and stable.
--
This is an automated message from the Apache Git Service.
To respond to the message
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1684694860
##
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-jms-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/jms/define/MessageListenerInstrumentation.java:
wu-sheng commented on code in PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#discussion_r1684411569
##
test/plugin/scenarios/spring-jms-5.x-scenario/support-version.list:
##
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mo
hyhyf commented on PR #706:
URL: https://github.com/apache/skywalking-java/pull/706#issuecomment-2238781003
I recommited the code and successfully passed the github action job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
hyhyf opened a new pull request, #706:
URL: https://github.com/apache/skywalking-java/pull/706
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.c
hyhyf closed pull request #705: Support tracking the message listener of spring
jms
URL: https://github.com/apache/skywalking-java/pull/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
wu-sheng commented on PR #705:
URL: https://github.com/apache/skywalking-java/pull/705#issuecomment-2236400697
Login to dockerhub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
wu-sheng commented on PR #705:
URL: https://github.com/apache/skywalking-java/pull/705#issuecomment-2236399504
You seems not to read logs?
docker login': denied: requested access to the resource is denied
--
This is an automated message from the Apache Git Service.
To respond to the
hyhyf commented on PR #705:
URL: https://github.com/apache/skywalking-java/pull/705#issuecomment-2236330953
docker-compose.yml
version: '2.1'
networks:
default:
name: spring-jms-5.x-scenario-1.0.0
services:
spri
hyhyf commented on PR #705:
URL: https://github.com/apache/skywalking-java/pull/705#issuecomment-2236327978
+ java -jar -Xmx256m -Xms256m
-Dconfigure.file=/d/project/skywalking-java/test/plugin/scenarios/spring-jms-5.x-scenario/configuration.yml
-Dscenario.home=/d/project/skywalking-java/t
hyhyf commented on PR #705:
URL: https://github.com/apache/skywalking-java/pull/705#issuecomment-2236327657
> Please follow plugin test doc to add test scenarios.
>
>
https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/
I cann
wu-sheng commented on PR #705:
URL: https://github.com/apache/skywalking-java/pull/705#issuecomment-226700
Please follow plugin test doc to add test scenarios.
https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/
--
This is an
hyhyf opened a new pull request, #705:
URL: https://github.com/apache/skywalking-java/pull/705
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
log](https://github.c
71 matches
Mail list logo
