Re: [PR] Use append rather than replace policy for JAVA_TOOL_OPTIONS [skywalking-swck]

2023-11-21 Thread via GitHub
wu-sheng merged PR #95: URL: https://github.com/apache/skywalking-swck/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] Use append rather than replace policy for JAVA_TOOL_OPTIONS [skywalking-swck]

2023-11-21 Thread via GitHub
dashanji commented on PR #95: URL: https://github.com/apache/skywalking-swck/pull/95#issuecomment-1820455628 > When there is already `JAVA_TOOL_OPTIONS`. The current design is to configure the agent via env rather than `JAVA_TOOL_OPTIONS`. @Duncan-tree-zhou What do you think?

Re: [PR] Use append rather than replace policy for JAVA_TOOL_OPTIONS [skywalking-swck]

2023-11-20 Thread via GitHub
wu-sheng commented on PR #95: URL: https://github.com/apache/skywalking-swck/pull/95#issuecomment-1820163668 @robberphex I can't see new commits submitted. What do you mean `updated`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G