Re: [PR] feat: support setting a discard type of reporter [skywalking-go]

2023-10-23 Thread via GitHub
mrproliu merged PR #134: URL: https://github.com/apache/skywalking-go/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] feat: support setting a discard type of reporter [skywalking-go]

2023-10-23 Thread via GitHub
LinuxSuRen commented on PR #134: URL: https://github.com/apache/skywalking-go/pull/134#issuecomment-1776406572 There are two important reason. * Considering SkyWalking is not a MUST component all the time. I don't expect that it prints error logs when no SkyWalking installed. * Mai

Re: [PR] feat: support setting a discard type of reporter [skywalking-go]

2023-10-23 Thread via GitHub
mrproliu commented on PR #134: URL: https://github.com/apache/skywalking-go/pull/134#issuecomment-1776400058 Can you provide more scenarios to illustrate when users need to use it? If they don't need to collect data and can perform operations during compilation, it will result in better per

Re: [PR] feat: support setting a discard type of reporter [skywalking-go]

2023-10-23 Thread via GitHub
LinuxSuRen commented on code in PR #134: URL: https://github.com/apache/skywalking-go/pull/134#discussion_r1369470116 ## tools/go-agent/Makefile: ## @@ -51,4 +51,4 @@ build: linux darwin windows .PHONY: $(PLATFORMS) $(PLATFORMS): mkdir -p $(OUT_DIR) - GOOS=$(os)

[PR] feat: support setting a discard type of reporter [skywalking-go]

2023-10-23 Thread via GitHub
LinuxSuRen opened a new pull request, #134: URL: https://github.com/apache/skywalking-go/pull/134 As mentioned in the title, users could discard the report data via environment variable setting. -- This is an automated message from the Apache Git Service. To respond to the message, please