Re: [PR] feature: add support for fiber [skywalking-go]

2023-10-29 Thread via GitHub
CodePrometheus commented on PR #133: URL: https://github.com/apache/skywalking-go/pull/133#issuecomment-1784097276 > ID is registered. Note, we may need another PR on the UI side to represent the server on the topology. @wu-sheng Teacher Wu, could you please explain in detail what els

Re: [PR] feature: add support for fiber [skywalking-go]

2023-10-29 Thread via GitHub
CodePrometheus commented on code in PR #133: URL: https://github.com/apache/skywalking-go/pull/133#discussion_r1375430264 ## go.sum: ## @@ -2,23 +2,14 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT cloud.google.com/go v0.34.0/go.mod h1:aQU

Re: [PR] feature: add support for fiber [skywalking-go]

2023-10-28 Thread via GitHub
mrproliu merged PR #133: URL: https://github.com/apache/skywalking-go/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] feature: add support for fiber [skywalking-go]

2023-10-27 Thread via GitHub
wu-sheng commented on code in PR #133: URL: https://github.com/apache/skywalking-go/pull/133#discussion_r1375155546 ## go.sum: ## @@ -2,23 +2,14 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVs

Re: [PR] feature: add support for fiber [skywalking-go]

2023-10-23 Thread via GitHub
mrproliu commented on PR #133: URL: https://github.com/apache/skywalking-go/pull/133#issuecomment-1776314788 @CodePrometheus Thanks for your contribution. The CI has been failure, please fix it first. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] feature: add support for fiber [skywalking-go]

2023-10-23 Thread via GitHub
wu-sheng commented on PR #133: URL: https://github.com/apache/skywalking-go/pull/133#issuecomment-1776274205 ID is registered. Note, we may need another PR on the UI side to represent the server on the topology. -- This is an automated message from the Apache Git Service. To respond to t

[PR] feature: add support for fiber [skywalking-go]

2023-10-23 Thread via GitHub
CodePrometheus opened a new pull request, #133: URL: https://github.com/apache/skywalking-go/pull/133 [Filber](https://github.com/gofiber/fiber) is a HTTP web framework. I would appreciate it if the members of the community wouldn't mind taking a look at my code and providing some fee