Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-17 Thread via GitHub
wu-sheng merged PR #176: URL: https://github.com/apache/skywalking-go/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on PR #176: URL: https://github.com/apache/skywalking-go/pull/176#issuecomment-2002317690 ~~~ dependency failed to start: container gin-service-1 exited (127) WORK=/tmp/go-build4103001024 # text/template/parse runtime: newstack sp=0xc4ff90 stack=[0xc0

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527412549 ## test/plugins/scenarios/segmentio-kafka/config/excepted.yml: ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
mrproliu commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527411102 ## test/plugins/scenarios/segmentio-kafka/config/excepted.yml: ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on PR #176: URL: https://github.com/apache/skywalking-go/pull/176#issuecomment-2002244018 Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527389921 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// li

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
wu-sheng commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527375299 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527204555 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// li

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
wu-sheng commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527186424 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527182911 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// li

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527182911 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// li

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on PR #176: URL: https://github.com/apache/skywalking-go/pull/176#issuecomment-2002006843 ~~~ ALLOW_PLAINTEXT_LISTENER: yes services.kafka-server.environment.ALLOW_PLAINTEXT_LISTENER contains true, which is an invalid type, it should be a string, number, or

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
mrproliu commented on code in PR #176: URL: https://github.com/apache/skywalking-go/pull/176#discussion_r1527180335 ## test/plugins/scenarios/segmentio-kafka/main.go: ## @@ -0,0 +1,149 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
Superskyyy commented on PR #176: URL: https://github.com/apache/skywalking-go/pull/176#issuecomment-2001989274 Please fix lint and stuff, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus commented on PR #176: URL: https://github.com/apache/skywalking-go/pull/176#issuecomment-2001984783 Ref https://github.com/apache/skywalking/pull/12027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] feature: add support for segmentio-kafka [skywalking-go]

2024-03-16 Thread via GitHub
CodePrometheus opened a new pull request, #176: URL: https://github.com/apache/skywalking-go/pull/176 ### Summary [segmentio-kafka](https://github.com/segmentio/kafka-go) is a lightweight Kafka library in Go. - [x] Update the docs. - [x] Pass CI test. - [x] Pass Plugin te