Re: [PR] fix: remove click event after unmounted [skywalking-booster-ui]

2024-02-21 Thread via GitHub
Fine0830 merged PR #372: URL: https://github.com/apache/skywalking-booster-ui/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: remove click event after unmounted [skywalking-booster-ui]

2024-02-21 Thread via GitHub
wu-sheng commented on PR #372: URL: https://github.com/apache/skywalking-booster-ui/pull/372#issuecomment-1956086982 @Fine0830 Please take a look. This is too detailed about the UI codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] fix: remove click event after unmounted [skywalking-booster-ui]

2024-02-20 Thread via GitHub
zhourunjie1988 opened a new pull request, #372: URL: https://github.com/apache/skywalking-booster-ui/pull/372 The _handleClick_ function calls the _stopPropagation_, so we'd better remove the click events after component unmounted to prevent potential problems, such as adding click events