This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git
The following commit(s) were added to refs/heads/master by this push: new e98c882 build: Separate production and development environments when building (#59) e98c882 is described below commit e98c882f55b72acf583f3080cc81166a723dd94f Author: Juntao Zhang <719284...@qq.com> AuthorDate: Tue Jun 8 01:47:49 2021 -0500 build: Separate production and development environments when building (#59) * mode * fix: package-lock.json --- package-lock.json | 9 +++++++++ package.json | 5 +++-- webpack.config.js | 12 +++++++++--- 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 237587d..107540a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1267,6 +1267,15 @@ "yaml": "^1.10.0" } }, + "cross-env": { + "version": "7.0.3", + "resolved": "https://registry.npmjs.org/cross-env/-/cross-env-7.0.3.tgz", + "integrity": "sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==", + "dev": true, + "requires": { + "cross-spawn": "^7.0.1" + } + }, "cross-spawn": { "version": "7.0.3", "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz", diff --git a/package.json b/package.json index 65ba0d4..e4ddb62 100644 --- a/package.json +++ b/package.json @@ -12,6 +12,7 @@ "email": "d...@skywalking.apache.org" }, "devDependencies": { + "cross-env": "^7.0.3", "express": "^4.17.1", "husky": "^4.3.0", "lint-staged": "^10.3.0", @@ -27,8 +28,8 @@ "webpack-dev-server": "^3.11.2" }, "scripts": { - "build": "webpack", - "rebuild": "rm -rf ./node_modules && rm -rf ./lib && npm install && webpack", + "build": "cross-env NODE_ENV=production webpack", + "rebuild": "rm -rf ./node_modules && rm -rf ./lib && npm install && npm run build", "start": "webpack-dev-server", "server": "node server.js", "release": "make release-src" diff --git a/webpack.config.js b/webpack.config.js index bbc0da9..8cb0a77 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -18,10 +18,10 @@ const path = require('path'); const webpack = require('webpack'); const WebpackConcatPlugin = require('webpack-concat-files-plugin'); -module.exports = { +const isDev = process.env.NODE_ENV !== 'production'; +const config = { entry: './src/index.ts', devtool: 'inline-source-map', - mode: 'development', module: { rules: [ { @@ -41,7 +41,6 @@ module.exports = { publicPath: '/', }, plugins: [ - new webpack.HotModuleReplacementPlugin(), new WebpackConcatPlugin({ bundles: [ { @@ -59,3 +58,10 @@ module.exports = { moduleIds: 'named', }, }; +if (isDev) { + config.mode = 'development'; + config.plugins.unshift(new webpack.HotModuleReplacementPlugin()); +} else { + config.mode = 'production'; +} +module.exports = config;