bilalaayush commented on issue #8092: Write custom backend logic for
visualizing superset graphs
URL:
https://github.com/apache/incubator-superset/issues/8092#issuecomment-526806163
@uchihaabhijit I would suggest pre-aggregate your data, using your custom
Python logic, into a materialize
villebro commented on issue #8077: Fixed Histogram visualization bug.
URL:
https://github.com/apache/incubator-superset/pull/8077#issuecomment-526805659
Note: while this was later reverted in master after `superset-ui*` was
bumped to `0.12`, this fix is needed in `0.34` which is still on
villebro commented on issue #8139: [sqllab] add retries for stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#issuecomment-526800083
@serenajiang this needs rebasing.
This is an automated message from the
villebro commented on a change in pull request #8150: add-hana
URL:
https://github.com/apache/incubator-superset/pull/8150#discussion_r319710949
##
File path: superset/db_engine_specs/hana.py
##
@@ -0,0 +1,59 @@
+from superset.db_engine_specs.base import LimitMethod
+from
villebro commented on a change in pull request #8150: add-hana
URL:
https://github.com/apache/incubator-superset/pull/8150#discussion_r319710756
##
File path: superset/db_engine_specs/hana.py
##
@@ -0,0 +1,59 @@
+from superset.db_engine_specs.base import LimitMethod
+from
villebro commented on a change in pull request #8150: add-hana
URL:
https://github.com/apache/incubator-superset/pull/8150#discussion_r319710874
##
File path: superset/db_engine_specs/hana.py
##
@@ -0,0 +1,59 @@
+from superset.db_engine_specs.base import LimitMethod
+from
villebro commented on a change in pull request #8150: add-hana
URL:
https://github.com/apache/incubator-superset/pull/8150#discussion_r319710915
##
File path: superset/db_engine_specs/hana.py
##
@@ -0,0 +1,59 @@
+from superset.db_engine_specs.base import LimitMethod
+from
villebro commented on a change in pull request #8150: add-hana
URL:
https://github.com/apache/incubator-superset/pull/8150#discussion_r319710949
##
File path: superset/db_engine_specs/hana.py
##
@@ -0,0 +1,59 @@
+from superset.db_engine_specs.base import LimitMethod
+from
villebro commented on a change in pull request #8150: add-hana
URL:
https://github.com/apache/incubator-superset/pull/8150#discussion_r319710836
##
File path: superset/db_engine_specs/hana.py
##
@@ -0,0 +1,59 @@
+from superset.db_engine_specs.base import LimitMethod
+from
axuew opened a new pull request #8150: add-hana
URL: https://github.com/apache/incubator-superset/pull/8150
Support hana Time Grain
链接hana安装库文件：sqlalchemy-hana and hdbcli
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [
graceguo-supercat commented on issue #8060: SIP-23: Persist SQL Lab state in
the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526780494
@betodealmeida thanks for the work. correction: I can see all the query tabs
work correct, the missing ones are item
codecov-io commented on issue #8149: chore: remove PY3 conditional logic
URL:
https://github.com/apache/incubator-superset/pull/8149#issuecomment-526777689
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8149?src=pr&el=h1)
Report
> Merging
[#8149](https://codecov.io/g
khtruong commented on issue #8148: Adding explicit include for version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526776455
How should we deal with tests? There is a comment in config.py that states
that it falls back to "package.json" to get the ver
stale[bot] commented on issue #7808: handle SQL injection in the custom where
clause for superset visualization queries
URL:
https://github.com/apache/incubator-superset/pull/7808#issuecomment-526775947
This issue has been automatically marked as stale because it has not had
recent activi
mistercrunch opened a new pull request #8149: chore: remove PY3 conditional
logic
URL: https://github.com/apache/incubator-superset/pull/8149
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Bui
mistercrunch commented on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526772038
I think more generally we may need to restructure the JS `src/`-related
folders and static folders independently. Images
mistercrunch commented on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526771125
Ooops, just realized I merged without reading the new comments, my GH had
not refreshed the page or something and updates
mistercrunch merged pull request #8148: Adding explicit include for
version_info.json
URL: https://github.com/apache/incubator-superset/pull/8148
This is an automated message from the Apache Git Service.
To respond to the me
khtruong commented on issue #8148: Adding explicit include for version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526768982
I am a little confused. Should we or should we not have the exception block?
-
DiggidyDave commented on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526768551
Right, I'm just pointing out that the try/except block falls back to a
condition that will _always_ cause a secondary exce
graceguo-supercat merged pull request #8147: Revert "Fix tooltips not visible
for NVD3 charts on Firefox (#7822)"
URL: https://github.com/apache/incubator-superset/pull/8147
This is an automated message from the Apache Git S
graceguo-supercat edited a comment on issue #7822: Line chart tooltips broken
on Firefox
URL:
https://github.com/apache/incubator-superset/issues/7822#issuecomment-526754662
@CoryChaplin This PR caused an issue: the standalone mode chart didn't show
anymore. please see #8147 for details.
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526767134
> hi @betodealmeida I have one concern for this PR: once this feature is
released to production, the existed sql lab user
craig-rueda commented on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526766812
Yep, so it actually depends on the tests that are being run -
**JS tests** will require `package.json`, however they
graceguo-supercat merged pull request #8146: Revert "Allow resizing width of
SQL Lab left bar / editor"
URL: https://github.com/apache/incubator-superset/pull/8146
This is an automated message from the Apache Git Service.
To
DiggidyDave commented on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526765212
Correct, that's my read also... the `package.json` fallback will never be
found if it is not also whitelisted.
--
khtruong edited a comment on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526764240
Do we also need an explicit include for the package.json file? If we are
trying to run tests and version_info.json is
khtruong edited a comment on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526764240
Do we also need an explicit include for the package.json file? If we are
trying to run tests, then we and version_info
khtruong commented on issue #8148: Adding explicit include for version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526764240
Do we also need an explicit include for the package.json file? We are seeing
issues in our environment where that is missing a
graceguo-supercat commented on issue #8060: SIP-23: Persist SQL Lab state in
the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526758742
hi @betodealmeida I have one concern for this PR: once this feature is
released to production, the existed sql lab us
codecov-io commented on issue #8148: Adding explicit include for
version_info.json
URL:
https://github.com/apache/incubator-superset/pull/8148#issuecomment-526757333
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8148?src=pr&el=h1)
Report
> Merging
[#8148](https://c
graceguo-supercat commented on issue #7822: Line chart tooltips broken on
Firefox
URL:
https://github.com/apache/incubator-superset/issues/7822#issuecomment-526754662
@CoryChaplin This PR caused an issue: the standalone mode chart didn't show
anymore. please see #7929 for details. We have
craig-rueda opened a new pull request #8148: Adding explicit include for
version_info.json
URL: https://github.com/apache/incubator-superset/pull/8148
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
graceguo-supercat merged pull request #8145: Revert "Fixed Histogram
visualization bug. "
URL: https://github.com/apache/incubator-superset/pull/8145
This is an automated message from the Apache Git Service.
To respond to th
MarcusSorealheis commented on issue #8033: fixed the bleeding dashboard chart
issue
URL:
https://github.com/apache/incubator-superset/pull/8033#issuecomment-526744288
Is the decision here to decouple external charts from the main superset
application?
---
codecov-io commented on issue #8145: Revert "Fixed Histogram visualization bug.
"
URL:
https://github.com/apache/incubator-superset/pull/8145#issuecomment-526723163
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8145?src=pr&el=h1)
Report
> Merging
[#8145](https://co
etr2460 opened a new pull request #8147: Revert "Fix tooltips not visible for
NVD3 charts on Firefox (#7822)"
URL: https://github.com/apache/incubator-superset/pull/8147
Reverts apache/incubator-superset#7929
This broke embedded charts. I tested by creating an `index.html` file with
etr2460 opened a new pull request #8146: Revert "Allow resizing width of SQL
Lab left bar / editor"
URL: https://github.com/apache/incubator-superset/pull/8146
Reverts apache/incubator-superset#8099
This PR broke the SQL Lab query editor when the query is longer than can fit
in the
villebro commented on issue #8145: Revert "Fixed Histogram visualization bug. "
URL:
https://github.com/apache/incubator-superset/pull/8145#issuecomment-526719658
IIRC, prior to merging I checked that `all_columns_x` behaved similarly in
other viz's, so the change in API might have wider i
stale[bot] closed issue #7768: TableSelector handle error tests do not run
correctly
URL: https://github.com/apache/incubator-superset/issues/7768
This is an automated message from the Apache Git Service.
To respond to the m
etr2460 commented on issue #8145: Revert "Fixed Histogram visualization bug. "
URL:
https://github.com/apache/incubator-superset/pull/8145#issuecomment-526717294
Actually, I don't think #8115 fixed the bug, but instead just updated some
of the API around superset-ui/chart. We probably shou
etr2460 commented on issue #8145: Revert "Fixed Histogram visualization bug. "
URL:
https://github.com/apache/incubator-superset/pull/8145#issuecomment-526716197
Perhaps. I think reverting this is the right call though as it unbreaks
master
villebro commented on issue #8145: Revert "Fixed Histogram visualization bug. "
URL:
https://github.com/apache/incubator-superset/pull/8145#issuecomment-526715343
Hmm, it seems #8077 addressed a bug in
`"@superset-ui/legacy-plugin-chart-histogram": "^0.10.11"` that was fixed by
#8115 whic
etr2460 opened a new pull request #8145: Revert "Fixed Histogram visualization
bug. "
URL: https://github.com/apache/incubator-superset/pull/8145
Reverts apache/incubator-superset#8077
This change introduced a new bug for many more histograms:
```
Traceback (most recent call la
villebro commented on issue #7991: can't add clickhouse database (allways
connecting as default user)
URL:
https://github.com/apache/incubator-superset/issues/7991#issuecomment-526708352
The problem with saving a database seems to be in `clickhouse-sqlalchemy`.
Please see the following ti
graceguo-supercat commented on issue #8139: [sqllab] add retries for stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#issuecomment-526688161
This PR is trying to fix the errors like this:
> This Session's transaction has been rolled back due to a previous
excep
codecov-io edited a comment on issue #7611: [sqllab] Cancel database query on
stop
URL:
https://github.com/apache/incubator-superset/pull/7611#issuecomment-497071895
#
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7611?src=pr&el=h1)
Report
> Merging
[#7611](https://c
smacker commented on issue #7611: [sqllab] Cancel database query on stop
URL:
https://github.com/apache/incubator-superset/pull/7611#issuecomment-526660391
@mistercrunch I updated the code. It's simpler and more flexible now.
villebro commented on issue #7991: can't add clickhouse database (allways
connecting as default user)
URL:
https://github.com/apache/incubator-superset/issues/7991#issuecomment-526618182
I was able to reproduce the `Could not locate column in row for column
'name'` error - will investigat
malazbw commented on issue #952: Document that mapbox visualization requires
MAPBOX_API_KEY
URL:
https://github.com/apache/incubator-superset/issues/952#issuecomment-526585940
Hi, is it possible to make it without api token
---
ognemuh commented on issue #7991: can't add clickhouse database (allways
connecting as default user)
URL:
https://github.com/apache/incubator-superset/issues/7991#issuecomment-526577122
We've tried this on version 0.34 (python/alchemy are the same) - still
doesn't work.
-
smacker commented on issue #7611: [sqllab] Cancel database query on stop
URL:
https://github.com/apache/incubator-superset/pull/7611#issuecomment-526557631
Cool. Thank you. I'll re-work this PR in the following days to avoid DB
migration and make it more flexible.
smacker commented on issue #8139: [sqllab] add retries for stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#issuecomment-526556144
@villebro nope. This change handles errors on superset side (main DB with
superset's state). While #7611 interacts with data source conne
squalou commented on issue #7406: Pivot table null values in columns
URL:
https://github.com/apache/incubator-superset/issues/7406#issuecomment-526537542
I have a workaround : I added `"fill_values=0,`" parameter in viz.py (in the
get_data function of ivotTable class).
So ideally, t
stale[bot] commented on issue #7802: Cannot import dashboard with Druid
datasources
URL:
https://github.com/apache/incubator-superset/issues/7802#issuecomment-526516709
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no furthe
mashciku opened a new issue #8144: Pivot Table Filter
URL: https://github.com/apache/incubator-superset/issues/8144
## [SIP] Proposal for Filtering Pivot table columns with categorical
variables.
### Motivation
Description of the problem to be solved.
I have a pivot tab
issue-label-bot[bot] commented on issue #8144: Pivot Table Filter
URL:
https://github.com/apache/incubator-superset/issues/8144#issuecomment-526515913
Issue-Label Bot is automatically applying the label `#enhancement` to this
issue, with a confidence of 0.74. Please mark this comment with
57 matches
Mail list logo
