john-bodley commented on code in PR #20729:
URL: https://github.com/apache/superset/pull/20729#discussion_r922628584
##
tests/integration_tests/db_engine_specs/presto_tests.py:
##
@@ -892,19 +892,6 @@ def test_get_create_view_exception(self):
)
schema = "schema
mkhudia commented on issue #10149:
URL: https://github.com/apache/superset/issues/10149#issuecomment-1186079012
@craig-rueda thanks for the swift reply. sharing the steps I am trying on my
machine.
- docker pull apache/superset:latest
- docker run -it -p 8088:8088 --name oli-super
john-bodley commented on code in PR #20729:
URL: https://github.com/apache/superset/pull/20729#discussion_r922618432
##
superset/db_engine_specs/presto.py:
##
@@ -906,21 +906,23 @@ def extra_table_metadata(
indexes = database.get_indexes(table_name, schema_name)
john-bodley commented on code in PR #20729:
URL: https://github.com/apache/superset/pull/20729#discussion_r922618432
##
superset/db_engine_specs/presto.py:
##
@@ -906,21 +906,23 @@ def extra_table_metadata(
indexes = database.get_indexes(table_name, schema_name)
codecov[bot] commented on PR #20729:
URL: https://github.com/apache/superset/pull/20729#issuecomment-1186075798
#
[Codecov](https://codecov.io/gh/apache/superset/pull/20729?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
john-bodley opened a new pull request, #20729:
URL: https://github.com/apache/superset/pull/20729
### SUMMARY
This PR remedies a few issues with Trino—which extends the Presto database
engine spec. Specifically at it relates to fetching extra metadata as part of
the SQL Lab s
zhaoyongjie commented on PR #20281:
URL: https://github.com/apache/superset/pull/20281#issuecomment-1186075099
@hug @hug have we really done testing? The explore page of master
branch seems doesn't work at all.
https://user-images.githubusercontent.com/2016594/179336747-ce3fa
codyml opened a new pull request, #20728:
URL: https://github.com/apache/superset/pull/20728
- [x] Merged in @zhaoyongjie's #20683 and did some quick/dirty fixes so
pagination is supported server-side
- [x] Used @zhaoyongjie's #20697 as a starting point, but created a new
container compo
hug merged PR #20281:
URL: https://github.com/apache/superset/pull/20281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@s
codyml commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r922566596
##
superset/datasets/commands/samples.py:
##
@@ -78,3 +116,24 @@ def validate(self) -> None:
security_manager.raise_for_ownership(self._model)
ex
codyml commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r922566596
##
superset/datasets/commands/samples.py:
##
@@ -78,3 +116,24 @@ def validate(self) -> None:
security_manager.raise_for_ownership(self._model)
ex
jinghua-qa commented on PR #20684:
URL: https://github.com/apache/superset/pull/20684#issuecomment-1186008015
QA team found an issue that when user add a chart (not owner) to the
dashboard and then delete, user will automatically become owner of the chart.
This issue has been filed in ticke
yashk1 commented on issue #5059:
URL: https://github.com/apache/superset/issues/5059#issuecomment-1186006544
We need horizontal bar chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
pkdotson commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r922549070
##
superset-frontend/src/explore/components/ExploreChartPanel.jsx:
##
@@ -145,9 +149,17 @@ const ExploreChartPanel = ({
getItem(LocalStorageKeys.chart_split_siz
codyml commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r922527182
##
superset/datasets/commands/samples.py:
##
@@ -78,3 +116,24 @@ def validate(self) -> None:
security_manager.raise_for_ownership(self._model)
ex
codyml commented on PR #20612:
URL: https://github.com/apache/superset/pull/20612#issuecomment-1185837914
> When looking at this screen, I feel that if I click on `Metric` it will
trigger an action just like all the other blue stuff on the screen. I
understand the reasoning behind the chang
Always-prog commented on issue #20319:
URL: https://github.com/apache/superset/issues/20319#issuecomment-1185835722
I have the same error.
Every-single request raises that exception.
Due to this exception I can't login, can't logout.
I have changed config.py and superset_config.p
codecov[bot] commented on PR #20661:
URL: https://github.com/apache/superset/pull/20661#issuecomment-1185816988
#
[Codecov](https://codecov.io/gh/apache/superset/pull/20661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
sfirke commented on issue #8538:
URL: https://github.com/apache/superset/issues/8538#issuecomment-1185783690
> In step 3 I'm getting a syntax error. Would `update dbs set password =
null; update dbs set encrypted_extra = null;` work?
I just ran `update dbs set password = null; ` witho
craig-rueda commented on PR #20722:
URL: https://github.com/apache/superset/pull/20722#issuecomment-1185781673
Ok, sounds good. My userid is `craig-rueda`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
craig-rueda opened a new pull request, #20727:
URL: https://github.com/apache/superset/pull/20727
### SUMMARY
The node container used to build local assets in `docker compose up` was
failing to run `npm install` due to a missing dependency. This PR fixes this
issue by adding the dependen
craig-rueda commented on issue #10149:
URL: https://github.com/apache/superset/issues/10149#issuecomment-1185754644
Hey guys, I just tried these steps:
1. pull latest `master`
2. cd into repo
3. run `docker compose up`
4. wait...
5. Login to `http://localhost:8080` using `a
moksh-enf commented on issue #5993:
URL: https://github.com/apache/superset/issues/5993#issuecomment-1185754466
In addition, has anyone deployed superset on docker? I would like to
increase the timeout there as well.
Thanks!
--
This is an automated message from the Apache Git Service.
Yann-J commented on PR #20722:
URL: https://github.com/apache/superset/pull/20722#issuecomment-1185750212
Hmm I'm not sure where these come from, my IDE didn't show these when I
committed... I'll try to revert these.
The ID is tied to the Superset organization I created in Artifact hu
codecov[bot] commented on PR #20726:
URL: https://github.com/apache/superset/pull/20726#issuecomment-1185746262
#
[Codecov](https://codecov.io/gh/apache/superset/pull/20726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
craig-rueda commented on issue #13287:
URL: https://github.com/apache/superset/issues/13287#issuecomment-1185743445
Also, did you need to create an account in artifacthub to get this working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
craig-rueda commented on issue #13287:
URL: https://github.com/apache/superset/issues/13287#issuecomment-1185743073
Thanks, @Yann-J . I left a comment over on #20722 for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
craig-rueda commented on PR #20722:
URL: https://github.com/apache/superset/pull/20722#issuecomment-1185742166
Looks good, but do we need to bump all of the `github/actions/*` submodules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
john-bodley opened a new pull request, #20726:
URL: https://github.com/apache/superset/pull/20726
### SUMMARY
The `cache_manager.cache`—the original catch-all cache which likely should
be renames to `cache_manager.metadata_cache`—should be used for caching the
table/view meta
codyml commented on code in PR #20673:
URL: https://github.com/apache/superset/pull/20673#discussion_r922337474
##
superset/views/redirects.py:
##
@@ -34,25 +34,40 @@ class R(BaseSupersetView): # pylint: disable=invalid-name
"""used for short urls"""
@staticmethod
-
michael-s-molina commented on code in PR #20673:
URL: https://github.com/apache/superset/pull/20673#discussion_r922077985
##
superset/views/redirects.py:
##
@@ -34,25 +34,40 @@ class R(BaseSupersetView): # pylint: disable=invalid-name
"""used for short urls"""
@stat
michael-s-molina commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r922232391
##
superset/datasets/api.py:
##
@@ -810,7 +822,15 @@ def samples(self, pk: int) -> Response:
"""
try:
force = parse_boolean_st
lanzhenw commented on issue #19222:
URL: https://github.com/apache/superset/issues/19222#issuecomment-1185692569
Having the same issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
imanollew commented on PR #20368:
URL: https://github.com/apache/superset/pull/20368#issuecomment-1185671671
Hello, Im not sure if Im misunderstanding something but my VERSIONED_EXPORT
flag is set to TRUE, yet I cant export any dashboard / dataset / chart because
the button "export" is hidd
codyml commented on code in PR #20673:
URL: https://github.com/apache/superset/pull/20673#discussion_r922283704
##
superset/views/core.py:
##
@@ -427,13 +427,13 @@ def slice(self, slice_id: int) -> FlaskResponse: #
pylint: disable=no-self-use
_, slc = get_form_data(sl
pkdotson opened a new pull request, #20725:
URL: https://github.com/apache/superset/pull/20725
### SUMMARY
This pr is a possible fix for potential error of having the wrong type for
the datasource type and causing a validation error being thrown.
### BEFORE/AFTER SCREENSHO
codyml commented on PR #20684:
URL: https://github.com/apache/superset/pull/20684#issuecomment-1185653640
> I did some digging and this is the
[PR](https://github.com/apache/superset/pull/11336) that introduced that
filter. Maybe @nytai has some context on it?
@michael-s-molina Looks
betodealmeida merged PR #20714:
URL: https://github.com/apache/superset/pull/20714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
konradwudkowski commented on issue #19433:
URL: https://github.com/apache/superset/issues/19433#issuecomment-1185594185
I encountered this error on python 3.8.9, I changed to 3.8.12 and it worked,
didn't check further why that may be the case 👍
--
This is an automated message from the Ap
phpsxg commented on issue #20664:
URL: https://github.com/apache/superset/issues/20664#issuecomment-1185589306
> could you try upgrade clickhouse-sqlalchemy to 0.1.8 and check again?
Sorry, I wrote wrong, I used clickhouse-sqlalchem==0.1.9, there is this
problem
--
This is an autom
michael-s-molina commented on code in PR #20690:
URL: https://github.com/apache/superset/pull/20690#discussion_r922168290
##
superset-frontend/src/components/Select/AsyncSelect.tsx:
##
@@ -299,7 +298,7 @@ const AsyncSelect = (
filterOption = true,
header = null,
i
zhaoyongjie commented on PR #20528:
URL: https://github.com/apache/superset/pull/20528#issuecomment-1185576304
this PR should wait for merging
[this](https://github.com/apache/superset/pull/20673).
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
zhaoyongjie commented on PR #20684:
URL: https://github.com/apache/superset/pull/20684#issuecomment-1185574979
This PR should wait merging
[PR](https://github.com/apache/superset/pull/20673)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mdeshmu opened a new issue, #20724:
URL: https://github.com/apache/superset/issues/20724
When multiple pages are present in a table chart and user clicks on Export
full CSV, only the data from first page is getting exported in CSV.
How to reproduce the bug
1. Go to 'Dashbo
zhaoyongjie commented on PR #20673:
URL: https://github.com/apache/superset/pull/20673#issuecomment-1185570181
I have tested it in my local. the command `superset compute-thumbnails -c`
works and the thumbnail was generated.
 -> FlaskResponse: #
pylint: disable=no-self-use
_, slc = get_form_da
dat-linux commented on issue #20723:
URL: https://github.com/apache/superset/issues/20723#issuecomment-1185556641
A hack to get around it:
```
python3 -m pip uninstall -y Werkzeug
python3 -m pip install Werkzeug==2.0.3
```
If there's one thing you can reply on with a su
srinify closed issue #20721: Do you plan to support influxdb in the future?
URL: https://github.com/apache/superset/issues/20721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
srinify commented on issue #20721:
URL: https://github.com/apache/superset/issues/20721#issuecomment-1185545091
hey @icwseven any SQL speaking database can be made to work in Superset but
there needs to be a Python DB API 2.0 driver & SQL Alchemy dialect.
AFAIK the InfluxDB community
dat-linux opened a new issue, #20723:
URL: https://github.com/apache/superset/issues/20723
A clear and concise description of what the bug is.
How to reproduce the bug
Install using pip on Ubuntu with python 3.9
NOTE: "pip install Werkzeug" does not fix the problem
Yann-J commented on PR #20722:
URL: https://github.com/apache/superset/pull/20722#issuecomment-1185527585
FYI, artifacthub page for the published chart:
https://artifacthub.io/packages/helm/superset/superset
--
This is an automated message from the Apache Git Service.
To respond to the me
michael-s-molina commented on PR #20684:
URL: https://github.com/apache/superset/pull/20684#issuecomment-1185519227
I did some digging and this is the
[PR](https://github.com/apache/superset/pull/11336) that introduced that
filter. Maybe @nytai has some context on it?
--
This is an autom
mdeshmu commented on issue #19094:
URL: https://github.com/apache/superset/issues/19094#issuecomment-1185517633
I am also facing the same issue.
Chrome Version 103.0.5060.114 (Official Build) (64-bit)
Apache Superset 1.5.1
--
This is an automated message from the Apache Git Service.
michael-s-molina closed issue #19471: Release 2.0
URL: https://github.com/apache/superset/issues/19471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
michael-s-molina commented on PR #20714:
URL: https://github.com/apache/superset/pull/20714#issuecomment-1185489998
@betodealmeida The license error was fixed
[here](https://github.com/apache/superset/pull/20713) so you just need to
rebase your PR.
--
This is an automated message from th
Yann-J commented on issue #13287:
URL: https://github.com/apache/superset/issues/13287#issuecomment-1185481874
Looping in @craig-rueda for comments maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
everton3x commented on issue #8249:
URL: https://github.com/apache/superset/issues/8249#issuecomment-1185480242
I installed the superset as per the tutorial via Docker Compose on Windows
11 and added a SQLite database using the ```PREVENT_UNSAFE_DB_CONNECTIONS =
False``` directive
Th
everton3x commented on issue #8249:
URL: https://github.com/apache/superset/issues/8249#issuecomment-1185480131
I installed the superset as per the tutorial via Docker Compose on Windows
11 and added a SQLite database using the ```PREVENT_UNSAFE_DB_CONNECTIONS =
False``` directive
Th
Yann-J commented on issue #13287:
URL: https://github.com/apache/superset/issues/13287#issuecomment-1185479942
I had a quick look at how the helm chart is being published, and it looks
like auto-releasing of the Helm chart is already working pretty well, with
packages being published as a G
michael-s-molina commented on PR #20135:
URL: https://github.com/apache/superset/pull/20135#issuecomment-1185466579
> Hi! By looking at the release notes I see this not being part of 2.0, any
idea in which version this fix will be released? Thanks!
@agusfigueroa-htg This fix was alrea
request-info[bot] commented on PR #20722:
URL: https://github.com/apache/superset/pull/20722#issuecomment-1185466526
We would appreciate it if you could provide us with more info about this
issue/pr! Please do not leave the `title` or `description` empty.
--
This is an automated messa
michael-s-molina merged PR #20710:
URL: https://github.com/apache/superset/pull/20710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsu
michael-s-molina commented on PR #20673:
URL: https://github.com/apache/superset/pull/20673#issuecomment-1185460225
@codyml The license error was fixed
[here](https://github.com/apache/superset/pull/20713) so you just need to
rebase your PR.
--
This is an automated message from the Apach
Rumo99 closed issue #20665: Installation with Helm fails behind proxy
URL: https://github.com/apache/superset/issues/20665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Rumo99 commented on issue #20665:
URL: https://github.com/apache/superset/issues/20665#issuecomment-1185458162
Thank you, this solved the issue.
Since I am on Windows, I employed this
solution:[https://github.com/helm/helm/issues/9576#issuecomment-817896885]
(Github Helm Issue) to en
kgabryje commented on PR #20673:
URL: https://github.com/apache/superset/pull/20673#issuecomment-1185443746
Thanks for the fix! The code looks great to me, but I can't fully test it,
because for some reason the reports don't work for me on localhost (unrelated
to this PR)
--
This is an a
agusfigueroa-htg commented on PR #20135:
URL: https://github.com/apache/superset/pull/20135#issuecomment-1185413295
Hi! By looking at the release notes I see this not being part of 2.0, any
idea in which version this fix will be released? Thanks!
--
This is an automated message from the A
mkhudia commented on issue #10149:
URL: https://github.com/apache/superset/issues/10149#issuecomment-1185401297
It's half past 2022 and:
- Documented username and password `admin` `admin` don't work
- Even though superset gets set up locally but is unable to log in doesn't
allow f
codecov[bot] commented on PR #20720:
URL: https://github.com/apache/superset/pull/20720#issuecomment-1185389925
#
[Codecov](https://codecov.io/gh/apache/superset/pull/20720?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
albertopinardi commented on issue #20665:
URL: https://github.com/apache/superset/issues/20665#issuecomment-1185356728
Hey, I looked it up and these URLs that's Helm is failing to call are legit
(it's a schema verification process on the Chart itself). So it's Helm that
does not use the Pro
lcwSeven opened a new issue, #20721:
URL: https://github.com/apache/superset/issues/20721
Do you plan to support influxdb in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Antonio-RiveroMartnez opened a new pull request, #20720:
URL: https://github.com/apache/superset/pull/20720
### SUMMARY
`ControlPopover` is in charge of handling the scroll status, however, after
we remove an annotation, its ControlPopover is not longer available thus the
scroll status s
Slach commented on issue #20633:
URL: https://github.com/apache/superset/issues/20633#issuecomment-1185281414
could you try upgrade clickhouse-sqlalchemy to 0.1.8 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Slach commented on issue #20664:
URL: https://github.com/apache/superset/issues/20664#issuecomment-1185280477
could you try upgrade clickhouse-sqlalchemy to 0.1.8 and check again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hehetown commented on issue #1761:
URL: https://github.com/apache/superset/issues/1761#issuecomment-1185278499
I am sure the connection Settings are correct. I need to connect to Oracle
Service instead of SID. How should I configure it
--
This is an automated message from the Apache Git S
memes-forever opened a new issue, #20718:
URL: https://github.com/apache/superset/issues/20718
## Screenshot
## Description
I propose to continue the discussi
alanorth opened a new issue, #20717:
URL: https://github.com/apache/superset/issues/20717
I installed Superset 2.0.0 via pip. I get the following error when running
`superset` after installation:
```console
$ superset
...
ModuleNotFoundError: No module named 'werkzeug.wrapper
78 matches
Mail list logo
