[GitHub] [superset] stephenLYZ opened a new pull request, #21781: perf(native-filters): reduce the re-rendering of native filter modal

2022-10-11 Thread GitBox
stephenLYZ opened a new pull request, #21781: URL: https://github.com/apache/superset/pull/21781 ### SUMMARY We use `why-did-you-render` tool to measure the re-rendering of the native filter modal. This PR improves native filter modal in two scenarios (which has more than 20

[GitHub] [superset] artemonsh opened a new pull request, #21780: chore: Russian translation update in messages.po

2022-10-11 Thread GitBox
artemonsh opened a new pull request, #21780: URL: https://github.com/apache/superset/pull/21780 ### SUMMARY This PR updates the Russian translation files. Some of the translations were changed, added or deleted. All changes were made to .po and .json files. ### BEFORE/AFTE

[GitHub] [superset] codecov[bot] commented on pull request #21779: fix(plugin-chart-handlebars): Update webpack/babel config to fix build/runtime warnings/errors

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21779: URL: https://github.com/apache/superset/pull/21779#issuecomment-1275575293 # [Codecov](https://codecov.io/gh/apache/superset/pull/21779?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] john-bodley commented on a diff in pull request #21778: fix(migration): Ensure the paginated update is deterministic

2022-10-11 Thread GitBox
john-bodley commented on code in PR #21778: URL: https://github.com/apache/superset/pull/21778#discussion_r992926312 ## superset/migrations/shared/utils.py: ## @@ -100,22 +100,31 @@ def paginated_update( """ Update models in small batches so we don't have to load every

[GitHub] [superset] john-bodley commented on a diff in pull request #21778: fix(migration): Ensure the paginated update is deterministic

2022-10-11 Thread GitBox
john-bodley commented on code in PR #21778: URL: https://github.com/apache/superset/pull/21778#discussion_r992926312 ## superset/migrations/shared/utils.py: ## @@ -100,22 +100,31 @@ def paginated_update( """ Update models in small batches so we don't have to load every

[GitHub] [superset] john-bodley commented on pull request #21778: fix(migration): Ensure the paginated update is deterministic

2022-10-11 Thread GitBox
john-bodley commented on PR #21778: URL: https://github.com/apache/superset/pull/21778#issuecomment-1275542412 @ktmud > Your comment reminded me, what if an object was updated in the loop in a way that makes it no longer matches the query's filtering condition Now that the que

[GitHub] [superset] codyml opened a new pull request, #21779: fix(plugin-chart-handlebars): Update webpack/babel config to fix build/runtime warnings/errors

2022-10-11 Thread GitBox
codyml opened a new pull request, #21779: URL: https://github.com/apache/superset/pull/21779 ### SUMMARY This PR is an attempt to fix the Handlebars viz plugin, which currently raises both build and runtime errors, by updating Webpack and Babel config. Build wa

[GitHub] [superset] long-tranvan commented on issue #16030: [API Rest] Redirecting to /login when doing a POST to /api/v1/database/import/

2022-10-11 Thread GitBox
long-tranvan commented on issue #16030: URL: https://github.com/apache/superset/issues/16030#issuecomment-1275519441 Hi @pedrohdemedeiros You can try this workaround (at least it works for me) ```sh export SUPERSET_BASE_URL=#your superset endpoint export URL_AUTH=$SUPERSET_BAS

[GitHub] [superset] codecov[bot] commented on pull request #21778: fix(migration): Ensure the paginated update is deterministic

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21778: URL: https://github.com/apache/superset/pull/21778#issuecomment-1275515892 # [Codecov](https://codecov.io/gh/apache/superset/pull/21778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] Cmagno13 commented on issue #21548: Predictive Analytics (Prophet) forecast not affected by changing time grain in Dashboard filter

2022-10-11 Thread GitBox
Cmagno13 commented on issue #21548: URL: https://github.com/apache/superset/issues/21548#issuecomment-1275512364 Environment browser type and version: Firefox 105.0.3 (64-bits) superset version: 2.0.0 python version: 3.9.2 node.js version: 16.16.0 -- This is an automated messag

[GitHub] [superset] Cmagno13 commented on issue #21548: Predictive Analytics (Prophet) forecast not affected by changing time grain in Dashboard filter

2022-10-11 Thread GitBox
Cmagno13 commented on issue #21548: URL: https://github.com/apache/superset/issues/21548#issuecomment-1275511771 Goodnight! I also have this error when generating the forecast ![01](https://user-images.githubusercontent.com/97127080/195237918-66b05345-dc2b-4c76-8b6a-7fa7f4e1e6c9.png)

[GitHub] [superset] john-bodley commented on a diff in pull request #21778: fix(migration): Ensure the paginated update is deterministic

2022-10-11 Thread GitBox
john-bodley commented on code in PR #21778: URL: https://github.com/apache/superset/pull/21778#discussion_r992926475 ## superset/migrations/shared/utils.py: ## @@ -100,22 +100,31 @@ def paginated_update( """ Update models in small batches so we don't have to load every

[GitHub] [superset] john-bodley opened a new pull request, #21778: fix(migration): Ensure the paginated update is deterministic

2022-10-11 Thread GitBox
john-bodley opened a new pull request, #21778: URL: https://github.com/apache/superset/pull/21778 ### SUMMARY This PR fixes an issue with the `paginated_update` method which is used in a number of migrations. The problem is the pagination was not deterministic, i.e., per iter

[GitHub] [superset] gcoder5 opened a new issue, #21777: about add dataset for clickhouse

2022-10-11 Thread GitBox
gcoder5 opened a new issue, #21777: URL: https://github.com/apache/superset/issues/21777 A clear and concise description of what the bug is. How to reproduce the bug 1. Go to Main Page 2. Click on Connect database 3. select Clickhouse 4. if my clickhouse password i

[GitHub] [superset] zhaoyongjie merged pull request #21766: refactor: preparation for time section migration

2022-10-11 Thread GitBox
zhaoyongjie merged PR #21766: URL: https://github.com/apache/superset/pull/21766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [superset] codecov[bot] commented on pull request #21776: fix(CustomFrame): Resolves issue #21731 where date range in explore throws runtime error

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21776: URL: https://github.com/apache/superset/pull/21776#issuecomment-1275421038 # [Codecov](https://codecov.io/gh/apache/superset/pull/21776?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] kamalkeshavani-aiinside commented on issue #21718: How do I rename legend from dimension?

2022-10-11 Thread GitBox
kamalkeshavani-aiinside commented on issue #21718: URL: https://github.com/apache/superset/issues/21718#issuecomment-1275419519 New feature are also requested in the 'Discussions'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [superset] eschutho commented on pull request #21765: fix(alerts): restrict list view and gamma perms

2022-10-11 Thread GitBox
eschutho commented on PR #21765: URL: https://github.com/apache/superset/pull/21765#issuecomment-1275416263 @villebro I asked for some product/design feedback on what an alpha can see on the list page, too. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [superset] eschutho commented on a diff in pull request #21765: fix(alerts): restrict list view and gamma perms

2022-10-11 Thread GitBox
eschutho commented on code in PR #21765: URL: https://github.com/apache/superset/pull/21765#discussion_r992867099 ## UPDATING.md: ## @@ -32,6 +32,8 @@ assists people when migrating to a new version. ### Breaking Changes +- [21765](https://github.com/apache/superset/pull/217

[GitHub] [superset] eschutho commented on a diff in pull request #21776: fix(CustomFrame): Resolves issue #21731 where date range in explore throws runtime error

2022-10-11 Thread GitBox
eschutho commented on code in PR #21776: URL: https://github.com/apache/superset/pull/21776#discussion_r992856452 ## superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.test.tsx: ## @@ -39,6 +39,14 @@ const store = mockStore({ common: {

[GitHub] [superset] zhaorui2022 commented on pull request #21724: fix(report): Capture unexpected errors in report screenshots. Fixes #21653

2022-10-11 Thread GitBox
zhaorui2022 commented on PR #21724: URL: https://github.com/apache/superset/pull/21724#issuecomment-1275396629 > good stuff, have 2 questions. > > 1. in case of error modal, should we send the alert to owner and not to the receivers? > I think two approach could both wo

[GitHub] [superset] eric-briscoe opened a new pull request, #21776: fix(CustomFrame): Resolves issue #21731 where date range in explore throws runtime error

2022-10-11 Thread GitBox
eric-briscoe opened a new pull request, #21776: URL: https://github.com/apache/superset/pull/21776 ### SUMMARY Resolves issue #21731 where date range in explore throws runtime error when explore.common is undefined in Redux state. See associated issue: https://git

[GitHub] [superset] martinkonopka opened a new issue, #21775: Development libraries in the release version, including GPL-2.0 licensed mysqlclient

2022-10-11 Thread GitBox
martinkonopka opened a new issue, #21775: URL: https://github.com/apache/superset/issues/21775 Dockerfile defines installation of the packages for development from `requirements/development.txt` also to `lean` version of Docker image. This results in inclusion of packages for development in

[GitHub] [superset] rumbin commented on issue #20740: Mixed two-series chart - cannot define minimax for distinct Y scales

2022-10-11 Thread GitBox
rumbin commented on issue #20740: URL: https://github.com/apache/superset/issues/20740#issuecomment-1275297824 Confirming this observation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [superset] github-actions[bot] commented on pull request #21770: fix: Dataset left panel now uses client side search

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21770: URL: https://github.com/apache/superset/pull/21770#issuecomment-1275287272 @pkdotson Ephemeral environment spinning up at http://54.70.240.166:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. --

[GitHub] [superset] pkdotson commented on pull request #21770: fix: Dataset left panel now uses client side search

2022-10-11 Thread GitBox
pkdotson commented on PR #21770: URL: https://github.com/apache/superset/pull/21770#issuecomment-1275283515 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [superset] codecov[bot] commented on pull request #21773: fix: remove deprecated ETagResponseMixin

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21773: URL: https://github.com/apache/superset/pull/21773#issuecomment-1275252436 # [Codecov](https://codecov.io/gh/apache/superset/pull/21773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] misumme-pg opened a new issue, #21774: Erro: persistentvolume-controller waiting for pod superset-postgresql-0 to be scheduled

2022-10-11 Thread GitBox
misumme-pg opened a new issue, #21774: URL: https://github.com/apache/superset/issues/21774 I'm trying to install superset in my eks cluster but keep running into following error Normal WaitForPodScheduled 4m6s (x23 over 19m) persistentvolume-controller waiting for pod supers

[GitHub] [superset] codecov[bot] commented on pull request #21772: fix example comment to match type

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21772: URL: https://github.com/apache/superset/pull/21772#issuecomment-1275249217 # [Codecov](https://codecov.io/gh/apache/superset/pull/21772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] eschutho opened a new pull request, #21773: fix: remove deprecated ETagResponseMixin

2022-10-11 Thread GitBox
eschutho opened a new pull request, #21773: URL: https://github.com/apache/superset/pull/21773 ### SUMMARY The Werkzeug 2.1 release removed some deprecated code and merged the ETagResponseMixin into the Response class. Instead of pinning superset to any flask or werkzeug version, I'm ret

[GitHub] [superset] eschutho opened a new pull request, #21772: fix example comment to match type

2022-10-11 Thread GitBox
eschutho opened a new pull request, #21772: URL: https://github.com/apache/superset/pull/21772 I updated the type for this config but forgot to update the comment. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION

[GitHub] [superset] codecov[bot] commented on pull request #21771: fix(sqllab): remove set state on component update lifecycle

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21771: URL: https://github.com/apache/superset/pull/21771#issuecomment-1275195734 # [Codecov](https://codecov.io/gh/apache/superset/pull/21771?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] hughhhh merged pull request #21738: chore: cleanup on catalog check for Gsheets

2022-10-11 Thread GitBox
hug merged PR #21738: URL: https://github.com/apache/superset/pull/21738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@s

[GitHub] [superset] ktmud commented on pull request #21771: fix(sqllab): remove set state on component update lifecycle

2022-10-11 Thread GitBox
ktmud commented on PR #21771: URL: https://github.com/apache/superset/pull/21771#issuecomment-1275153001 Can you add more details on how to reproduce this max-depth-call-stack error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [superset] justinpark opened a new pull request, #21771: fix(sqllab): remove set state on component update lifecycle

2022-10-11 Thread GitBox
justinpark opened a new pull request, #21771: URL: https://github.com/apache/superset/pull/21771 ### SUMMARY Since the legacy TabbedSqlEditor component uses `UNSAFE_componentWillReceiveProps` lifecycle method to update the state for `editorQueries` and `dataPreviewQueries`, which **only*

[GitHub] [superset] github-actions[bot] commented on pull request #21557: fix: Dataset creation header is now uneditable and holds proper default values

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21557: URL: https://github.com/apache/superset/pull/21557#issuecomment-1275099578 @jinghua-qa Ephemeral environment spinning up at http://54.202.251.181:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.

[GitHub] [superset] github-actions[bot] commented on pull request #21064: fix(chart-table): Scrollbar causing header + footer overflow

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21064: URL: https://github.com/apache/superset/pull/21064#issuecomment-1275097292 @rusackas Ephemeral environment creation failed. Please check the Actions logs for details. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [superset] github-actions[bot] commented on pull request #21064: fix(chart-table): Scrollbar causing header + footer overflow

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21064: URL: https://github.com/apache/superset/pull/21064#issuecomment-1275097278 @rusackas Container image not yet published for this PR. Please try again when build is complete. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [superset] rusackas commented on pull request #21064: fix(chart-table): Scrollbar causing header + footer overflow

2022-10-11 Thread GitBox
rusackas commented on PR #21064: URL: https://github.com/apache/superset/pull/21064#issuecomment-1275093424 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [superset] github-actions[bot] commented on pull request #21442: fix(datasets): Stop showing alert when saving from query

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21442: URL: https://github.com/apache/superset/pull/21442#issuecomment-1275079950 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [superset] github-actions[bot] commented on pull request #21698: fix(sqllab): Async queries are now fetched properly

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21698: URL: https://github.com/apache/superset/pull/21698#issuecomment-1275056349 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [superset] EugeneTorap commented on pull request #21650: chore: Use queryEditorId in SqlEditor child components

2022-10-11 Thread GitBox
EugeneTorap commented on PR #21650: URL: https://github.com/apache/superset/pull/21650#issuecomment-1275041332 @lyndsiWilliams Can you review and merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [superset] eschutho merged pull request #21442: fix(datasets): Stop showing alert when saving from query

2022-10-11 Thread GitBox
eschutho merged PR #21442: URL: https://github.com/apache/superset/pull/21442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [superset] lyndsiWilliams merged pull request #21698: fix(sqllab): Async queries are now fetched properly

2022-10-11 Thread GitBox
lyndsiWilliams merged PR #21698: URL: https://github.com/apache/superset/pull/21698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [superset] jinghua-qa commented on pull request #21557: fix: Dataset creation header is now uneditable and holds proper default values

2022-10-11 Thread GitBox
jinghua-qa commented on PR #21557: URL: https://github.com/apache/superset/pull/21557#issuecomment-1274996314 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [superset] codecov[bot] commented on pull request #21770: fix: Dataset left panel now uses client side search

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21770: URL: https://github.com/apache/superset/pull/21770#issuecomment-1274986696 # [Codecov](https://codecov.io/gh/apache/superset/pull/21770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] github-actions[bot] commented on pull request #21760: feat: Cross-referenced Dashboards in Chart list (Column + Filter)

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21760: URL: https://github.com/apache/superset/pull/21760#issuecomment-1274969862 @geido Ephemeral environment spinning up at http://34.214.27.57:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. -- Thi

[GitHub] [superset] fMagVen commented on issue #21718: How do I rename legend from dimension?

2022-10-11 Thread GitBox
fMagVen commented on issue #21718: URL: https://github.com/apache/superset/issues/21718#issuecomment-1274967649 a better idea would be to turn it into a feature request, but how do i do that -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [superset] lyndsiWilliams opened a new pull request, #21770: fix: Dataset left panel now uses client side search

2022-10-11 Thread GitBox
lyndsiWilliams opened a new pull request, #21770: URL: https://github.com/apache/superset/pull/21770 ### SUMMARY This PR changed the left panel's search functionality from server side searching to client side searching. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[GitHub] [superset] pengwk opened a new pull request, #21769: fix(SavedQueries): allow other admin users see "saved queries" (#20604)

2022-10-11 Thread GitBox
pengwk opened a new pull request, #21769: URL: https://github.com/apache/superset/pull/21769 ### SUMMARY Show the list of all saved queries despite of creators. If the fix is acceptable, then add the test. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ###

[GitHub] [superset] pengwk commented on issue #20604: Other admin users can't see "saved queries" created by another admin users

2022-10-11 Thread GitBox
pengwk commented on issue #20604: URL: https://github.com/apache/superset/issues/20604#issuecomment-1274891317 This can temporarily solve the problem @emilija-omnisend @winglight ``` diff --git a/superset/queries/saved_queries/filters.py b/superset/queries/saved_queries/filters.py

[GitHub] [superset] github-actions[bot] commented on pull request #21438: perf(dashboard): Virtualization POC

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21438: URL: https://github.com/apache/superset/pull/21438#issuecomment-1274800057 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21760: feat: Cross-referenced Dashboards in Chart list (Column + Filter)

2022-10-11 Thread GitBox
zhaoyongjie commented on code in PR #21760: URL: https://github.com/apache/superset/pull/21760#discussion_r992341075 ## superset-frontend/src/views/CRUD/chart/ChartList.tsx: ## @@ -135,6 +137,47 @@ const createFetchDatasets = async ( }; }; +const createFetchDashboards = as

[GitHub] [superset] zhaoyongjie commented on pull request #20359: feat: Area viz migration

2022-10-11 Thread GitBox
zhaoyongjie commented on PR #20359: URL: https://github.com/apache/superset/pull/20359#issuecomment-1274760732 @john-bodley Sorry, I'm stuck in another [PR](https://github.com/apache/superset/pull/20639) with a cypress problem. I think the migration process should be re-run after resolve th

[GitHub] [superset] MM-Lehmann commented on issue #20694: Update of Roles from Keycloak to Superset is not working

2022-10-11 Thread GitBox
MM-Lehmann commented on issue #20694: URL: https://github.com/apache/superset/issues/20694#issuecomment-1274724182 Can you try with 2.0 please? Also, make sure the feature flag `AUTH_ROLES_SYNC_AT_LOGIN` is set to true and the user logs out and in again. -- This is an automated message fr

[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21760: feat: Cross-referenced Dashboards in Chart list (Column + Filter)

2022-10-11 Thread GitBox
zhaoyongjie commented on code in PR #21760: URL: https://github.com/apache/superset/pull/21760#discussion_r992341075 ## superset-frontend/src/views/CRUD/chart/ChartList.tsx: ## @@ -135,6 +137,47 @@ const createFetchDatasets = async ( }; }; +const createFetchDashboards = as

[GitHub] [superset] michael-s-molina commented on a diff in pull request #21760: feat: Cross-referenced Dashboards in Chart list (Column + Filter)

2022-10-11 Thread GitBox
michael-s-molina commented on code in PR #21760: URL: https://github.com/apache/superset/pull/21760#discussion_r992294388 ## superset-frontend/src/components/ListView/CrossLinks.test.tsx: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [superset] geido commented on pull request #21760: feat: Cross-referenced Dashboards in Chart list (Column + Filter)

2022-10-11 Thread GitBox
geido commented on PR #21760: URL: https://github.com/apache/superset/pull/21760#issuecomment-1274663976 /testenv up FEATURE_CROSS_REFERENCES=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [superset] kgabryje merged pull request #21438: perf(dashboard): Virtualization POC

2022-10-11 Thread GitBox
kgabryje merged PR #21438: URL: https://github.com/apache/superset/pull/21438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [superset] zhaoyongjie commented on issue #21755: x-aixs alias name same as original field name

2022-10-11 Thread GitBox
zhaoyongjie commented on issue #21755: URL: https://github.com/apache/superset/issues/21755#issuecomment-1274658969 @HeathLee Thanks for the report, I will follow this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [superset] geido commented on pull request #21507: feat(color): color consistency enhancements

2022-10-11 Thread GitBox
geido commented on PR #21507: URL: https://github.com/apache/superset/pull/21507#issuecomment-1274618563 Adding @jinghua-qa for an upmost confirmation from QA. Let's hold for her feedback before merging -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [superset] dreseldo opened a new issue, #21768: Schema name is needed for Dataset in UI but not in API

2022-10-11 Thread GitBox
dreseldo opened a new issue, #21768: URL: https://github.com/apache/superset/issues/21768 When creating a dataset the schema field must be filled out. If the database does not support schemas (like SolR) the dataset cannot be created because the list of tables gets not filled. When using th

[GitHub] [superset] codecov[bot] commented on pull request #21767: feat: support mulitple datetime filter in AdhocFilter and move away time section

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21767: URL: https://github.com/apache/superset/pull/21767#issuecomment-1274554626 # [Codecov](https://codecov.io/gh/apache/superset/pull/21767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] michael-s-molina merged pull request #21744: chore(explore): Add tests for getControlValuesCompatibleWithDatasource

2022-10-11 Thread GitBox
michael-s-molina merged PR #21744: URL: https://github.com/apache/superset/pull/21744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [superset] pthirumalai commented on issue #20968: DB engine Error

2022-10-11 Thread GitBox
pthirumalai commented on issue #20968: URL: https://github.com/apache/superset/issues/20968#issuecomment-1274496062 Hi @saghatelian The issue got resolved after we made changes to the docker/requirements-local.txt as per your suggestion. Thanks. -- This is an automated message fro

[GitHub] [superset] codecov[bot] commented on pull request #21764: chore(deps-dev): bump @typescript-eslint/parser from 4.19.0 to 5.40.0 in /superset-websocket

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21764: URL: https://github.com/apache/superset/pull/21764#issuecomment-1274449398 # [Codecov](https://codecov.io/gh/apache/superset/pull/21764?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] codecov[bot] commented on pull request #21765: fix(alerts): restrict list view and gamma perms

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21765: URL: https://github.com/apache/superset/pull/21765#issuecomment-1274439250 # [Codecov](https://codecov.io/gh/apache/superset/pull/21765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] villebro commented on a diff in pull request #21766: refactor: preparation for time section migration

2022-10-11 Thread GitBox
villebro commented on code in PR #21766: URL: https://github.com/apache/superset/pull/21766#discussion_r992080780 ## superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx: ## @@ -227,7 +226,7 @@ const time_range: SharedControlConfig<'DateFilterContr

[GitHub] [superset] pthirumalai commented on issue #21619: Superset dashboard filter error

2022-10-11 Thread GitBox
pthirumalai commented on issue #21619: URL: https://github.com/apache/superset/issues/21619#issuecomment-1274386148 Hi @saghatelian , Thanks for your reply. I have already tried uninstalling pybigquery and installed sqlalchemy-bigquery, but still the issue persists. -- This is an automate

[GitHub] [superset] pthirumalai commented on issue #21619: Superset dashboard filter error

2022-10-11 Thread GitBox
pthirumalai commented on issue #21619: URL: https://github.com/apache/superset/issues/21619#issuecomment-1274386402 Hi @saghatelian , Thanks for your reply. I have already tried uninstalling pybigquery and installed sqlalchemy-bigquery, but still the issue persists. -- This is an automate

[GitHub] [superset] villebro commented on a diff in pull request #21641: fix(superset-embedded-sdk): Buffer is not defined

2022-10-11 Thread GitBox
villebro commented on code in PR #21641: URL: https://github.com/apache/superset/pull/21641#discussion_r992058612 ## superset-embedded-sdk/package.json: ## @@ -1,6 +1,6 @@ { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.7", + "version": "0.1.0-alpha.8", R

[GitHub] [superset] zhaoyongjie opened a new pull request, #21767: feat: support mulitple datetime filter in AdhocFilter and move away time section

2022-10-11 Thread GitBox
zhaoyongjie opened a new pull request, #21767: URL: https://github.com/apache/superset/pull/21767 ### SUMMARY TBD, should wait for [PR](https://github.com/apache/superset/pull/21766) to merged. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS

[GitHub] [superset] zhaoyongjie opened a new pull request, #21766: refactor: preparation for time section migration

2022-10-11 Thread GitBox
zhaoyongjie opened a new pull request, #21766: URL: https://github.com/apache/superset/pull/21766 ### SUMMARY In order to easily review the Time Section Migration, all refactoring work is done in this PR. This PR shouldn't change any current behaviors. ### BEFORE/AFTER SCREENSHOTS

[GitHub] [superset] saghatelian commented on issue #21619: Superset dashboard filter error

2022-10-11 Thread GitBox
saghatelian commented on issue #21619: URL: https://github.com/apache/superset/issues/21619#issuecomment-1274353223 Ok, I've found the solution in another thread: https://github.com/apache/superset/issues/20968 Changing `pybigquery` to `sqlalchemy-bigquery` in `docker/requirements-

[GitHub] [superset] codecov[bot] commented on pull request #21763: chore(deps-dev): bump @types/node from 16.11.6 to 18.8.4 in /superset-websocket

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21763: URL: https://github.com/apache/superset/pull/21763#issuecomment-1274352381 # [Codecov](https://codecov.io/gh/apache/superset/pull/21763?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] saghatelian commented on issue #20968: DB engine Error

2022-10-11 Thread GitBox
saghatelian commented on issue #20968: URL: https://github.com/apache/superset/issues/20968#issuecomment-1274351978 Hi @pthirumalai We also have a Docker installation. Changing `pybigquery` to `sqlalchemy-bigquery` in `docker/requirements-local.txt` solved the issue for me. -- Thi

[GitHub] [superset] qq273681448 commented on issue #2580: Question: How to auto login (bypass) login page?

2022-10-11 Thread GitBox
qq273681448 commented on issue #2580: URL: https://github.com/apache/superset/issues/2580#issuecomment-1274320430 HI!我是邵磊,您的邮件我已经收到啦,我会在第一时间给您回复哦。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [superset] villebro opened a new pull request, #21765: fix(alerts): restrict list view and gamma perms

2022-10-11 Thread GitBox
villebro opened a new pull request, #21765: URL: https://github.com/apache/superset/pull/21765 ### SUMMARY Currently Gamma users have read and write permissions for Alerts & Reports and access the "Alerts & Reports" menu. However, since they don't have access to the "Manage" menu, they c

[GitHub] [superset] codecov[bot] commented on pull request #21754: chore(deps): bump express from 4.18.1 to 4.18.2 in /superset-websocket/utils/client-ws-app

2022-10-11 Thread GitBox
codecov[bot] commented on PR #21754: URL: https://github.com/apache/superset/pull/21754#issuecomment-1274266426 # [Codecov](https://codecov.io/gh/apache/superset/pull/21754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [superset] doornot commented on pull request #21641: fix(superset-embedded-sdk): Buffer is not defined

2022-10-11 Thread GitBox
doornot commented on PR #21641: URL: https://github.com/apache/superset/pull/21641#issuecomment-1274265426 hello @villebro, please help review. BTW, if this pr be approved and merged, will CI publish [@superset-ui/embedded-sdk](https://www.npmjs.com/package/@superset-ui/embedded-sdk)

[GitHub] [superset] dpgaspar merged pull request #21761: fix: flash message on database data upload forms

2022-10-11 Thread GitBox
dpgaspar merged PR #21761: URL: https://github.com/apache/superset/pull/21761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [superset] dependabot[bot] opened a new pull request, #21764: chore(deps-dev): bump @typescript-eslint/parser from 4.19.0 to 5.40.0 in /superset-websocket

2022-10-11 Thread GitBox
dependabot[bot] opened a new pull request, #21764: URL: https://github.com/apache/superset/pull/21764 Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.19.0 to 5.40.0. Release notes Sourced from https://githu

[GitHub] [superset] dependabot[bot] closed pull request #21692: chore(deps-dev): bump @typescript-eslint/parser from 4.19.0 to 5.39.0 in /superset-websocket

2022-10-11 Thread GitBox
dependabot[bot] closed pull request #21692: chore(deps-dev): bump @typescript-eslint/parser from 4.19.0 to 5.39.0 in /superset-websocket URL: https://github.com/apache/superset/pull/21692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [superset] dependabot[bot] commented on pull request #21692: chore(deps-dev): bump @typescript-eslint/parser from 4.19.0 to 5.39.0 in /superset-websocket

2022-10-11 Thread GitBox
dependabot[bot] commented on PR #21692: URL: https://github.com/apache/superset/pull/21692#issuecomment-1274230774 Superseded by #21764. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [superset] dependabot[bot] closed pull request #21730: chore(deps-dev): bump @types/node from 16.11.6 to 18.8.3 in /superset-websocket

2022-10-11 Thread GitBox
dependabot[bot] closed pull request #21730: chore(deps-dev): bump @types/node from 16.11.6 to 18.8.3 in /superset-websocket URL: https://github.com/apache/superset/pull/21730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [superset] dependabot[bot] opened a new pull request, #21763: chore(deps-dev): bump @types/node from 16.11.6 to 18.8.4 in /superset-websocket

2022-10-11 Thread GitBox
dependabot[bot] opened a new pull request, #21763: URL: https://github.com/apache/superset/pull/21763 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.11.6 to 18.8.4. Commits See full diff in https://github.com/DefinitelyType

[GitHub] [superset] dependabot[bot] commented on pull request #21730: chore(deps-dev): bump @types/node from 16.11.6 to 18.8.3 in /superset-websocket

2022-10-11 Thread GitBox
dependabot[bot] commented on PR #21730: URL: https://github.com/apache/superset/pull/21730#issuecomment-1274228234 Superseded by #21763. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [superset] github-actions[bot] commented on pull request #21438: perf(dashboard): Virtualization POC

2022-10-11 Thread GitBox
github-actions[bot] commented on PR #21438: URL: https://github.com/apache/superset/pull/21438#issuecomment-1274219928 @kgabryje Ephemeral environment spinning up at http://52.42.75.81:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. -- T