villebro commented on code in PR #22435:
URL: https://github.com/apache/superset/pull/22435#discussion_r1050452137
##
tests/integration_tests/db_engine_specs/trino_tests.py:
##
@@ -196,3 +198,17 @@ def test_convert_dttm(self):
TrinoEngineSpec.convert_dttm("DATE", dt
vivek-kandhvar commented on PR #21747:
URL: https://github.com/apache/superset/pull/21747#issuecomment-1354330917
Any update on this PR? Does it really fix the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
crazyisjen commented on PR #14688:
URL: https://github.com/apache/superset/pull/14688#issuecomment-1354304670
drill by is similar with cross-filter (drill-through)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
karschau commented on issue #2995:
URL: https://github.com/apache/superset/issues/2995#issuecomment-1354300339
> Is there any update on this feature? How can I export dashboard to pdf?
One way to get PDF reports might be this one:
https://github.com/TheHassi/superset-pdf-report
h
yashu183 commented on issue #22429:
URL: https://github.com/apache/superset/issues/22429#issuecomment-1354296276
Continuing our convo on slack,
I started `docker build .` on the master branch
https://user-images.githubusercontent.com/70622860/208039349-4761a36b-a4d4-4e2d-b681-483304
rusackas commented on issue #22393:
URL: https://github.com/apache/superset/issues/22393#issuecomment-1354250988
Out of curiosity, are you using a PC with Chrome? And did your table chart
have the "Show Totals" checkbox enabled? If so, I just merged a PR that _might_
fix this. Please check
rusackas closed issue #22429: docker build failed
URL: https://github.com/apache/superset/issues/22429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
rusackas commented on issue #22429:
URL: https://github.com/apache/superset/issues/22429#issuecomment-1354249779
Currently, I have to suspect that the changes you've made are somehow tied
into this problem. I've tested building the docker image on the latest `master`
and it seems to be work
rusackas commented on issue #22423:
URL: https://github.com/apache/superset/issues/22423#issuecomment-1354246659
Hopefully [this](https://preset.io/blog/building-database-connector/)
addresses your question. If not, please restate the question (with pertinent
additional details) in Discussi
rusackas closed issue #22423: How to add a private db_engine_specs outside of
superset code
URL: https://github.com/apache/superset/issues/22423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
github-actions[bot] commented on PR #21064:
URL: https://github.com/apache/superset/pull/21064#issuecomment-1354237063
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rusackas closed issue #21063: Total on Table Chart gets cut off on the
Dashboard if the Chart is re-sized
URL: https://github.com/apache/superset/issues/21063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rusackas merged PR #21064:
URL: https://github.com/apache/superset/pull/21064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
rusackas merged PR #22343:
URL: https://github.com/apache/superset/pull/22343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
RobertWan91 commented on issue #19909:
URL: https://github.com/apache/superset/issues/19909#issuecomment-1354145990
> Seems like the fix is to update the default values.yaml file with the
above changes
>
>
https://github.com/apache/superset/blob/4f9c2c8165ab5d875c14c7cd8e8585c78d4590
zhaoyongjie commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1050317634
##
superset-frontend/packages/superset-ui-chart-controls/src/utils/disabledSectionRules.ts:
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundati
zhaoyongjie commented on PR #22419:
URL: https://github.com/apache/superset/pull/22419#issuecomment-1354091832
Hi @geido, thanks for tackling this.
I think the Advanced Analytics section is not able to be entirely disable.
The AA section involves 3 parts that are Time Shit, Rolling,
betodealmeida merged PR #22432:
URL: https://github.com/apache/superset/pull/22432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
opqpop commented on issue #22393:
URL: https://github.com/apache/superset/issues/22393#issuecomment-1354033649
> @opqpop are you seeing this issue in Explore only, or in the Dashboard
view too?
>
> And is it happening with any other chart types, or just the Table?
ah sorry for
codecov[bot] commented on PR #22435:
URL: https://github.com/apache/superset/pull/22435#issuecomment-1354026822
#
[Codecov](https://codecov.io/gh/apache/superset/pull/22435?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
john-bodley opened a new pull request, #22435:
URL: https://github.com/apache/superset/pull/22435
### SUMMARY
This PR re-addresses some of the issues
https://github.com/apache/superset/pull/20729 tried to fix which was closed in
favor of https://github.com/apache/superset/pul
nytai commented on issue #19909:
URL: https://github.com/apache/superset/issues/19909#issuecomment-1353874237
Seems like the fix is to update the default values.yaml file with the above
changes
https://github.com/apache/superset/blob/4f9c2c8165ab5d875c14c7cd8e8585c78d45900f/helm/superset/va
michael-s-molina closed pull request #22434: fix: Removes duplicated Bar Chart
when GENERIC_CHART_AXES is enabled
URL: https://github.com/apache/superset/pull/22434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michael-s-molina commented on PR #22434:
URL: https://github.com/apache/superset/pull/22434#issuecomment-1353726623
Closed as it duplicates https://github.com/apache/superset/pull/22430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rusackas commented on PR #21642:
URL: https://github.com/apache/superset/pull/21642#issuecomment-1353725389
@villebro am I correct in interpreting this correctly as intersecting with
the refactor/DRYing conversation we had the other day?
--
This is an automated message from the Apache Git
michael-s-molina opened a new pull request, #22434:
URL: https://github.com/apache/superset/pull/22434
### SUMMARY
Removes duplicated `BarChart` when `GENERIC_CHART_AXES` feature flag is
enabled.
Follow-up of https://github.com/apache/superset/pull/22369
### BEFORE/AFTER SCR
rusackas commented on issue #19384:
URL: https://github.com/apache/superset/issues/19384#issuecomment-1353721885
Hi there, and thanks for starting this conversation. I have a handful of
questions:
* This doesn't sound like a bug, but rather a feature request... do you mind
if I migrate t
josechudev commented on issue #22290:
URL: https://github.com/apache/superset/issues/22290#issuecomment-1353711373
@parkjiyeon0 I finally solved it by reinstalling gunicorn in the
bootstrapScript.and adding AUTH_LDAP_ALLOW_SELF_SIGNED= True to my ldap config.
You can check the config
[here
sfirke commented on issue #21694:
URL: https://github.com/apache/superset/issues/21694#issuecomment-1353710170
I agree with all of that and yes, there's not a bug here that needs patching
on master. My only concern with closing is this getting lost in the shuffle
when it comes to planning
codecov[bot] commented on PR #22433:
URL: https://github.com/apache/superset/pull/22433#issuecomment-1353703562
#
[Codecov](https://codecov.io/gh/apache/superset/pull/22433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
rusackas commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353702216
> @rusackas According to this
[article](https://ux.shopify.com/how-to-concatenate-localized-strings-mindfully-bcc7b6d4961a)
it seems sometimes the punctuation could also be translated
craig-rueda commented on code in PR #22433:
URL: https://github.com/apache/superset/pull/22433#discussion_r1050130763
##
superset/extensions/__init__.py:
##
@@ -109,6 +111,31 @@ def init_app(self, app: Flask) -> None:
app.wsgi_app = SupersetProfiler(app.wsgi_app, self.i
craig-rueda commented on code in PR #22433:
URL: https://github.com/apache/superset/pull/22433#discussion_r1050130172
##
superset/extensions/__init__.py:
##
@@ -109,6 +111,31 @@ def init_app(self, app: Flask) -> None:
app.wsgi_app = SupersetProfiler(app.wsgi_app, self.i
craig-rueda commented on code in PR #22433:
URL: https://github.com/apache/superset/pull/22433#discussion_r1050129654
##
superset/extensions/__init__.py:
##
@@ -109,6 +111,31 @@ def init_app(self, app: Flask) -> None:
app.wsgi_app = SupersetProfiler(app.wsgi_app, self.i
craig-rueda commented on code in PR #22433:
URL: https://github.com/apache/superset/pull/22433#discussion_r1050129327
##
superset/extensions/__init__.py:
##
@@ -109,6 +111,31 @@ def init_app(self, app: Flask) -> None:
app.wsgi_app = SupersetProfiler(app.wsgi_app, self.i
hug opened a new pull request, #22433:
URL: https://github.com/apache/superset/pull/22433
### SUMMARY
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] R
michael-s-molina commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353686047
@rusackas According to this
[article](https://ux.shopify.com/how-to-concatenate-localized-strings-mindfully-bcc7b6d4961a)
it seems sometimes the punctuation could also be tran
rusackas commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1353673710
Do we still have build/ephemeral concerns here, or is this ready for the
final once-over?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
rusackas commented on PR #22426:
URL: https://github.com/apache/superset/pull/22426#issuecomment-1353671588
Can you please explain what exactly you're trying to test or add here?
Tempted to close this for lack of context. CI won't run without a committer
granting approval, so if you are ind
codyml commented on code in PR #22430:
URL: https://github.com/apache/superset/pull/22430#discussion_r1050107730
##
superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/index.js:
##
@@ -35,7 +35,7 @@ const metadata = new ChartMetadata({
{ url: example2, caption: '
rusackas commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353669872
This generally looks good to me! I added a couple clarifying questions. In
general, there seems like only one real pint of contention, which is that I'm
not sure we want to include th
john-bodley merged PR #22431:
URL: https://github.com/apache/superset/pull/22431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
michael-s-molina commented on code in PR #22302:
URL: https://github.com/apache/superset/pull/22302#discussion_r1050100586
##
superset-frontend/src/views/CRUD/utils.tsx:
##
@@ -442,3 +438,64 @@ export const uploadUserPerms = (
canUploadData: canUploadCSV || canUploadColumna
codecov[bot] commented on PR #22432:
URL: https://github.com/apache/superset/pull/22432#issuecomment-1353645226
#
[Codecov](https://codecov.io/gh/apache/superset/pull/22432?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
betodealmeida opened a new pull request, #22432:
URL: https://github.com/apache/superset/pull/22432
### SUMMARY
Set a user agent header in the Snowflake DB Engine Spec indicating the
request is coming from Superset.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
geido commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1050055456
##
superset-frontend/packages/superset-ui-chart-controls/src/utils/disabledSectionRules.ts:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
craig-rueda commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1050054331
##
superset/models/core.py:
##
@@ -66,6 +66,7 @@
from superset.utils.memoized import memoized
config = app.config
+ssh_manager = config["SSH_TUNNEL_MANAGER"]
geido commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1050048246
##
superset-frontend/packages/superset-ui-chart-controls/src/utils/disabledSectionRules.ts:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
geido commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1050041079
##
superset-frontend/packages/superset-ui-chart-controls/src/utils/disabledSectionRules.ts:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
hug merged PR #22201:
URL: https://github.com/apache/superset/pull/22201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@s
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050033474
##
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/Polygon.jsx:
##
@@ -57,7 +58,7 @@ function setTooltipContent(formData) {
return (
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050032807
##
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Scatter/Scatter.jsx:
##
@@ -36,14 +36,11 @@ function setTooltipContent(formData, verboseMap) {
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050028008
##
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx:
##
@@ -224,9 +224,12 @@ export class Tabs extends React.PureComponent {
title: t('Dele
michael-s-molina commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1050023907
##
superset-frontend/packages/superset-ui-chart-controls/src/utils/disabledSectionRules.ts:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Fou
john-bodley commented on PR #21066:
URL: https://github.com/apache/superset/pull/21066#issuecomment-1353540898
@villebro understood. I'm 50/50 about whether option 1 or 2 is the preferred
solution. Option 1 might be easiest for now (conditional on how coupled the
logic is with the DB-API),
villebro commented on PR #21066:
URL: https://github.com/apache/superset/pull/21066#issuecomment-1353537469
@john-bodley the problem is that PyHive and the new Trino connector are
diverging at a rapid pace right now, so extending the Trino spec from the old
Presto spec is IMO not a good ide
villebro commented on PR #22431:
URL: https://github.com/apache/superset/pull/22431#issuecomment-1353533052
@john-bodley I've run into several problems with mypy lately where it's not
picking up trivial typing errors. I wasn't able to look into it more closely,
but I did try bumping mypy lo
yashu183 commented on issue #22428:
URL: https://github.com/apache/superset/issues/22428#issuecomment-1353527228
Hii,
I am running the build in the master branch
https://user-images.githubusercontent.com/70622860/207938266-f5a7d8f8-e2da-41e2-858a-a2fb74e3d1c7.png";>
Its getting stopp
geido commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1050001848
##
superset-frontend/packages/superset-ui-chart-controls/src/utils/disabledSectionRules.ts:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
eschutho commented on issue #21984:
URL: https://github.com/apache/superset/issues/21984#issuecomment-1353523832
This should be fixed for 2.0.1. Closing the issue, but feel to reopen if you
find it again while testing.
--
This is an automated message from the Apache Git Service.
To respo
eschutho closed issue #21984: Upgrading from 2.0.0 to 2.0.1rc2 causes an error
when setting owner and roles on dashboard
URL: https://github.com/apache/superset/issues/21984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
betodealmeida commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1049992181
##
superset/databases/ssh_tunnel/models.py:
##
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
betodealmeida commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1049990722
##
superset/databases/ssh_tunnel/models.py:
##
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
betodealmeida commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1049990722
##
superset/databases/ssh_tunnel/models.py:
##
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
betodealmeida commented on code in PR #21912:
URL: https://github.com/apache/superset/pull/21912#discussion_r1049990118
##
superset/databases/ssh_tunnel/models.py:
##
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1049987972
##
superset-frontend/src/views/CRUD/annotation/AnnotationList.tsx:
##
@@ -259,9 +259,11 @@ function AnnotationList({
{t('Annotation Layer %s', annotati
codecov[bot] commented on PR #22431:
URL: https://github.com/apache/superset/pull/22431#issuecomment-1353504801
#
[Codecov](https://codecov.io/gh/apache/superset/pull/22431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
codecov[bot] commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353504371
#
[Codecov](https://codecov.io/gh/apache/superset/pull/22150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
john-bodley commented on code in PR #22431:
URL: https://github.com/apache/superset/pull/22431#discussion_r1049983081
##
superset/db_engine_specs/hive.py:
##
@@ -225,22 +225,23 @@ def _get_hive_type(dtype: np.dtype) -> str:
) as file:
pq.write_table(pa.Tabl
john-bodley opened a new pull request, #22431:
URL: https://github.com/apache/superset/pull/22431
### SUMMARY
I thought both Pylint would have detected a "Local variable referenced
before assignment" error, but maybe the if/context manager logic was simply too
complex, as wel
github-actions[bot] commented on PR #21728:
URL: https://github.com/apache/superset/pull/21728#issuecomment-1353497914
@AAfghahi Ephemeral environment spinning up at http://54.201.189.253:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
AAfghahi commented on PR #21728:
URL: https://github.com/apache/superset/pull/21728#issuecomment-1353492909
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
rusackas commented on issue #21694:
URL: https://github.com/apache/superset/issues/21694#issuecomment-1353490490
Thanks for the detective work @sfirke - if I'm understanding correctly, and
this is fixed on `latest` then this is good news... it should be in line for
2.1.0, and it may be poss
yashu183 commented on issue #22429:
URL: https://github.com/apache/superset/issues/22429#issuecomment-1353483943
No,
I jst want to download chart as xlsx instead of csv
This is the only thing I have changed
--
This is an automated message from the Apache Git Service.
To respond to th
codecov[bot] commented on PR #22430:
URL: https://github.com/apache/superset/pull/22430#issuecomment-1353477965
#
[Codecov](https://codecov.io/gh/apache/superset/pull/22430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof
Paulo456 commented on issue #17076:
URL: https://github.com/apache/superset/issues/17076#issuecomment-1353471735
the problem is in the image of the js node. To fix it, you need to fix
version nodejs . to do that u need to fix the file docker/docker-frontend.sh
like this:
.
apt ins
rusackas commented on issue #22429:
URL: https://github.com/apache/superset/issues/22429#issuecomment-1353471131
In your [other issue](https://github.com/apache/superset/issues/22428) you
said you were building a custom image. Is there anything particularly custom
you've done with Superset
majkinetor commented on issue #22326:
URL: https://github.com/apache/superset/issues/22326#issuecomment-1353465689
Thanks for reopening this.
> That new users are directed to deploy latest - which changes multiple
times per day - is a problem
I understand your point, but on th
villebro commented on code in PR #22430:
URL: https://github.com/apache/superset/pull/22430#discussion_r1049956480
##
superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/index.js:
##
@@ -35,7 +35,7 @@ const metadata = new ChartMetadata({
{ url: example2, caption:
rusackas commented on issue #22428:
URL: https://github.com/apache/superset/issues/22428#issuecomment-1353465474
OK, docker build is a separate process, so we'll focus on the npm (webpack,
frontend) builds first. Can you give this issue a more descriptive/specific
title and let us know spec
villebro commented on code in PR #22302:
URL: https://github.com/apache/superset/pull/22302#discussion_r1049949972
##
superset/config.py:
##
@@ -1420,6 +1421,17 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"port": internet_port,
}
+# By d
michael-s-molina commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1049948355
##
superset-frontend/src/explore/components/ControlPanelSection.tsx:
##
@@ -0,0 +1,206 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under on
craig-rueda commented on code in PR #21873:
URL: https://github.com/apache/superset/pull/21873#discussion_r1049943794
##
superset/utils/log.py:
##
@@ -352,3 +355,71 @@ def log( # pylint:
disable=too-many-arguments,too-many-locals
except SQLAlchemyError as ex:
codyml commented on code in PR #22419:
URL: https://github.com/apache/superset/pull/22419#discussion_r1049944249
##
superset-frontend/src/explore/components/ControlPanelSection.tsx:
##
@@ -0,0 +1,206 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
rusackas commented on issue #22385:
URL: https://github.com/apache/superset/issues/22385#issuecomment-1353438778
I might be a little confused here...
If the fix you are seeking is already incorporated into `master`, then the
work is done and we should close this issue (a link here wo
villebro commented on code in PR #22302:
URL: https://github.com/apache/superset/pull/22302#discussion_r1049941568
##
superset-frontend/src/views/CRUD/utils.tsx:
##
@@ -442,3 +438,64 @@ export const uploadUserPerms = (
canUploadData: canUploadCSV || canUploadColumnar || can
villebro commented on code in PR #22302:
URL: https://github.com/apache/superset/pull/22302#discussion_r1049940155
##
superset-frontend/src/utils/getBootstrapData.ts:
##
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
villebro commented on code in PR #22302:
URL: https://github.com/apache/superset/pull/22302#discussion_r1049938716
##
superset-frontend/src/dashboard/util/findTabIndexByComponentId.test.js:
##
@@ -4,7 +4,7 @@
* distributed with this work for additional information
* regardin
rusackas commented on PR #22421:
URL: https://github.com/apache/superset/pull/22421#issuecomment-1353428016
Thanks for catching this! These things add up!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rusackas commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1353401212
A lot of folks have wanted this feature for _years_, so there's been
input/inspiration from numerous sources. A lot of conversation has been
happening in various open fora, inclu
sfirke commented on issue #22393:
URL: https://github.com/apache/superset/issues/22393#issuecomment-1353400853
Thanks for reporting this, I had meant to. A teammate and I can both
reproduce it on some of our charts. We opened the developer tools in the
browser (Chrome and Firefox) and cou
sfirke commented on issue #22326:
URL: https://github.com/apache/superset/issues/22326#issuecomment-1353395633
> Solution is then not a fix for me, as I reverted to latest stable just
because of this, and given that we based our recent work on latest master, as I
think is recommended in the
codyml opened a new pull request, #22430:
URL: https://github.com/apache/superset/pull/22430
### SUMMARY
As a follow-up to https://github.com/apache/superset/pull/22369, this PR
renames the legacy non-time-series Bar Chart to Bar Chart (legacy). There is
both a legacy Bar Ch
yashu183 commented on issue #22428:
URL: https://github.com/apache/superset/issues/22428#issuecomment-1353392677
Hii @rusackas
Thanks for the reply
Yeah, builds are failing even when I run `docker build .` to build my custom
image, it's failing on `npm run build`
I am already t
rusackas commented on issue #22326:
URL: https://github.com/apache/superset/issues/22326#issuecomment-1353383148
Related things seem to warrant investigation:
* https://github.com/apache/superset/pull/21995
* https://github.com/apache/superset/issues/22099
* https://github.com/apache
rusackas commented on issue #22326:
URL: https://github.com/apache/superset/issues/22326#issuecomment-1353379525
> That said, I think you are right that this will need to get fixed on the
master branch. @rusackas What do you think? Should a new issue be opened for
this?
No problem re
rusackas commented on issue #22428:
URL: https://github.com/apache/superset/issues/22428#issuecomment-1353368113
@yashu183 there's definitely a LOT of noise in there, for sure. As for the
linting, they're all basically warnings that we're chipping away at as
technical debt, but they should
majkinetor commented on issue #22326:
URL: https://github.com/apache/superset/issues/22326#issuecomment-1353367966
Solution is then not a fix for me, as I reverted to latest stable just
because of this, and given that we based our recent work on latest master, as I
think is recommended in t
rusackas commented on PR #22409:
URL: https://github.com/apache/superset/pull/22409#issuecomment-1353362414
@wanghong1314 did you mean to close this out?
CC-ing @eschutho / @yousoph to check this out and see if there's a fix here
that we want to adopt.
--
This is an automated mes
sfirke commented on issue #22326:
URL: https://github.com/apache/superset/issues/22326#issuecomment-1353359892
> Why is this closed as fixed if the solution is installing older version ?
Most of the time people reporting errors in Alerts & Reports are better
served by running the late
1 - 100 of 116 matches
Mail list logo
