Re: [PR] refactor: add "button" role to clickable UI elements for improved accessibility [superset]

2024-04-01 Thread via GitHub
github-actions[bot] commented on PR #26602: URL: https://github.com/apache/superset/pull/26602#issuecomment-2031185277 @geido Ephemeral environment spinning up at http://34.218.74.195:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. -- Th

Re: [PR] refactor: add "button" role to clickable UI elements for improved accessibility [superset]

2024-04-01 Thread via GitHub
geido commented on PR #26602: URL: https://github.com/apache/superset/pull/26602#issuecomment-2031171927 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [I] Cannot set color scheme for dashboard-associated chart even when dashboard color scheme is cleared [superset]

2024-04-01 Thread via GitHub
hk-the-analyst commented on issue #23874: URL: https://github.com/apache/superset/issues/23874#issuecomment-2031135611 We are also facing the same issue- Everytime we refresh the dashboard- The chart color is getting changed- We tried clearing the color scheme of Dashboard but it is not ge

Re: [PR] feat: Slack Avatar integration [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27849: URL: https://github.com/apache/superset/pull/27849#issuecomment-2031092195 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27849?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [PR] feat: Slack Avatar integration [superset]

2024-04-01 Thread via GitHub
mistercrunch commented on code in PR #27849: URL: https://github.com/apache/superset/pull/27849#discussion_r1547136207 ## superset/dashboards/api.py: ## @@ -179,6 +179,9 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]: "owners.id", "owners.first_na

Re: [PR] feat: Slack Avatar integration [superset]

2024-04-01 Thread via GitHub
mistercrunch commented on code in PR #27849: URL: https://github.com/apache/superset/pull/27849#discussion_r1547131639 ## docker/pythonpath_dev/superset_config.py: ## @@ -99,6 +99,7 @@ class CeleryConfig: WEBDRIVER_BASEURL_USER_FRIENDLY = WEBDRIVER_BASEURL SQLLAB_CTAS_NO_LIM

Re: [PR] feat: Slack Avatar integration [superset]

2024-04-01 Thread via GitHub
mistercrunch commented on code in PR #27849: URL: https://github.com/apache/superset/pull/27849#discussion_r1547130615 ## .gitignore: ## @@ -110,5 +110,6 @@ release.json messages.mo docker/requirements-local.txt +docker/.env-local Review Comment: Note: I was working with

[PR] feat: Slack Avatar integration [superset]

2024-04-01 Thread via GitHub
mistercrunch opened a new pull request, #27849: URL: https://github.com/apache/superset/pull/27849 ### SUMMARY Our current Avatars are a little dry, using a limited variety of colors and showing the user's initials. The app could use a little more personality. Now given we alr

Re: [I] the feature 'Querying across databases' doesn't work [superset]

2024-04-01 Thread via GitHub
GauravJain98 commented on issue #25522: URL: https://github.com/apache/superset/issues/25522#issuecomment-2031023717 @nevotheless i found this issue and fixed this bug later this might help you https://superset.apache.org/docs/installation/running-on-kubernetes/#superset_configpy -- T

Re: [PR] feat(db): Adding DB_ENGINE_URI_VALIDATOR [superset]

2024-04-01 Thread via GitHub
betodealmeida commented on PR #27847: URL: https://github.com/apache/superset/pull/27847#issuecomment-2030995464 Yeah, in general there are two parts: engine = create_engine(uri, **params) Both are needed for a full connection, since in some cases the params are too big to buil

Re: [PR] feat(db): Adding DB_ENGINE_URI_VALIDATOR [superset]

2024-04-01 Thread via GitHub
mistercrunch commented on PR #27847: URL: https://github.com/apache/superset/pull/27847#issuecomment-2030992466 I think the bigger exception is the way we do BigQuery for instance cramming many things into a blob, but unclear how common/uncommon it is. This probably a good starting point. C

Re: [PR] chore(🦾): bump python flask-session 0.5.0 -> 0.8.0 [superset]

2024-04-01 Thread via GitHub
mistercrunch merged PR #27751: URL: https://github.com/apache/superset/pull/27751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] feat(db): Adding DB_ENGINE_URI_VALIDATOR [superset]

2024-04-01 Thread via GitHub
craig-rueda commented on PR #27847: URL: https://github.com/apache/superset/pull/27847#issuecomment-2030982198 Aren't all of the connection attributes captured in the parsed url? Also, this is intended to be invoked pre-connect, so we likely wouldn't want to perform validations on a "connec

Re: [PR] chore: Default to engine specification regarding using wildcard [superset]

2024-04-01 Thread via GitHub
john-bodley commented on PR #27843: URL: https://github.com/apache/superset/pull/27843#issuecomment-2030920224 After further research I opted to close this. There’s some weird patterns we use, especially given that the function arguments seem over prescribed. -- This is an automated messa

Re: [PR] chore: Default to engine specification regarding using wildcard [superset]

2024-04-01 Thread via GitHub
john-bodley closed pull request #27843: chore: Default to engine specification regarding using wildcard URL: https://github.com/apache/superset/pull/27843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[I] Invalid login is shown even if the right credentials are provided for a superset. [superset]

2024-04-01 Thread via GitHub
jemyalphonsjogy opened a new issue, #27848: URL: https://github.com/apache/superset/issues/27848 ### Bug description Invalid login is shown even if the right credentials are provided for a superset when superset is installed via a shell script ### How to reproduce the bug

Re: [PR] feat(db): Adding DB_ENGINE_URI_VALIDATOR [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27847: URL: https://github.com/apache/superset/pull/27847#issuecomment-2030786537 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27847?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[PR] feat(db): Adding DB_ENGINE_URI_VALIDATOR [superset]

2024-04-01 Thread via GitHub
craig-rueda opened a new pull request, #27847: URL: https://github.com/apache/superset/pull/27847 ### SUMMARY Quick PR that adds a new callback hook, `DB_ENGINE_URI_VALIDATOR` which can be optionally set in Superset configs. When set, it should point to a callable that is invoked in orde

Re: [PR] fix: alembic's 'superset db migate' fails with CompileError [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27846: URL: https://github.com/apache/superset/pull/27846#issuecomment-2030552250 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27846?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[PR] fix: alembic's 'superset db migate' fails with CompileError [superset]

2024-04-01 Thread via GitHub
mistercrunch opened a new pull request, #27846: URL: https://github.com/apache/superset/pull/27846 When running on the latest `master` running a simple `superset db migrate` to generate a new database migration fails with error ``` sqlalchemy.exc.CompileError: PostgreSQL ENUM

Re: [PR] fix(dashboard): missing null check in error extra [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27845: URL: https://github.com/apache/superset/pull/27845#issuecomment-2030526207 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27845?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [PR] fix(chart): Sort By (Backend sorting) [superset]

2024-04-01 Thread via GitHub
sfirke commented on PR #27616: URL: https://github.com/apache/superset/pull/27616#issuecomment-2030525521 I will try this out, hopefully this week. @nelsondrew are you able to add test(s) for this PR? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Some permissions seem unnecessary because they are associated with essential functions [superset]

2024-04-01 Thread via GitHub
goldjee commented on issue #27765: URL: https://github.com/apache/superset/issues/27765#issuecomment-2030523309 Yep, the whole permission system feels very clunky and too raw to manage. If a permission is necessary to be granted for a user to actually use the system, it should not be listed

[PR] fix(dashboard): missing null check in error extra [superset]

2024-04-01 Thread via GitHub
justinpark opened a new pull request, #27845: URL: https://github.com/apache/superset/pull/27845 ### SUMMARY As titled, this commit includes a null check for the extra value. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: ![Screenshot 2024-04-01 at 1 01 25  PM](h

Re: [PR] chore: Default to engine specification regarding using wildcard [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27843: URL: https://github.com/apache/superset/pull/27843#issuecomment-2030400024 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27843?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [PR] chore: bump python version to 3.11 in Dockerfile [superset]

2024-04-01 Thread via GitHub
mistercrunch commented on PR #23804: URL: https://github.com/apache/superset/pull/23804#issuecomment-2030392639 Closing this in favor or https://github.com/apache/superset/pull/24112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] chore: bump python version to 3.11 in Dockerfile [superset]

2024-04-01 Thread via GitHub
mistercrunch closed pull request #23804: chore: bump python version to 3.11 in Dockerfile URL: https://github.com/apache/superset/pull/23804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] chore: Default to engine specification regarding using wildcard [superset]

2024-04-01 Thread via GitHub
john-bodley opened a new pull request, #27843: URL: https://github.com/apache/superset/pull/27843 ### SUMMARY The `BaseEngineSpec.select_star` method provides an option (with a default) with regards to whether or not one should use a wildcard (`show_cols=False`) or enumerate

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina merged PR #27441: URL: https://github.com/apache/superset/pull/27441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

Re: [PR] chore(sql_parse): Strip leading/trailing whitespace in Jinja macro extraction [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27842: URL: https://github.com/apache/superset/pull/27842#issuecomment-2030347464 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27842?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[PR] chore(sql_parse): Strip leading/trailing whitespace in Jinja macro extraction [superset]

2024-04-01 Thread via GitHub
john-bodley opened a new pull request, #27842: URL: https://github.com/apache/superset/pull/27842 ### SUMMARY It seems like it's not uncommon for users to use the `latest[_sub]_partition` Jinja macros wrongly in terms of including a leading or trailing whitespace, i.e., `late

Re: [I] [SIP-121] Proposal for Metrics Comparison base on the Temporal Dimension or/and Textual Dimension [superset]

2024-04-01 Thread via GitHub
zhaoyongjie commented on issue #27544: URL: https://github.com/apache/superset/issues/27544#issuecomment-2030284790 @betodealmeida If the different data slices would be filtered in datasource, we have to filter the `time filter` + `time delta` in the datasource. different database h

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546654037 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Sup

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546650877 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Sup

Re: [I] [SIP-121] Proposal for Metrics Comparison base on the Temporal Dimension or/and Textual Dimension [superset]

2024-04-01 Thread via GitHub
betodealmeida commented on issue #27544: URL: https://github.com/apache/superset/issues/27544#issuecomment-2030214425 > However, I am stuck on how to generate an appropriate time expression that contains time delta, as the time delta expression varies in different databases. @zhaoyong

Re: [I] [Regression] ECharts rows count indicator pill is lying [superset]

2024-04-01 Thread via GitHub
yousoph commented on issue #26402: URL: https://github.com/apache/superset/issues/26402#issuecomment-2030200584 https://github.com/apache/superset/pull/27700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546605352 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] fix: row limits & row count labels are confusing [superset]

2024-04-01 Thread via GitHub
github-actions[bot] commented on PR #27700: URL: https://github.com/apache/superset/pull/27700#issuecomment-2030160886 @eschutho Ephemeral environment spinning up at http://35.162.20.252:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. --

[PR] build: fixed pkg-config dependency in Dockerfile [superset]

2024-04-01 Thread via GitHub
goldjee opened a new pull request, #27841: URL: https://github.com/apache/superset/pull/27841 ### SUMMARY Fixed inability to build Docker image as described in issue [#27792](https://github.com/apache/superset/issues/27792) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ##

Re: [PR] fix: status 500 thrown when creating a dataset due to invalid sql [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27796: URL: https://github.com/apache/superset/pull/27796#issuecomment-2030152437 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27796?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [PR] fix: row limits & row count labels are confusing [superset]

2024-04-01 Thread via GitHub
eschutho commented on PR #27700: URL: https://github.com/apache/superset/pull/27700#issuecomment-2030147539 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] fix: status 500 thrown when creating a dataset due to invalid sql [superset]

2024-04-01 Thread via GitHub
john-bodley commented on PR #27796: URL: https://github.com/apache/superset/pull/27796#issuecomment-2030143891 Thanks @jzhao62 for the PR. Would you mind also adding some unit tests to prevent potential future regressions? -- This is an automated message from the Apache Git Service. To re

Re: [PR] chore(🦾): bump python simplejson 3.17.3 -> 3.19.2 [superset]

2024-04-01 Thread via GitHub
mistercrunch merged PR #27757: URL: https://github.com/apache/superset/pull/27757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546560527 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Sup

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546557847 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Sup

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546543511 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546505055 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546538634 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546505055 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546534738 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Sup

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546533786 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Sup

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546487688 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] chore: Adds the 4.0 release notes [superset]

2024-04-01 Thread via GitHub
sfirke commented on code in PR #27441: URL: https://github.com/apache/superset/pull/27441#discussion_r1546400137 ## RELEASING/release-notes-4-0/README.md: ## @@ -0,0 +1,151 @@ + + +# Release Notes for Superset 4.0.0 + +4.0.0 brings a plethora of exciting changes to Superset. We

Re: [PR] chore: Bump to Python3.10 [superset]

2024-04-01 Thread via GitHub
EugeneTorap commented on code in PR #24112: URL: https://github.com/apache/superset/pull/24112#discussion_r1546409398 ## setup.py: ## @@ -208,13 +208,12 @@ def get_git_sha() -> str: "starrocks": ["starrocks>=1.0.0"], "doris": ["pydoris>=1.0.0, <2.0.0"], },

Re: [PR] chore: Updates translation owners [superset]

2024-04-01 Thread via GitHub
michael-s-molina merged PR #27839: URL: https://github.com/apache/superset/pull/27839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[PR] feat: new CSV upload form and API [superset]

2024-04-01 Thread via GitHub
dpgaspar opened a new pull request, #27840: URL: https://github.com/apache/superset/pull/27840 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ]

[PR] chore: Updates translation owners [superset]

2024-04-01 Thread via GitHub
michael-s-molina opened a new pull request, #27839: URL: https://github.com/apache/superset/pull/27839 ### SUMMARY Removes myself from the translation owners. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Incl

Re: [PR] Legend scroll echarts [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on PR #27766: URL: https://github.com/apache/superset/pull/27766#issuecomment-2029626449 > @michael-s-molina Thats what i am trying to do here ... but i am unable to remove that behaviour of scroll state getting reset ... is this behaviour in any way built into ec

Re: [PR] chore: Bump to Python3.10 [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #24112: URL: https://github.com/apache/superset/pull/24112#discussion_r1546238396 ## setup.py: ## @@ -208,13 +208,12 @@ def get_git_sha() -> str: "starrocks": ["starrocks>=1.0.0"], "doris": ["pydoris>=1.0.0, <2.0.0"],

Re: [PR] chore: Bump to Python3.10 [superset]

2024-04-01 Thread via GitHub
michael-s-molina commented on code in PR #24112: URL: https://github.com/apache/superset/pull/24112#discussion_r1546236836 ## setup.py: ## @@ -208,13 +208,12 @@ def get_git_sha() -> str: "starrocks": ["starrocks>=1.0.0"], "doris": ["pydoris>=1.0.0, <2.0.0"],

Re: [I] Sort by is not working for Pivot Table and Pivot Table V2 chart [superset]

2024-04-01 Thread via GitHub
liany-dropit commented on issue #23353: URL: https://github.com/apache/superset/issues/23353#issuecomment-2029586687 We have the same issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] While exporting CSV , only the entries on first page are getting downloaded even when user is on other pages [superset]

2024-04-01 Thread via GitHub
gstamatakiswxm commented on issue #17861: URL: https://github.com/apache/superset/issues/17861#issuecomment-2029586972 This is still an issue for me on 3.1.0, when pagination is enabled only the first page is downloaded even if the 'ALLOW_FULL_CSV_EXPORT' flag has been enables. -- This i

Re: [I] Time series query broken [superset]

2024-04-01 Thread via GitHub
zhaoyongjie commented on issue #27798: URL: https://github.com/apache/superset/issues/27798#issuecomment-2029580066 @jzhao62 I totally agree with you. Ideally, the explicit typing conversion should be applied on the temporal column if explicitly defined a column as datetime/date/timestamp.

Re: [I] Time series query broken [superset]

2024-04-01 Thread via GitHub
jzhao62 commented on issue #27798: URL: https://github.com/apache/superset/issues/27798#issuecomment-2029514701 hey @zhaoyongjie thanks, i dont know if this situation applies to all time series data or not. If we explicilty cast the timestamp when generating sql on UI, would it be a problem

[I] port 5432 failed: FATAL: password authentication failed for user [superset]

2024-04-01 Thread via GitHub
JunseoChoJJ opened a new issue, #27838: URL: https://github.com/apache/superset/issues/27838 ### Bug description I am working on installing superset on kubernetes. I have my own postgresql so my postgresql line 770 enable is false as well I got this issue when I'm running hel

Re: [PR] fix: status 500 thrown when creating a dataset due to invalid sql [superset]

2024-04-01 Thread via GitHub
qleroy commented on PR #27796: URL: https://github.com/apache/superset/pull/27796#issuecomment-2029466413 Tested on my dev setup and confirm the Fatal error is turned into a Dataset could not be created. error. This is also a first step towards resolving #25786. -- This is an autom

Re: [I] Time series query broken [superset]

2024-04-01 Thread via GitHub
zhaoyongjie commented on issue #27798: URL: https://github.com/apache/superset/issues/27798#issuecomment-2029457693 Hey @jzhao62, there is no column typing convert logic in current time grain expression so the TIMESTAMP column should have to be offered. The quick and dirty workaround to cre

Re: [I] pkg-config not found on docker compose build [superset]

2024-04-01 Thread via GitHub
davionchai commented on issue #27792: URL: https://github.com/apache/superset/issues/27792#issuecomment-2029378508 had the same issue, what i did was adding pkg-config after line 121 [here](https://github.com/apache/superset/blob/master/Dockerfile#L121) ``` ... libxtst6

Re: [PR] build(deps-dev): bump @types/redux-mock-store from 1.0.2 to 1.0.6 in /superset-frontend [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27836: URL: https://github.com/apache/superset/pull/27836#issuecomment-2029374996 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27836?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [PR] build(deps): bump remark-gfm from 3.0.1 to 4.0.0 in /superset-frontend/packages/superset-ui-core [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27832: URL: https://github.com/apache/superset/pull/27832#issuecomment-2029369873 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27832?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [I] password authentication failed for user "superset" [superset]

2024-04-01 Thread via GitHub
JunseoChoJJ commented on issue #24268: URL: https://github.com/apache/superset/issues/24268#issuecomment-2029360380 @julianofischer what do you mean by 2db s? I am struggling with this problem too. Could you give me more details that how you solve? -- This is an automated message from

[PR] build(deps): bump d3 from 3.5.17 to 7.9.0 in /superset-frontend/plugins/legacy-plugin-chart-heatmap [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27837: URL: https://github.com/apache/superset/pull/27837 Bumps [d3](https://github.com/d3/d3) from 3.5.17 to 7.9.0. Release notes Sourced from https://github.com/d3/d3/releases";>d3's releases. v7.9.0 Add d3.schemeObservabl

[PR] build(deps-dev): bump @types/redux-mock-store from 1.0.2 to 1.0.6 in /superset-frontend [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27836: URL: https://github.com/apache/superset/pull/27836 Bumps [@types/redux-mock-store](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/redux-mock-store) from 1.0.2 to 1.0.6. Commits See full diff in https://gith

[PR] build(deps): bump remark-gfm from 3.0.1 to 4.0.0 in /superset-frontend/packages/superset-ui-core [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27832: URL: https://github.com/apache/superset/pull/27832 Bumps [remark-gfm](https://github.com/remarkjs/remark-gfm) from 3.0.1 to 4.0.0. Release notes Sourced from https://github.com/remarkjs/remark-gfm/releases";>remark-gfm's releases.

Re: [PR] build(deps-dev): bump react-test-renderer from 16.9.0 to 16.14.0 in /superset-frontend [superset]

2024-04-01 Thread via GitHub
codecov[bot] commented on PR #27808: URL: https://github.com/apache/superset/pull/27808#issuecomment-2029338256 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27808?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[PR] build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27835: URL: https://github.com/apache/superset/pull/27835 Updates the requirements on [xss](https://github.com/leizongmin/js-xss) to permit the latest version. Changelog Sourced from https://github.com/leizongmin/js-xss/blob/master/CHANGE

[PR] build(deps): bump math-expression-evaluator from 1.4.0 to 2.0.5 in /superset-frontend/packages/superset-ui-core [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27834: URL: https://github.com/apache/superset/pull/27834 Bumps [math-expression-evaluator](https://github.com/redhivesoftware/math-expression-evaluator) from 1.4.0 to 2.0.5. Release notes Sourced from https://github.com/redhivesoftware/

[PR] build(deps): update @types/react-table requirement from ^7.7.19 to ^7.7.20 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27833: URL: https://github.com/apache/superset/pull/27833 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: #

[PR] build(deps): update @types/fetch-mock requirement from ^7.3.3 to ^7.3.8 in /superset-frontend/packages/superset-ui-core [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27831: URL: https://github.com/apache/superset/pull/27831 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: #

[PR] build(deps-dev): bump yeoman-test from 6.2.0 to 8.2.0 in /superset-frontend [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27830: URL: https://github.com/apache/superset/pull/27830 Bumps [yeoman-test](https://github.com/yeoman/yeoman-test) from 6.2.0 to 8.2.0. Release notes Sourced from https://github.com/yeoman/yeoman-test/releases";>yeoman-test's releases.

[PR] build(deps): bump d3 from 3.5.17 to 7.9.0 in /superset-frontend/plugins/legacy-plugin-chart-partition [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27829: URL: https://github.com/apache/superset/pull/27829 Bumps [d3](https://github.com/d3/d3) from 3.5.17 to 7.9.0. Release notes Sourced from https://github.com/d3/d3/releases";>d3's releases. v7.9.0 Add d3.schemeObservabl

[PR] build(deps): bump d3 from 3.5.17 to 7.9.0 in /superset-frontend/plugins/legacy-plugin-chart-sankey [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27828: URL: https://github.com/apache/superset/pull/27828 Bumps [d3](https://github.com/d3/d3) from 3.5.17 to 7.9.0. Release notes Sourced from https://github.com/d3/d3/releases";>d3's releases. v7.9.0 Add d3.schemeObservabl

[PR] build(deps): bump @emotion/react from 11.4.1 to 11.11.4 in /superset-frontend [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27827: URL: https://github.com/apache/superset/pull/27827 Bumps [@emotion/react](https://github.com/emotion-js/emotion) from 11.4.1 to 11.11.4. Release notes Sourced from https://github.com/emotion-js/emotion/releases";>@​emotion/react's

[PR] build(deps): bump swagger-ui-react from 4.1.3 to 5.13.0 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27825: URL: https://github.com/apache/superset/pull/27825 Bumps [swagger-ui-react](https://github.com/swagger-api/swagger-ui) from 4.1.3 to 5.13.0. Release notes Sourced from https://github.com/swagger-api/swagger-ui/releases";>swagger-ui

[PR] build(deps): bump d3 from 3.5.17 to 7.9.0 in /superset-frontend/plugins/legacy-plugin-chart-world-map [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27826: URL: https://github.com/apache/superset/pull/27826 Bumps [d3](https://github.com/d3/d3) from 3.5.17 to 7.9.0. Release notes Sourced from https://github.com/d3/d3/releases";>d3's releases. v7.9.0 Add d3.schemeObservabl

[PR] build(deps): bump @algolia/client-search from 4.22.1 to 4.23.2 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27824: URL: https://github.com/apache/superset/pull/27824 Bumps [@algolia/client-search](https://github.com/algolia/algoliasearch-client-javascript) from 4.22.1 to 4.23.2. Release notes Sourced from https://github.com/algolia/algoliasear

[PR] build(deps-dev): bump @tsconfig/docusaurus from 2.0.2 to 2.0.3 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27823: URL: https://github.com/apache/superset/pull/27823 Bumps [@tsconfig/docusaurus](https://github.com/tsconfig/bases/tree/HEAD/bases) from 2.0.2 to 2.0.3. Commits See full diff in https://github.com/tsconfig/bases/commits/HEAD/ba

[PR] build(deps): bump antd from 4.19.3 to 5.16.0 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27822: URL: https://github.com/apache/superset/pull/27822 Bumps [antd](https://github.com/ant-design/ant-design) from 4.19.3 to 5.16.0. Release notes Sourced from https://github.com/ant-design/ant-design/releases";>antd's releases.

Re: [PR] build(deps-dev): update @storybook/react-webpack5 requirement from ^7.6.13 to ^7.6.17 in /superset-frontend/packages/superset-ui-demo [superset]

2024-04-01 Thread via GitHub
dependabot[bot] closed pull request #27323: build(deps-dev): update @storybook/react-webpack5 requirement from ^7.6.13 to ^7.6.17 in /superset-frontend/packages/superset-ui-demo URL: https://github.com/apache/superset/pull/27323 -- This is an automated message from the Apache Git Service. To

[PR] build(deps-dev): bump @storybook/react-webpack5 from 7.6.17 to 8.0.5 in /superset-frontend/packages/superset-ui-demo [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27821: URL: https://github.com/apache/superset/pull/27821 Bumps [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5) from 7.6.17 to 8.0.5. Release notes Sourced from https://githu

[PR] build(deps): bump d3 from 3.5.17 to 7.9.0 in /superset-frontend/plugins/legacy-preset-chart-nvd3 [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27820: URL: https://github.com/apache/superset/pull/27820 Bumps [d3](https://github.com/d3/d3) from 3.5.17 to 7.9.0. Release notes Sourced from https://github.com/d3/d3/releases";>d3's releases. v7.9.0 Add d3.schemeObservabl

Re: [PR] build(deps-dev): update @storybook/react-webpack5 requirement from ^7.6.13 to ^7.6.17 in /superset-frontend/packages/superset-ui-demo [superset]

2024-04-01 Thread via GitHub
dependabot[bot] commented on PR #27323: URL: https://github.com/apache/superset/pull/27323#issuecomment-2029319128 Superseded by #27821. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] build(deps): bump @ant-design/icons from 5.3.1 to 5.3.6 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27819: URL: https://github.com/apache/superset/pull/27819 Bumps [@ant-design/icons](https://github.com/ant-design/ant-design-icons) from 5.3.1 to 5.3.6. Commits See full diff in https://github.com/ant-design/ant-design-icons/commits";

[PR] build(deps): bump @storybook/types from 7.6.17 to 8.0.5 in /superset-frontend/packages/superset-ui-demo [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27817: URL: https://github.com/apache/superset/pull/27817 Bumps [@storybook/types](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/types) from 7.6.17 to 8.0.5. Release notes Sourced from https://github.com/storybookjs/storybo

[PR] build(deps-dev): bump @docusaurus/module-type-aliases from 3.1.1 to 3.2.0 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27818: URL: https://github.com/apache/superset/pull/27818 Bumps [@docusaurus/module-type-aliases](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-module-type-aliases) from 3.1.1 to 3.2.0. Release notes Sourced from h

[PR] build(deps): bump dompurify from 2.4.9 to 3.0.11 in /superset-frontend/plugins/legacy-preset-chart-nvd3 [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27816: URL: https://github.com/apache/superset/pull/27816 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.4.9 to 3.0.11. Release notes Sourced from https://github.com/cure53/DOMPurify/releases";>dompurify's releases.

[PR] build(deps): bump core-js from 3.8.3 to 3.36.1 in /superset-frontend/packages/superset-ui-demo [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27815: URL: https://github.com/apache/superset/pull/27815 Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.8.3 to 3.36.1. Changelog Sourced from https://github.com/zloirock/core-js/blob/master/CHANGE

[PR] build(deps-dev): bump typescript from 5.3.3 to 5.4.3 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27814: URL: https://github.com/apache/superset/pull/27814 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.3 to 5.4.3. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases";>typescript's release

[PR] build(deps): bump @docsearch/react from 3.5.2 to 3.6.0 in /docs [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27813: URL: https://github.com/apache/superset/pull/27813 Bumps [@docsearch/react](https://github.com/algolia/docsearch) from 3.5.2 to 3.6.0. Release notes Sourced from https://github.com/algolia/docsearch/releases";>@​docsearch/react's

[PR] build(deps): bump encodable from 0.7.8 to 0.9.4 in /superset-frontend [superset]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #27812: URL: https://github.com/apache/superset/pull/27812 [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=encodable&package-manager=npm_and_yarn&previous-version=0.7.8&ne

  1   2   >