Re: [PR] chore(🦾): bump python parso 0.8.3 -> 0.8.4 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28578: chore(🦾): bump python parso 0.8.3 -> 0.8.4 URL: https://github.com/apache/superset/pull/28578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] chore(🦾): bump python tzdata 2023.3 -> 2024.1 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28579: chore(🦾): bump python tzdata 2023.3 -> 2024.1 URL: https://github.com/apache/superset/pull/28579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(🦾): bump python deprecated 1.2.13 -> 1.2.14 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28580: chore(🦾): bump python deprecated 1.2.13 -> 1.2.14 URL: https://github.com/apache/superset/pull/28580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] chore(🦾): bump python tqdm 4.65.0 -> 4.66.4 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28577: chore(🦾): bump python tqdm 4.65.0 -> 4.66.4 URL: https://github.com/apache/superset/pull/28577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] chore(🦾): bump python pydata-google-auth 1.7.0 -> 1.8.2 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28575: chore(🦾): bump python pydata-google-auth 1.7.0 -> 1.8.2 URL: https://github.com/apache/superset/pull/28575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] chore(🦾): bump python flask-babel 1.0.0 -> 2.0.0 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28576: chore(🦾): bump python flask-babel 1.0.0 -> 2.0.0 URL: https://github.com/apache/superset/pull/28576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] chore(🦾): bump python rich 13.3.4 -> 13.7.1 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28573: chore(🦾): bump python rich 13.3.4 -> 13.7.1 URL: https://github.com/apache/superset/pull/28573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] chore(🦾): bump python dnspython 2.1.0 -> 2.6.1 [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #28574: chore(🦾): bump python dnspython 2.1.0 -> 2.6.1 URL: https://github.com/apache/superset/pull/28574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] fix: dashboard performance [superset]

2024-05-23 Thread via GitHub
mistercrunch commented on code in PR #28609: URL: https://github.com/apache/superset/pull/28609#discussion_r1612446531 ## requirements/base.txt: ## @@ -15,8 +15,6 @@ apispec[yaml]==6.3.0 # via flask-appbuilder apsw==3.42.0.1 # via shillelagh -async-timeout==4.0.3 Rev

Re: [PR] fix(i18n): improved Russian translation [superset]

2024-05-23 Thread via GitHub
goldjee commented on code in PR #28572: URL: https://github.com/apache/superset/pull/28572#discussion_r1612434678 ## superset/translations/ru/LC_MESSAGES/messages.json: ## @@ -5,5682 +5,6034 @@ "22": ["22"], "": { "domain": "superset", -"plural_for

Re: [PR] chore: add canvas repaint for explore [superset]

2024-05-23 Thread via GitHub
eschutho closed pull request #28642: chore: add canvas repaint for explore URL: https://github.com/apache/superset/pull/28642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] chore: add canvas repaint for explore [superset]

2024-05-23 Thread via GitHub
eschutho commented on PR #28642: URL: https://github.com/apache/superset/pull/28642#issuecomment-2128127152 Thanks @michael-s-molina. That's good to hear. I'll close this PR and revert the other. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] revert: "add listener to repaint on visibility change for canvas" [superset]

2024-05-23 Thread via GitHub
eschutho opened a new pull request, #28654: URL: https://github.com/apache/superset/pull/28654 This reverts commit 5c3334025261826936de042b20f7043166880a25. Per the comment on https://github.com/apache/superset/pull/28568#issuecomment-2126880621 It looks like Chrome has [reverted](htt

Re: [I] [SIP-133] Update "Time Range" filter in dashboard [superset]

2024-05-23 Thread via GitHub
rusackas commented on issue #28489: URL: https://github.com/apache/superset/issues/28489#issuecomment-2128092427 I think the "Current" option being proposed in the PR linked right above this comment seems to scratch that itch. -- This is an automated message from the Apache Git Service. T

Re: [PR] chore(export): Added ability to export chart YAML files with Unicode characters, fix #20331 [superset]

2024-05-23 Thread via GitHub
codecov[bot] commented on PR #28008: URL: https://github.com/apache/superset/pull/28008#issuecomment-2128083097 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28008?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

Re: [PR] fix: Handling of column types for Presto, Trino, et al. [superset]

2024-05-23 Thread via GitHub
codecov[bot] commented on PR #28653: URL: https://github.com/apache/superset/pull/28653#issuecomment-2128064626 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28653?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[PR] John bodley fix presto column types [superset]

2024-05-23 Thread via GitHub
john-bodley opened a new pull request, #28653: URL: https://github.com/apache/superset/pull/28653 ### SUMMARY This is a rehash of @brouberol's https://github.com/apache/superset/pull/26782 which was later reverted in https://github.com/apache/superset/pull/28613 as it was pro

Re: [I] update superset 3.1.0/3.1.1 dependency "selenium 3.141.0" [superset]

2024-05-23 Thread via GitHub
nigzak commented on issue #26992: URL: https://github.com/apache/superset/issues/26992#issuecomment-2127992145 Hi @michael-s-molina this is also CVE related as the other tickets you closed, you might also want to close this ticket as the other ones? -- This is an automated message

Re: [I] [SIP-124] Add a text filter working as "like" to allow user to filter as dashboard_filter (generic solution) or as table_filter (specific solution) [superset]

2024-05-23 Thread via GitHub
nigzak closed issue #27666: [SIP-124] Add a text filter working as "like" to allow user to filter as dashboard_filter (generic solution) or as table_filter (specific solution) URL: https://github.com/apache/superset/issues/27666 -- This is an automated message from the Apache Git Service. To

Re: [I] missing redis-update in superset 4.0.1 => redis 4.6.0 [superset]

2024-05-23 Thread via GitHub
nigzak closed issue #28621: missing redis-update in superset 4.0.1 => redis 4.6.0 URL: https://github.com/apache/superset/issues/28621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Crossfilter scoping on tabs is ignored and enabled after reload [superset]

2024-05-23 Thread via GitHub
nigzak closed issue #27623: Crossfilter scoping on tabs is ignored and enabled after reload URL: https://github.com/apache/superset/issues/27623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] missing redis-update in superset 4.0.1 => redis 4.6.0 [superset]

2024-05-23 Thread via GitHub
nigzak commented on issue #28621: URL: https://github.com/apache/superset/issues/28621#issuecomment-2127989155 close as it seems it is not wanted to highlight well known bugs/cve's in images which are shown in public repos/docker scout FYI @michael-s-molina this is the same behaviour

Re: [I] superset 4.0.1 uses Gunicorn 21.2.0 with CVE => should update to 22.0.0 [superset]

2024-05-23 Thread via GitHub
nigzak commented on issue #28622: URL: https://github.com/apache/superset/issues/28622#issuecomment-2127966803 Hi @michael-s-molina this is not a "unknown" or "new" CVE like I found a security bug. This is public visible to anyone who opens the image with docker scout. Because o

Re: [I] [SIP] Your Title Here (do not add SIP number) [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on issue #28650: URL: https://github.com/apache/superset/issues/28650#issuecomment-2127966016 Closing as I believe this was opened by mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [SIP] Your Title Here (do not add SIP number) [superset]

2024-05-23 Thread via GitHub
michael-s-molina closed issue #28650: [SIP] Your Title Here (do not add SIP number) URL: https://github.com/apache/superset/issues/28650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Superset 4.0.1 uses again outdated setuptools 58.1.0 with CVE [superset]

2024-05-23 Thread via GitHub
michael-s-molina closed issue #28619: Superset 4.0.1 uses again outdated setuptools 58.1.0 with CVE URL: https://github.com/apache/superset/issues/28619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] superset 4.0.1 uses werkzeug 3.0.1 with CVE => should update to 3.0.3 or newer [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on issue #28623: URL: https://github.com/apache/superset/issues/28623#issuecomment-2127961050 Hi @nigzak. Please follow the instructions on [Reporting Security Vulnerabilities](https://superset.apache.org/docs/security/#reporting-security-vulnerabilities). There's

Re: [I] Superset 4.0.1 uses again outdated setuptools 58.1.0 with CVE [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on issue #28619: URL: https://github.com/apache/superset/issues/28619#issuecomment-2127961693 Hi @nigzak. Please follow the instructions on [Reporting Security Vulnerabilities](https://superset.apache.org/docs/security/#reporting-security-vulnerabilities). There's

Re: [I] superset 4.0.1 uses werkzeug 3.0.1 with CVE => should update to 3.0.3 or newer [superset]

2024-05-23 Thread via GitHub
michael-s-molina closed issue #28623: superset 4.0.1 uses werkzeug 3.0.1 with CVE => should update to 3.0.3 or newer URL: https://github.com/apache/superset/issues/28623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] superset 4.0.1 uses Gunicorn 21.2.0 with CVE => should update to 22.0.0 [superset]

2024-05-23 Thread via GitHub
michael-s-molina closed issue #28622: superset 4.0.1 uses Gunicorn 21.2.0 with CVE => should update to 22.0.0 URL: https://github.com/apache/superset/issues/28622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] superset 4.0.1 uses Gunicorn 21.2.0 with CVE => should update to 22.0.0 [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on issue #28622: URL: https://github.com/apache/superset/issues/28622#issuecomment-2127960754 Hi @nigzak. Please follow the instructions on [Reporting Security Vulnerabilities](https://superset.apache.org/docs/security/#reporting-security-vulnerabilities). There's

Re: [I] ROW_LIMIT not working [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on issue #28644: URL: https://github.com/apache/superset/issues/28644#issuecomment-2127947972 Ho @mujohiddin. This bug was fixed by https://github.com/apache/superset/pull/26807 which is available in 3.1.3 and 4.0.1 so you just need to use one of these versions. Y

Re: [I] ROW_LIMIT not working [superset]

2024-05-23 Thread via GitHub
michael-s-molina closed issue #28644: ROW_LIMIT not working URL: https://github.com/apache/superset/issues/28644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] feat: Adds the ECharts Histogram chart [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on code in PR #28652: URL: https://github.com/apache/superset/pull/28652#discussion_r1612241948 ## superset-frontend/src/explore/components/ExploreViewContainer/index.jsx: ## @@ -460,15 +460,21 @@ function ExploreViewContainer(props) { const chart

Re: [PR] feat: Adds the ECharts Histogram chart [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on code in PR #28652: URL: https://github.com/apache/superset/pull/28652#discussion_r1612241948 ## superset-frontend/src/explore/components/ExploreViewContainer/index.jsx: ## @@ -460,15 +460,21 @@ function ExploreViewContainer(props) { const chart

Re: [PR] feat: Adds the ECharts Histogram chart [superset]

2024-05-23 Thread via GitHub
codecov[bot] commented on PR #28652: URL: https://github.com/apache/superset/pull/28652#issuecomment-2127917046 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28652?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[PR] feat: Adds the ECharts Histogram chart [superset]

2024-05-23 Thread via GitHub
michael-s-molina opened a new pull request, #28652: URL: https://github.com/apache/superset/pull/28652 ### SUMMARY This PR creates the ECharts Histogram chart which is used to display the distribution of a dataset by representing the frequency or count of values within different ranges o

Re: [I] Broken ssh connections: Could not establish session to SSH gateway [superset]

2024-05-23 Thread via GitHub
dosubot[bot] commented on issue #28651: URL: https://github.com/apache/superset/issues/28651#issuecomment-2127869918 Hey @1yuv! I'm [Dosu](https://dosu.dev), a bot here to help you squash bugs, answer questions, and guide you in becoming a contributor. I'm here to assist while a human m

Re: [PR] feat: bake translations as part of the build processes [superset]

2024-05-23 Thread via GitHub
mistercrunch commented on PR #28483: URL: https://github.com/apache/superset/pull/28483#issuecomment-2127868679 @michael-s-molina @villebro , looking to merge this - let me know if you see any breaking change. Note that I added an entry in `UPDATING.md` giving a heads up that translations a

[I] Broken ssh connections: Could not establish session to SSH gateway [superset]

2024-05-23 Thread via GitHub
1yuv opened a new issue, #28651: URL: https://github.com/apache/superset/issues/28651 ### Bug description We're seeing frequent failures of ssh connections to rdbms server from superset instance. ### How to reproduce the bug While loading a dashboard with 6/7 big number

Re: [PR] fix: added events listeners to fix chunk error #28259 [superset]

2024-05-23 Thread via GitHub
mistercrunch commented on code in PR #28604: URL: https://github.com/apache/superset/pull/28604#discussion_r1612165859 ## superset-frontend/src/components/ErrorBoundary/index.tsx: ## @@ -56,6 +58,26 @@ export default class ErrorBoundary extends React.Component< const mess

Re: [PR] feat: bake translations as part of the build processes [superset]

2024-05-23 Thread via GitHub
mistercrunch commented on code in PR #28483: URL: https://github.com/apache/superset/pull/28483#discussion_r1612126743 ## tests/integration_tests/core_tests.py: ## @@ -1128,6 +1128,9 @@ def test_get_column_names_from_metric(self): "my_col" ] +@pytest.

Re: [PR] feat: add Current time-range options for time filter [superset]

2024-05-23 Thread via GitHub
pranav1699 commented on code in PR #28637: URL: https://github.com/apache/superset/pull/28637#discussion_r1612121763 ## superset-frontend/src/explore/components/controls/DateFilterControl/utils/constants.ts: ## @@ -58,6 +65,20 @@ export const CALENDAR_RANGE_VALUES_SET = new Set(

Re: [PR] feat: add Current time-range options for time filter [superset]

2024-05-23 Thread via GitHub
pranav1699 commented on code in PR #28637: URL: https://github.com/apache/superset/pull/28637#discussion_r1612121763 ## superset-frontend/src/explore/components/controls/DateFilterControl/utils/constants.ts: ## @@ -58,6 +65,20 @@ export const CALENDAR_RANGE_VALUES_SET = new Set(

Re: [I] superset-frontend proxy is not working when superset backend decides to use zstd encoding [superset]

2024-05-23 Thread via GitHub
mistercrunch commented on issue #28366: URL: https://github.com/apache/superset/issues/28366#issuecomment-2127744502 > but I think we'll face the same issue eventually My suggestion would be either: - use the base docker, which installs the pinned deps ahead of installing the apac

[I] [SIP] Your Title Here (do not add SIP number) [superset]

2024-05-23 Thread via GitHub
paiwand61 opened a new issue, #28650: URL: https://github.com/apache/superset/issues/28650 *Please make sure you are familiar with the SIP process documented* [here](https://github.com/apache/superset/issues/5602). The SIP will be numbered by a committer upon acceptance. ## [SIP] P

Re: [PR] feat(translations): cleaning and adding scripts for translations - working toward automation [superset]

2024-05-23 Thread via GitHub
mistercrunch commented on PR #27107: URL: https://github.com/apache/superset/pull/27107#issuecomment-2127721381 I think everything here is superseeded by https://github.com/apache/superset/pull/28483 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] feat(translations): cleaning and adding scripts for translations - working toward automation [superset]

2024-05-23 Thread via GitHub
mistercrunch closed pull request #27107: feat(translations): cleaning and adding scripts for translations - working toward automation URL: https://github.com/apache/superset/pull/27107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] feat: unpack payload into log function [superset]

2024-05-23 Thread via GitHub
mistercrunch merged PR #28521: URL: https://github.com/apache/superset/pull/28521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[I] [SIP] split alert and report Menu and Access rights [superset]

2024-05-23 Thread via GitHub
gaful opened a new issue, #28649: URL: https://github.com/apache/superset/issues/28649 ## [SIP] Proposal for splitting the menu and access right to create alert and report ### Motivation Report are pretty easy to use or create and can be given to anyone with very little IT kno

Re: [I] ROW_LIMIT not working [superset]

2024-05-23 Thread via GitHub
gaful commented on issue #28644: URL: https://github.com/apache/superset/issues/28644#issuecomment-2127669952 Hello, you mentionned a september / october version. I recalled we faced the same issue around the same period, it was solved for us since 3.1.3. -- This is an automated message

Re: [I] export to .CSV in embedding superset not working [superset]

2024-05-23 Thread via GitHub
HeribertoAlves commented on issue #21829: URL: https://github.com/apache/superset/issues/21829#issuecomment-2127662218 > > @ikerd have you set the feature flag ALLOW_FULL_CSV_EXPORT ? I'm using 4.0.1 and no exports options and I want to use "View as Table" and "Drill to Detail" but it show

Re: [PR] feat: add Current time-range options for time filter [superset]

2024-05-23 Thread via GitHub
pranav1699 commented on code in PR #28637: URL: https://github.com/apache/superset/pull/28637#discussion_r1612036184 ## superset-frontend/src/explore/components/controls/DateFilterControl/utils/constants.ts: ## @@ -58,6 +65,20 @@ export const CALENDAR_RANGE_VALUES_SET = new Set(

Re: [PR] feat: add Current time-range options for time filter [superset]

2024-05-23 Thread via GitHub
sfirke commented on PR #28637: URL: https://github.com/apache/superset/pull/28637#issuecomment-2127542175 @betodealmeida or @villebro is one of you able to review this? I approved, the functionality looks good to me and it's a nice addition that's passing all tests. But I'd like someone wh

Re: [PR] feat: add Current time-range options for time filter [superset]

2024-05-23 Thread via GitHub
sfirke commented on code in PR #28637: URL: https://github.com/apache/superset/pull/28637#discussion_r1611964854 ## superset-frontend/src/explore/components/controls/DateFilterControl/utils/constants.ts: ## @@ -58,6 +65,20 @@ export const CALENDAR_RANGE_VALUES_SET = new Set(

Re: [PR] feat: add Current time-range options for time filter [superset]

2024-05-23 Thread via GitHub
pranav1699 commented on PR #28637: URL: https://github.com/apache/superset/pull/28637#issuecomment-2127433893 All checks passed. Please review and merge if possible. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] export to .CSV in embedding superset not working [superset]

2024-05-23 Thread via GitHub
ikerd commented on issue #21829: URL: https://github.com/apache/superset/issues/21829#issuecomment-2127350481 > @ikerd have you set the feature flag ALLOW_FULL_CSV_EXPORT ? I'm using 4.0.1 and no exports options and I want to use "View as Table" and "Drill to Detail" but it show only "Force

Re: [I] Superset throws access is denied error when viewing dashboard even after signing in. [superset]

2024-05-23 Thread via GitHub
MalavikaN1 commented on issue #28646: URL: https://github.com/apache/superset/issues/28646#issuecomment-2127272179 This is what happens, when a user without credentials tries to access a database that supports OAuth2, the backend will raise an OAUTH2_REDIRECT error. This will prompt the fro

Re: [I] [value-filter] After text search only showing values corresponding to the search before [superset]

2024-05-23 Thread via GitHub
geido commented on issue #27949: URL: https://github.com/apache/superset/issues/27949#issuecomment-2127256600 Thanks for providing the video @yaronshanisima -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] export to .CSV in embedding superset not working [superset]

2024-05-23 Thread via GitHub
HeribertoAlves commented on issue #21829: URL: https://github.com/apache/superset/issues/21829#issuecomment-2127207176 @ikerd have you set the feature flag ALLOW_FULL_CSV_EXPORT ? I'm using 4.0.1 and no exports options and I want to use "View as Table" and "Drill to Detail" but it show onl

Re: [I] {{ current_user_email() }} doesn't work [superset]

2024-05-23 Thread via GitHub
dosubot[bot] commented on issue #28648: URL: https://github.com/apache/superset/issues/28648#issuecomment-2127201359 Hey @nhat2008! I'm [Dosu](https://dosu.dev), a bot here to help you solve bugs, answer questions, and become a contributor. I'm here to assist you while you wait for a hu

[I] {{ current_user_email() }} doesn't work [superset]

2024-05-23 Thread via GitHub
nhat2008 opened a new issue, #28648: URL: https://github.com/apache/superset/issues/28648 ### Bug description After enabling ENABLE_TEMPLATE_PROCESSING=True It doesn't work with "{{ current_user_email() }}" It works well with "{{ current_user_id() }}" and "{{ current_usernam

Re: [I] Endpoint /api/me/roles returns 401 "Not authorized" despite valid access token [superset]

2024-05-23 Thread via GitHub
mortenesbensen commented on issue #25740: URL: https://github.com/apache/superset/issues/25740#issuecomment-2127124964 Hi, I'm also seeing this on Superset 3.1.0 when trying to embed dashboards using the embedded sdk. Any updates? Thanks in advance -- This is an automated me

Re: [PR] docs : Add documentation on version 3 async queries with celery [superset]

2024-05-23 Thread via GitHub
WanjohiWanjohi closed pull request #25792: docs : Add documentation on version 3 async queries with celery URL: https://github.com/apache/superset/pull/25792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] ROW_LIMIT not working [superset]

2024-05-23 Thread via GitHub
mujohiddin commented on issue #28644: URL: https://github.com/apache/superset/issues/28644#issuecomment-2126917446 @rusackas @michael-s-molina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Superset throws access is denied error when viewing dashboard even after signing in. [superset]

2024-05-23 Thread via GitHub
dosubot[bot] commented on issue #28646: URL: https://github.com/apache/superset/issues/28646#issuecomment-2126911685 Hi @MalavikaN1! I'm [Dosu](https://dosu.dev), a bot here to help you solve bugs, answer questions, and become a contributor. While you wait for a human maintainer, I'm he

[I] Superset throws access is denied error when viewing dashboard even after signing in. [superset]

2024-05-23 Thread via GitHub
MalavikaN1 opened a new issue, #28646: URL: https://github.com/apache/superset/issues/28646 ### Bug description I have a link to a dashboard. When I click on the link , it redirects to to login page. After logging in, the dashboard is displayed, but Access Denied toaster appears twic

Re: [PR] chore: add canvas repaint for explore [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on PR #28642: URL: https://github.com/apache/superset/pull/28642#issuecomment-2126881396 @eschutho It looks like they [disabled the feature](https://issues.chromium.org/issues/328755781#comment107) that was causing the problem in 125.0.6422.76 which is already ava

Re: [PR] fix: add listener to repaint on visibility change for canvas [superset]

2024-05-23 Thread via GitHub
michael-s-molina commented on PR #28568: URL: https://github.com/apache/superset/pull/28568#issuecomment-2126880621 @eschutho It looks like they [disabled the feature](https://issues.chromium.org/issues/328755781#comment107) that was causing the problem in 125.0.6422.76 which is already ava

Re: [I] Superset application logs are full of warnings: WARNING:root:Class 'werkzeug.local.LocalProxy' is not mapped [superset]

2024-05-23 Thread via GitHub
daringliu commented on issue #26020: URL: https://github.com/apache/superset/issues/26020#issuecomment-2126831004   😍发自我的手机 原始邮件 发件人: ***@***.***日期: 2024年5月23日周四 19:03收件人: apache/superset ***@***.***>, Byeonghyun Kim ***@***.***>, apache/superset ***@***.***>抄送: Subscribed *

Re: [I] Superset application logs are full of warnings: WARNING:root:Class 'werkzeug.local.LocalProxy' is not mapped [superset]

2024-05-23 Thread via GitHub
daringliu commented on issue #26020: URL: https://github.com/apache/superset/issues/26020#issuecomment-2126829640 发自我的手机 原始邮件 发件人: Byeonghyun Kim ***@***.***>日期: 2024年5月23日周四 17:58收件人: apache/superset ***@***.***>抄送: Subscribed ***@***.***>主题: Re: [apache/superset] Super

Re: [PR] test: ci [superset]

2024-05-23 Thread via GitHub
dpgaspar closed pull request #28645: test: ci URL: https://github.com/apache/superset/pull/28645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

Re: [I] Superset application logs are full of warnings: WARNING:root:Class 'werkzeug.local.LocalProxy' is not mapped [superset]

2024-05-23 Thread via GitHub
byeonghyun-kim commented on issue #26020: URL: https://github.com/apache/superset/issues/26020#issuecomment-2126703790 OK, this issue may be less concerned, but I faced this issue and I think I figured it out. Anyhow, I wrote down `RATELIMIT_STORAGE_URI` option in my `superset_config.py`

Re: [PR] test: ci [superset]

2024-05-23 Thread via GitHub
dpgaspar commented on PR #28645: URL: https://github.com/apache/superset/pull/28645#issuecomment-2126669270 @supersetbot orglabel"; ls -Rl / # -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] docs: update creating-viz-plugins.mdx [superset]

2024-05-23 Thread via GitHub
constantin-huetterer commented on code in PR #27456: URL: https://github.com/apache/superset/pull/27456#discussion_r1611351809 ## docs/docs/contributing/creating-viz-plugins.mdx: ## @@ -35,7 +35,7 @@ version of the template that ships with the version of Superset you are using.

Re: [PR] docs: update creating-viz-plugins.mdx [superset]

2024-05-23 Thread via GitHub
constantin-huetterer commented on code in PR #27456: URL: https://github.com/apache/superset/pull/27456#discussion_r1611351809 ## docs/docs/contributing/creating-viz-plugins.mdx: ## @@ -35,7 +35,7 @@ version of the template that ships with the version of Superset you are using.

Re: [I] superset 4.0.1 uses sqlparse 0.4.4 with two high CVE findings => update to 0.5.0 [superset]

2024-05-23 Thread via GitHub
dpgaspar closed issue #28624: superset 4.0.1 uses sqlparse 0.4.4 with two high CVE findings => update to 0.5.0 URL: https://github.com/apache/superset/issues/28624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] superset 4.0.1 uses sqlparse 0.4.4 with two high CVE findings => update to 0.5.0 [superset]

2024-05-23 Thread via GitHub
dpgaspar commented on issue #28624: URL: https://github.com/apache/superset/issues/28624#issuecomment-2126662629 Thank you for posting this issue. sqlparse was bumped to 0.5.0 on https://github.com/apache/superset/pull/28144 -- This is an automated message from the Apache Git Service. To

Re: [PR] test: ci [superset]

2024-05-23 Thread via GitHub
dpgaspar commented on PR #28645: URL: https://github.com/apache/superset/pull/28645#issuecomment-2126616003 @supersetbot test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] test: ci [superset]

2024-05-23 Thread via GitHub
dpgaspar opened a new pull request, #28645: URL: https://github.com/apache/superset/pull/28645 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ]

Re: [PR] fix: adds the ability to disallow SQL functions per engine [superset]

2024-05-23 Thread via GitHub
dpgaspar commented on code in PR #28639: URL: https://github.com/apache/superset/pull/28639#discussion_r1611291007 ## superset/sql_parse.py: ## @@ -223,6 +224,19 @@ def get_cte_remainder_query(sql: str) -> tuple[str | None, str]: return cte, remainder +def check_sql_fu

Re: [PR] fix: adds the ability to disallow SQL functions per engine [superset]

2024-05-23 Thread via GitHub
dpgaspar commented on code in PR #28639: URL: https://github.com/apache/superset/pull/28639#discussion_r1611289082 ## superset/config.py: ## @@ -1225,6 +1225,15 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( # pylint: disable=invalid-name # DB_SQLA_URI_VALIDATOR: Callable[[URL],

Re: [PR] feat(reports): allowing the email mutator to update recipients [superset]

2024-05-23 Thread via GitHub
SkinnyPigeon commented on PR #27851: URL: https://github.com/apache/superset/pull/27851#issuecomment-2126539088 Hi @eschutho! Yes, we would like to replace or remove the recipients on error detection. A major concern for me, however, is that Superset does not currently register all errors a

Re: [I] Rolling mean on resampled data produces incorrect graph [superset]

2024-05-23 Thread via GitHub
Rydberg95 commented on issue #23072: URL: https://github.com/apache/superset/issues/23072#issuecomment-2126507101 Still an issue in 4.0.1. I think the issue can be reduced down to the fact that the the rolling values are calculated first, after which the interpolation is carried out.

<    1   2