Always-prog commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2132298464
I'll fix the frontend soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Always-prog commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2057285996
@rusackas I see, ok. I have pushed commit with the fix :+1:, please take a
look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rusackas commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2047774826
The main thing I'm wondering about this PR now that I look more closely at
the code, is if there's a better place to store this information. I'm a little
nervous about storing
Always-prog commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2046954495
@rusackas Test cases has beed passed without rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rusackas commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2035493881
Rerunning the mysql test in hopes that it's just flaky, but if it fails
again, the PR _**might**_ need a rebase (there were some glitches with these DB
tests that got resolved on
Always-prog commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2034626260
@john-bodley Hi! Fixed code by your review. Please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Always-prog commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2033916417
Thank you @mistercrunch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Always-prog commented on code in PR #27779:
URL: https://github.com/apache/superset/pull/27779#discussion_r1549248158
##
superset-frontend/src/dashboard/util/permissionUtils.ts:
##
@@ -25,16 +25,14 @@ import {
import { Dashboard } from 'src/types/Dashboard';
import {
mistercrunch commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2033656787
more about the bot here -> https://github.com/apache-superset/supersetbot .
It even has a logo now 烙 烙 烙
mistercrunch commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2033652768
@supersetbot orglabel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mistercrunch commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2033652204
@supersetbot unlabel TechAudit-BI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov-commenter commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2033343365
##
[Codecov](https://app.codecov.io/gh/apache/superset/pull/27779?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
rusackas commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2032909342
> @supersetbot orglabel
> How I can add orglabel?)
@mistercrunch can probably help. Not sure if there's documentation for all
this somewhere... we should probably add a
13 matches
Mail list logo
