github-actions[bot] commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2102805345
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kgabryje merged PR #27995:
URL: https://github.com/apache/superset/pull/27995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
github-actions[bot] commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2102659301
@kgabryje Ephemeral environment spinning up at http://35.89.137.51:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2102635734
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
michael-s-molina commented on code in PR #27995:
URL: https://github.com/apache/superset/pull/27995#discussion_r1595396552
##
superset-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/modernSunset.ts:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Softwa
kgabryje commented on code in PR #27995:
URL: https://github.com/apache/superset/pull/27995#discussion_r1595395284
##
superset-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/modernSunset.ts:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Found
kgabryje commented on code in PR #27995:
URL: https://github.com/apache/superset/pull/27995#discussion_r1595389127
##
superset-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/modernSunset.ts:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Found
kgabryje commented on code in PR #27995:
URL: https://github.com/apache/superset/pull/27995#discussion_r1595388869
##
superset-frontend/src/components/Select/styles.tsx:
##
@@ -55,6 +55,13 @@ export const StyledSelect = styled(AntdSelect, {
.select-all {
border-botto
michael-s-molina commented on code in PR #27995:
URL: https://github.com/apache/superset/pull/27995#discussion_r1595376768
##
superset-frontend/src/components/Select/styles.tsx:
##
@@ -55,6 +55,13 @@ export const StyledSelect = styled(AntdSelect, {
.select-all {
bord
github-actions[bot] commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2100831228
@kgabryje Ephemeral environment spinning up at http://34.216.167.224:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2100808166
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2100791678
@michael-s-molina Thanks for spotting, I updated the PR. I left the styling
for groups in `StyledSelect`, so that the component can be reused for grouped
options
--
This is an auto
michael-s-molina commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2075358354
@kgabryje Did you forget to commit something? I'm still seeing some changes
in the Select component such as group options.
--
This is an automated message from the Apache Gi
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2069681858
@michael-s-molina @geido Following our discussion from last week, I opted
for "low effort" solution for now, which is using Antd Select for
ColorSchemeControl instead of our custom Se
github-actions[bot] commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2063843248
@kgabryje Ephemeral environment spinning up at http://34.222.156.36:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2063825153
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
michael-s-molina commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2052203399
@kgabryje @geido Let's do a meeting to discuss this change as I'm worried
about complexity increase.
--
This is an automated message from the Apache Git Service.
To respond
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2051935402
> If there's no alternative, and we really need to implement this behavior,
then we need to think about how to break the select component because I don't
how this behavior will work w
michael-s-molina commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2051917287
If there's no alternative, and we really need to implement this behavior,
then we need to think about how to break the select component because I don't
how this behavior will
michael-s-molina commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2051911763
> The option groups are supported by the native Antd Select, so in my
opinion we should also support them in our customised Select. Right now the
color scheme picker is our on
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2051848575
> * Selected items are always sorted first. How will that work with groups?
Good question. Currently I left it unsorted, but I was thinking about
sorting the selected within the
michael-s-molina commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2050403617
Maybe another question would be, does it really make a difference separating
color pallets by featured / others / etc? If so, another possible alternative
would be to render t
michael-s-molina commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2050385763
@kgabryje I have some questions about how this behavior will work with some
of the requirements/features of the Select component:
- Selected items are always sorted first. H
kgabryje opened a new pull request, #27995:
URL: https://github.com/apache/superset/pull/27995
### SUMMARY
- adds a bunch of new color schemes
- groups the color schemes in categories: Custom (for color schemes added by
users in config), Featured and Other
- Adds option group handli
24 matches
Mail list logo
