github-actions[bot] commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2056210344
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dpgaspar merged PR #27840:
URL: https://github.com/apache/superset/pull/27840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
github-actions[bot] commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2052107239
@eschutho Ephemeral environment spinning up at http://34.216.119.147:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
eschutho commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2052090948
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2052032745
> > Agreed @dpgaspar. We can definitely do a separate PR just to make all
these modals look the same and use the same component.
>
> @dpgaspar Assuming this 👆🏼, I think the only
michael-s-molina commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2051750163
> Agreed @dpgaspar. We can definitely do a separate PR just to make all
these modals look the same and use the same component.
@dpgaspar Assuming this 👆🏼, I think the on
michael-s-molina commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2049855643
> 2 - Totally agree, I think that the correct design should be imposed at
the component level, then we can remove most of the custom styles.ts. So, I
don't think that doing mo
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2049848087
> Thank you for the improvements @dpgaspar. Here are the comments for the
second review:
>
> > 1 - Fixed the display disabled at the component level
>
> The cursor is cor
github-actions[bot] commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2048542268
@eschutho Ephemeral environment spinning up at http://54.214.102.139:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
eschutho commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2048531023
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559608941
##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) un
michael-s-molina commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559499209
##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559489636
##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) un
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559476034
##
superset-frontend/src/pages/DatabaseList/index.tsx:
##
@@ -230,6 +233,16 @@ function DatabaseList({
{
label: t('Upload file to database'),
chi
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559474828
##
superset-frontend/src/features/home/SubMenu.tsx:
##
@@ -162,6 +162,7 @@ const StyledHeader = styled.div`
const styledDisabled = (theme: SupersetTheme) => css`
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2047587867
@michael-s-molina @kasiazjc I've addressed basically all your comments:
@michael-s-molina
1 - Fixed the display disabled at the component level
2 - fixed the width, did no
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045651454
> @kasiazjc @dpgaspar One thing I forgot to mention was about the loaded
columns. Apart from their names, their types are equality important because
they will inform users if they nee
michael-s-molina commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045601881
@kasiazjc @dpgaspar One thing I forgot to mention was about the loaded
columns. Apart from their names, their types are equality important because
they will inform users if th
kasiazjc commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045477799
Thanks @michael-s-molina for the review and @dpgaspar for working on this!
>
> 1 - I know it's not part of this PR, but could you use this opportunity to
improve how the menu i
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045213575
> This looks great! It gets me wondering about "upload columnar file to
database" and "upload Excel file to database." My users mostly use the Excel
one. Would some aspects of this ov
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1557653728
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
mistercrunch commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556624571
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556499783
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556499378
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556498542
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556493843
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
yousoph commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556492195
##
superset/commands/database/csv_import.py:
##
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
michael-s-molina commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556355099
##
superset-frontend/src/features/databases/CSVUploadModal/index.test.tsx:
##
@@ -0,0 +1,330 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
sfirke commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2043247127
This looks great! It gets me wondering about "upload columnar file to
database" and "upload Excel file to database." My users mostly use the Excel
one. Would some aspects of this ove
michael-s-molina commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556136195
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
michael-s-molina commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1556133882
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1555775226
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
rusackas commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554279700
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554036084
##
superset/commands/database/csv_import.py:
##
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554034363
##
superset-frontend/src/pages/DatabaseList/index.tsx:
##
@@ -230,6 +233,16 @@ function DatabaseList({
{
label: t('Upload file to database'),
chi
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554030824
##
superset-frontend/src/features/databases/CSVUploadModal/styles.ts:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554030212
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554029456
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554027632
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554024631
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
eschutho commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1554025634
##
superset-frontend/src/features/databases/CSVUploadModal/index.tsx:
##
@@ -0,0 +1,805 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
github-actions[bot] commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2040049322
@dpgaspar Ephemeral environment spinning up at http://52.24.73.183:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2040031248
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dpgaspar opened a new pull request, #27840:
URL: https://github.com/apache/superset/pull/27840
### SUMMARY
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ]
44 matches
Mail list logo
