Re: [PR] fix(ListView): avoid firing event on change of selection [superset]

2024-04-12 Thread via GitHub
justinpark commented on PR #27997: URL: https://github.com/apache/superset/pull/27997#issuecomment-2052541149 Closed as #28017 solved the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix(ListView): avoid firing event on change of selection [superset]

2024-04-12 Thread via GitHub
justinpark closed pull request #27997: fix(ListView): avoid firing event on change of selection URL: https://github.com/apache/superset/pull/27997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix(ListView): avoid firing event on change of selection [superset]

2024-04-12 Thread via GitHub
michael-s-molina commented on PR #27997: URL: https://github.com/apache/superset/pull/27997#issuecomment-2051639287 > @justinpark When you paste something on the Select component, it's already selected. The change you did might confuse users because if you paste and then close the select, t

[PR] fix(ListView): avoid firing event on change of selection [superset]

2024-04-11 Thread via GitHub
justinpark opened a new pull request, #27997: URL: https://github.com/apache/superset/pull/27997 ### SUMMARY When you paste a value in the list view filter, the input field automatically submits the input value right away. This happens because the `onSelect` event is triggered when the