nikola-arcadis commented on PR #27017:
URL: https://github.com/apache/superset/pull/27017#issuecomment-2182060909
I don't see this change is published on npmjs registry with version
0.1.0-alpha.11. How can we get the new package with this change?
--
This is an automated message from the
rusackas merged PR #27017:
URL: https://github.com/apache/superset/pull/27017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mistercrunch commented on PR #27017:
URL: https://github.com/apache/superset/pull/27017#issuecomment-2146094742
@rusackas I just made the changes I suggested and removed `superset-ui/core`
dependency that was reference, but wasn't added as a dependancy of the sdk
since it could have
rusackas commented on PR #27017:
URL: https://github.com/apache/superset/pull/27017#issuecomment-2145619227
@mistercrunch @bhaugeea Curious if you see a way forward with this, so we
can close out the PR and Issue. If there's no intent to rebase this in the near
future and get it across the
mistercrunch commented on PR #27017:
URL: https://github.com/apache/superset/pull/27017#issuecomment-1933048978
> I believe the whole ui/core package would need to be added as a dependency
here. I haven't tried to open the can of worms of actually running this repo so
not confident in
mistercrunch commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1482174921
##
superset-embedded-sdk/src/index.ts:
##
@@ -77,6 +80,7 @@ export async function embedDashboard({
id,
supersetDomain,
mountPoint,
+ iframeTitle =
bhaugeea commented on PR #27017:
URL: https://github.com/apache/superset/pull/27017#issuecomment-1930967473
I believe the whole ui/core package would need to be added as a dependency
here. I haven't tried to open the can of worms of actually running this repo so
not confident in being able
rusackas commented on PR #27017:
URL: https://github.com/apache/superset/pull/27017#issuecomment-1930724063
Thanks for following up... running CI 爛
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mistercrunch commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1480238080
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
mistercrunch commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1480238080
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
mistercrunch commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1480238080
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
bhaugeea commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1480083550
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
mistercrunch commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1479152633
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
mistercrunch commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1479152633
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
bhaugeea commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1478846380
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
rusackas commented on code in PR #27017:
URL: https://github.com/apache/superset/pull/27017#discussion_r1478749502
##
superset-embedded-sdk/src/index.ts:
##
@@ -154,6 +154,7 @@ export async function embedDashboard({
});
iframe.src =
bhaugeea opened a new pull request, #27017:
URL: https://github.com/apache/superset/pull/27017
### SUMMARY
Screen reader users may rely on the (missing) title attribute to know that
the iframe is where the dashboard content is. This PR adds a title to the
iframe with the
17 matches
Mail list logo
