Re: [PR] fix: create permissions on DB import [superset]

2024-08-06 Thread via GitHub
betodealmeida merged PR #29802: URL: https://github.com/apache/superset/pull/29802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] fix: create permissions on DB import [superset]

2024-08-05 Thread via GitHub
Vitor-Avila commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1704461441 ## pyproject.toml: ## @@ -236,7 +236,7 @@ legacy_tox_ini = """ # Remember to start celery workers to run celery tests, e.g. # celery --app=superset.tasks.celer

Re: [PR] fix: create permissions on DB import [superset]

2024-08-05 Thread via GitHub
sadpandajoe commented on PR #29802: URL: https://github.com/apache/superset/pull/29802#issuecomment-2269579041 @supersetbot label 4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
betodealmeida commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1702099935 ## superset/db_engine_specs/databricks.py: ## @@ -434,7 +434,25 @@ def get_default_catalog( cls, database: Database, ) -> str | None: +

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
betodealmeida commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1702090563 ## pyproject.toml: ## @@ -236,7 +236,7 @@ legacy_tox_ini = """ # Remember to start celery workers to run celery tests, e.g. # celery --app=superset.tasks.cel

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
Vitor-Avila commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1701959131 ## superset/db_engine_specs/databricks.py: ## @@ -434,7 +434,25 @@ def get_default_catalog( cls, database: Database, ) -> str | None: +

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
Vitor-Avila commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1701945638 ## pyproject.toml: ## @@ -236,7 +236,7 @@ legacy_tox_ini = """ # Remember to start celery workers to run celery tests, e.g. # celery --app=superset.tasks.celer

[PR] fix: create permissions on DB import [superset]

2024-07-31 Thread via GitHub
betodealmeida opened a new pull request, #29802: URL: https://github.com/apache/superset/pull/29802 ### SUMMARY A few bugs related to catalogs and permissions: 1. When a database is imported, catalog and schema permissions are not created. Ideally we should have the